Vasanko/sanic
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

#1989 Add disable app registry (#1993)

Browse Source 
* Bump to v20.12

* Update Changelog

* Add disable app registry

* squash
This commit is contained in:
Adam Hopkins 2021-01-05 16:57:35 +02:00 committed by GitHub
parent 31337ba92a
commit 206992fe40
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sanic/app.py
View File

@ -50,6 +50,7 @@ class Sanic:
strict_slashes=False, strict_slashes=False,
log_config=None, log_config=None,
configure_logging=True, configure_logging=True,
register=None,
): ):
# Get name from previous stack frame # Get name from previous stack frame
@ -88,6 +89,10 @@ class Sanic:
# Register alternative method names # Register alternative method names
self.go_fast = self.run self.go_fast = self.run
if register is not None:
self.config.REGISTER = register
if self.config.REGISTER:
self.__class__.register_app(self) self.__class__.register_app(self)
@property @property

1
sanic/config.py
View File

@ -40,6 +40,7 @@ DEFAULT_CONFIG = {
"PROXIES_COUNT": None, "PROXIES_COUNT": None,
"FORWARDED_FOR_HEADER": "X-Forwarded-For", "FORWARDED_FOR_HEADER": "X-Forwarded-For",
"FALLBACK_ERROR_FORMAT": "html", "FALLBACK_ERROR_FORMAT": "html",
"REGISTER": True,
} }

16
tests/test_app.py
View File

@ -3,6 +3,7 @@ import logging
import sys import sys
from inspect import isawaitable from inspect import isawaitable
from os import environ
from unittest.mock import patch from unittest.mock import patch
import pytest import pytest
@ -290,6 +291,7 @@ def test_app_registry_name_reuse():
with pytest.raises(SanicException): with pytest.raises(SanicException):
Sanic("test") Sanic("test")
Sanic.test_mode = True Sanic.test_mode = True
Sanic("test")
def test_app_registry_retrieval(): def test_app_registry_retrieval():
@ -306,3 +308,17 @@ def test_get_app_does_not_exist_force_create():
assert isinstance( assert isinstance(
Sanic.get_app("does-not-exist", force_create=True), Sanic Sanic.get_app("does-not-exist", force_create=True), Sanic
) )
def test_app_no_registry():
Sanic("no-register", register=False)
with pytest.raises(SanicException):
Sanic.get_app("no-register")
def test_app_no_registry_env():
environ["SANIC_REGISTER"] = "False"
Sanic("no-register")
with pytest.raises(SanicException):
Sanic.get_app("no-register")
del environ["SANIC_REGISTER"]