Vasanko/sanic
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Merge pull request #350 from r0fls/deprecate-loop

Browse Source 
add deprecate loop message
This commit is contained in:
Raphael Deem 2017-01-26 15:24:43 -08:00 committed by GitHub
commit 2774414f9e
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sanic/sanic.py
View File

@ -302,6 +302,10 @@ class Sanic:
""" """
self.error_handler.debug = debug self.error_handler.debug = debug
self.debug = debug self.debug = debug
if loop is not None:
log.warning("Passing a loop will be deprecated in version 0.4.0"
" https://github.com/channelcat/sanic/pull/335"
" has more information.", DeprecationWarning)
self.loop = loop self.loop = loop
server_settings = { server_settings = {
@ -385,6 +389,10 @@ class Sanic:
""" """
Asynchronous version of `run`. Asynchronous version of `run`.
""" """
if loop is not None:
log.warning("Passing a loop will be deprecated in version 0.4.0"
" https://github.com/channelcat/sanic/pull/335"
" has more information.", DeprecationWarning)
loop = get_event_loop() loop = get_event_loop()
server_settings = { server_settings = {
'protocol': protocol, 'protocol': protocol,
@ -444,6 +452,10 @@ class Sanic:
:param stop_event: if provided, is used as a stop signal :param stop_event: if provided, is used as a stop signal
:return: :return:
""" """
if server_settings.get('loop', None) is not None:
log.warning("Passing a loop will be deprecated in version 0.4.0"
" https://github.com/channelcat/sanic/pull/335"
" has more information.", DeprecationWarning)
server_settings['reuse_port'] = True server_settings['reuse_port'] = True
# Create a stop event to be triggered by a signal # Create a stop event to be triggered by a signal