Merge pull request #1063 from r0fls/1062

try to inject the app in add_task method
This commit is contained in:
Raphael Deem 2017-12-27 11:40:05 -08:00 committed by GitHub
commit 2f0076f429
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 2 deletions

View File

@ -88,14 +88,20 @@ class Sanic:
""" """
try: try:
if callable(task): if callable(task):
self.loop.create_task(task()) try:
self.loop.create_task(task(self))
except TypeError:
self.loop.create_task(task())
else: else:
self.loop.create_task(task) self.loop.create_task(task)
except SanicException: except SanicException:
@self.listener('before_server_start') @self.listener('before_server_start')
def run(app, loop): def run(app, loop):
if callable(task): if callable(task):
loop.create_task(task()) try:
loop.create_task(task(self))
except TypeError:
loop.create_task(task())
else: else:
loop.create_task(task) loop.create_task(task)

View File

@ -2,6 +2,7 @@ from sanic import Sanic
from sanic.response import text from sanic.response import text
from threading import Event from threading import Event
import asyncio import asyncio
from queue import Queue
def test_create_task(): def test_create_task():
@ -28,3 +29,19 @@ def test_create_task():
request, response = app.test_client.get('/late') request, response = app.test_client.get('/late')
assert response.body == b'True' assert response.body == b'True'
def test_create_task_with_app_arg():
app = Sanic('test_add_task')
q = Queue()
@app.route('/')
def not_set(request):
return "hello"
async def coro(app):
q.put(app.name)
app.add_task(coro)
request, response = app.test_client.get('/')
assert q.get() == 'test_add_task'