From 47927608b2c02cab80270388c0ecff4f0ccb493c Mon Sep 17 00:00:00 2001 From: John Piasetzki Date: Fri, 25 Nov 2016 15:05:17 -0500 Subject: [PATCH 1/2] Convert connections dict to set Connections don't need to be a dict since the value is never used --- sanic/server.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sanic/server.py b/sanic/server.py index b6233031..dd3c86e0 100644 --- a/sanic/server.py +++ b/sanic/server.py @@ -34,7 +34,7 @@ class HttpProtocol(asyncio.Protocol): '_total_request_size', '_timeout_handler', '_last_communication_time') def __init__(self, *, loop, request_handler, signal=Signal(), - connections={}, request_timeout=60, + connections=set(), request_timeout=60, request_max_size=None): self.loop = loop self.transport = None @@ -56,14 +56,14 @@ class HttpProtocol(asyncio.Protocol): # -------------------------------------------- # def connection_made(self, transport): - self.connections[self] = True + self.connections.add(self) self._timeout_handler = self.loop.call_later( self.request_timeout, self.connection_timeout) self.transport = transport self._last_request_time = current_time def connection_lost(self, exc): - del self.connections[self] + self.connections.discard(self) self._timeout_handler.cancel() self.cleanup() @@ -233,7 +233,7 @@ def serve(host, port, request_handler, before_start=None, after_start=None, trigger_events(before_start, loop) - connections = {} + connections = set() signal = Signal() server_coroutine = loop.create_server(lambda: HttpProtocol( loop=loop, @@ -274,7 +274,7 @@ def serve(host, port, request_handler, before_start=None, after_start=None, # Complete all tasks on the loop signal.stopped = True - for connection in connections.keys(): + for connection in connections: connection.close_if_idle() while connections: From 435d5585e9d1d623b522647daf6296089dc6db85 Mon Sep 17 00:00:00 2001 From: Eli Uriegas Date: Wed, 14 Dec 2016 11:29:09 -0600 Subject: [PATCH 2/2] Fix leftover blank line flake8 build failed here: https://travis-ci.org/channelcat/sanic/builds/183991976 --- sanic/server.py | 1 - 1 file changed, 1 deletion(-) diff --git a/sanic/server.py b/sanic/server.py index d9136a65..a86da9fc 100644 --- a/sanic/server.py +++ b/sanic/server.py @@ -35,7 +35,6 @@ class HttpProtocol(asyncio.Protocol): # connection management '_total_request_size', '_timeout_handler', '_last_communication_time') - def __init__(self, *, loop, request_handler, error_handler, signal=Signal(), connections={}, request_timeout=60, request_max_size=None):