From 3844cec7a4dc8cf436e001c49ee4269842a6f250 Mon Sep 17 00:00:00 2001 From: howie6879 Date: Mon, 22 Jan 2018 14:12:41 +0800 Subject: [PATCH] Add parameter check --- sanic/app.py | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/sanic/app.py b/sanic/app.py index 310d9059..592d04b4 100644 --- a/sanic/app.py +++ b/sanic/app.py @@ -5,7 +5,7 @@ import warnings from asyncio import get_event_loop, ensure_future, CancelledError from collections import deque, defaultdict from functools import partial -from inspect import isawaitable, stack, getmodulename +from inspect import getmodulename, isawaitable, signature, stack from traceback import format_exc from urllib.parse import urlencode, urlunparse from ssl import create_default_context, Purpose @@ -25,7 +25,6 @@ from sanic.websocket import WebSocketProtocol, ConnectionClosed class Sanic: - def __init__(self, name=None, router=None, error_handler=None, load_env=True, request_class=None, strict_slashes=False, log_config=None, @@ -111,9 +110,11 @@ class Sanic: :param event: event to listen to """ + def decorator(listener): self.listeners[event].append(listener) return listener + return decorator # Decorator @@ -143,12 +144,17 @@ class Sanic: strict_slashes = self.strict_slashes def response(handler): - if stream: - handler.is_stream = stream - self.router.add(uri=uri, methods=methods, handler=handler, - host=host, strict_slashes=strict_slashes, - version=version, name=name) - return handler + args = [key for key in signature(handler).parameters.keys()] + if args: + if stream: + handler.is_stream = stream + + self.router.add(uri=uri, methods=methods, handler=handler, + host=host, strict_slashes=strict_slashes, + version=version, name=name) + return handler + else: + raise ValueError('Required parameter `request` missing in the {0}()'.format(handler.__name__)) return response @@ -432,7 +438,7 @@ class Sanic: uri, route = self.router.find_route_by_view_name(view_name, **kw) if not (uri and route): raise URLBuildError('Endpoint with name `{}` was not found'.format( - view_name)) + view_name)) if view_name == 'static' or view_name.endswith('.static'): filename = kwargs.pop('filename', None)