Vasanko/sanic
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix exception_monitoring example to actually work

Browse Source 
Closes #324

Super was used incorrectly in the example, also fixed some formatting
here and there.
This commit is contained in:
Eli Uriegas 2017-01-20 14:36:15 -06:00
parent bef34d66f5
commit 40f1e14bb7
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
examples/exception_monitoring.py
View File

@ -9,17 +9,15 @@ and pass in an instance of it when we create our Sanic instance. Inside this
class' default handler, we can do anything including sending exceptions to class' default handler, we can do anything including sending exceptions to
an external service. an external service.
""" """
from sanic.exceptions import Handler, SanicException
""" """
Imports and code relevant for our CustomHandler class Imports and code relevant for our CustomHandler class
(Ordinarily this would be in a separate file) (Ordinarily this would be in a separate file)
""" """
from sanic.response import text
from sanic.exceptions import Handler, SanicException
class CustomHandler(Handler): class CustomHandler(Handler):
def default(self, request, exception): def default(self, request, exception):
# Here, we have access to the exception object # Here, we have access to the exception object
# and can do anything with it (log, send to external service, etc) # and can do anything with it (log, send to external service, etc)
@ -31,9 +29,7 @@ class CustomHandler(Handler):
# Then, we must finish handling the exception by returning # Then, we must finish handling the exception by returning
# our response to the client # our response to the client
# For this we can just call the super class' default handler # For this we can just call the super class' default handler
return super.default(self, request, exception) return super().default(request, exception)
""" """
@ -49,11 +45,12 @@ app = Sanic(__name__)
handler = CustomHandler(sanic=app) handler = CustomHandler(sanic=app)
app.error_handler = handler app.error_handler = handler
@app.route("/") @app.route("/")
async def test(request): async def test(request):
# Here, something occurs which causes an unexpected exception # Here, something occurs which causes an unexpected exception
# This exception will flow to our custom handler. # This exception will flow to our custom handler.
x = 1 / 0 1 / 0
return json({"test": True}) return json({"test": True})