Deprecation and test cleanup (#1818)
* Remove remove_route, deprecated in 19.6. * No need for py35 compat anymore. * Rewrite asyncio.coroutines with async/await. * Remove deprecated request.raw_args. * response.text() takes str only: avoid deprecation warning in all but one test. * Remove unused import. * Revert unnecessary deprecation warning. * Remove apparently unnecessary py38 compat. * Avoid asyncio.Task.all_tasks deprecation warning. * Avoid warning on a test that tests deprecated response.text(int). * Add pytest-asyncio to tox deps. * Run the coroutine returned by AsyncioServer.close. Co-authored-by: L. Kärkkäinen <tronic@users.noreply.github.com>
This commit is contained in:
		
							
								
								
									
										30
									
								
								sanic/app.py
									
									
									
									
									
								
							
							
						
						
									
										30
									
								
								sanic/app.py
									
									
									
									
									
								
							| @@ -507,12 +507,7 @@ class Sanic: | ||||
|                 if self.asgi: | ||||
|                     ws = request.transport.get_websocket_connection() | ||||
|                 else: | ||||
|                     try: | ||||
|                         protocol = request.transport.get_protocol() | ||||
|                     except AttributeError: | ||||
|                         # On Python3.5 the Transport classes in asyncio do not | ||||
|                         # have a get_protocol() method as in uvloop | ||||
|                         protocol = request.transport._protocol | ||||
|                     protocol = request.transport.get_protocol() | ||||
|                     protocol.app = self | ||||
|  | ||||
|                     ws = await protocol.websocket_handshake( | ||||
| @@ -599,29 +594,6 @@ class Sanic: | ||||
|  | ||||
|         self.websocket_enabled = enable | ||||
|  | ||||
|     def remove_route(self, uri, clean_cache=True, host=None): | ||||
|         """ | ||||
|         This method provides the app user a mechanism by which an already | ||||
|         existing route can be removed from the :class:`Sanic` object | ||||
|  | ||||
|         .. warning:: | ||||
|             remove_route is deprecated in v19.06 and will be removed | ||||
|             from future versions. | ||||
|  | ||||
|         :param uri: URL Path to be removed from the app | ||||
|         :param clean_cache: Instruct sanic if it needs to clean up the LRU | ||||
|             route cache | ||||
|         :param host: IP address or FQDN specific to the host | ||||
|         :return: None | ||||
|         """ | ||||
|         warnings.warn( | ||||
|             "remove_route is deprecated and will be removed " | ||||
|             "from future versions.", | ||||
|             DeprecationWarning, | ||||
|             stacklevel=2, | ||||
|         ) | ||||
|         self.router.remove(uri, clean_cache, host) | ||||
|  | ||||
|     # Decorator | ||||
|     def exception(self, *exceptions): | ||||
|         """Decorate a function to be registered as a handler for exceptions | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 L. Kärkkäinen
					L. Kärkkäinen