From df914a92e40cd03dbf37a7ca7d6929d380b1a585 Mon Sep 17 00:00:00 2001
From: 38elements <mh19820223@gmail.com>
Date: Wed, 19 Apr 2017 11:19:01 +0900
Subject: [PATCH 1/2] Fix `this.signal.stopped` is `True` #639

---
 sanic/app.py | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/sanic/app.py b/sanic/app.py
index 0ff98423..f5fffba7 100644
--- a/sanic/app.py
+++ b/sanic/app.py
@@ -16,7 +16,7 @@ from sanic.handlers import ErrorHandler
 from sanic.log import log
 from sanic.response import HTTPResponse, StreamingHTTPResponse
 from sanic.router import Router
-from sanic.server import serve, serve_multiple, HttpProtocol
+from sanic.server import serve, serve_multiple, HttpProtocol, Signal
 from sanic.static import register as static_register
 from sanic.testing import SanicTestClient
 from sanic.views import CompositionView
@@ -548,12 +548,13 @@ class Sanic:
                 warnings.simplefilter('default')
             warnings.warn("stop_event will be removed from future versions.",
                           DeprecationWarning)
+        signal = Signal()
         server_settings = self._helper(
             host=host, port=port, debug=debug, before_start=before_start,
             after_start=after_start, before_stop=before_stop,
             after_stop=after_stop, ssl=ssl, sock=sock, workers=workers,
             loop=loop, protocol=protocol, backlog=backlog,
-            register_sys_signals=register_sys_signals)
+            register_sys_signals=register_sys_signals, signal=signal)
 
         try:
             self.is_running = True
@@ -594,12 +595,13 @@ class Sanic:
                 warnings.simplefilter('default')
             warnings.warn("stop_event will be removed from future versions.",
                           DeprecationWarning)
+        signal = Signal()
         server_settings = self._helper(
             host=host, port=port, debug=debug, before_start=before_start,
             after_start=after_start, before_stop=before_stop,
             after_stop=after_stop, ssl=ssl, sock=sock,
             loop=loop or get_event_loop(), protocol=protocol,
-            backlog=backlog, run_async=True)
+            backlog=backlog, run_async=True, signal=signal)
 
         return await serve(**server_settings)
 
@@ -629,7 +631,7 @@ class Sanic:
                 before_start=None, after_start=None, before_stop=None,
                 after_stop=None, ssl=None, sock=None, workers=1, loop=None,
                 protocol=HttpProtocol, backlog=100, stop_event=None,
-                register_sys_signals=True, run_async=False):
+                register_sys_signals=True, run_async=False, signal=None):
         """Helper function used by `run` and `create_server`."""
 
         if isinstance(ssl, dict):
@@ -674,6 +676,7 @@ class Sanic:
             'port': port,
             'sock': sock,
             'ssl': ssl,
+            'signal': signal,
             'debug': debug,
             'request_handler': self.handle_request,
             'error_handler': self.error_handler,

From bc035fca7816f1e609cec389d4b57a410488114b Mon Sep 17 00:00:00 2001
From: 38elements <mh19820223@gmail.com>
Date: Thu, 20 Apr 2017 18:27:28 +0900
Subject: [PATCH 2/2] Remove unnecessary variables

---
 sanic/app.py | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/sanic/app.py b/sanic/app.py
index f5fffba7..d4dc4e3d 100644
--- a/sanic/app.py
+++ b/sanic/app.py
@@ -548,13 +548,12 @@ class Sanic:
                 warnings.simplefilter('default')
             warnings.warn("stop_event will be removed from future versions.",
                           DeprecationWarning)
-        signal = Signal()
         server_settings = self._helper(
             host=host, port=port, debug=debug, before_start=before_start,
             after_start=after_start, before_stop=before_stop,
             after_stop=after_stop, ssl=ssl, sock=sock, workers=workers,
             loop=loop, protocol=protocol, backlog=backlog,
-            register_sys_signals=register_sys_signals, signal=signal)
+            register_sys_signals=register_sys_signals)
 
         try:
             self.is_running = True
@@ -595,13 +594,12 @@ class Sanic:
                 warnings.simplefilter('default')
             warnings.warn("stop_event will be removed from future versions.",
                           DeprecationWarning)
-        signal = Signal()
         server_settings = self._helper(
             host=host, port=port, debug=debug, before_start=before_start,
             after_start=after_start, before_stop=before_stop,
             after_stop=after_stop, ssl=ssl, sock=sock,
             loop=loop or get_event_loop(), protocol=protocol,
-            backlog=backlog, run_async=True, signal=signal)
+            backlog=backlog, run_async=True)
 
         return await serve(**server_settings)
 
@@ -631,7 +629,7 @@ class Sanic:
                 before_start=None, after_start=None, before_stop=None,
                 after_stop=None, ssl=None, sock=None, workers=1, loop=None,
                 protocol=HttpProtocol, backlog=100, stop_event=None,
-                register_sys_signals=True, run_async=False, signal=None):
+                register_sys_signals=True, run_async=False):
         """Helper function used by `run` and `create_server`."""
 
         if isinstance(ssl, dict):
@@ -676,7 +674,7 @@ class Sanic:
             'port': port,
             'sock': sock,
             'ssl': ssl,
-            'signal': signal,
+            'signal': Signal(),
             'debug': debug,
             'request_handler': self.handle_request,
             'error_handler': self.error_handler,