Vasanko/sanic
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix server crash on request.server_port when bound to IPv6.

Browse Source 
If no X-Forwarded-Port nor Host headers are present, Sanic uses "sockname"
to determine the port. This expected (host, port) tuple to be returned but
for IPv6 a 4-tuple is returned instead. Changed code so that port is picked
up in either case. Handling of "peername" was already correct in this regard.

_get_address and server_port both still return incorrect data or crash for
other socket types (e.g unix). Socket type should checked before any queries.
This commit is contained in:
L. Kärkkäinen 2019-07-22 15:25:21 +03:00
parent 84b41123f2
commit 7c7bedfa5d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sanic/request.py
View File

@ -388,7 +388,7 @@ class Request(dict):
if forwarded_port: if forwarded_port:
return int(forwarded_port) return int(forwarded_port)
else: else:
_, port = self.transport.get_extra_info("sockname") port = self.transport.get_extra_info("sockname")[1]
return port return port
@property @property