Even more cleanup and error checking, 8 failing tests.

tests/test_logging.py

@@ -109,12 +109,11 @@ def test_log_connection_lost(app, debug, monkeypatch):
     @app.route("/conn_lost")
     async def conn_lost(request):
         response = text("Ok")
-        response.output = Mock(side_effect=RuntimeError)
+        request.transport.close()
         return response
 
-    with pytest.raises(ValueError):
-        # catch ValueError: Exception during request
-        app.test_client.get("/conn_lost", debug=debug)
+    req, res = app.test_client.get("/conn_lost", debug=debug)
+    assert res is None
 
     log = stream.getvalue()
 

tests/test_middleware.py

@@ -54,7 +54,7 @@ def test_middleware_response(app):
 
 
 def test_middleware_response_exception(app):
-    result = {"status_code": None}
+    result = {"status_code": "middleware not run"}
 
     @app.middleware("response")
     async def process_response(request, response):

tests/test_request_timeout.py

@@ -79,8 +79,12 @@ class DelayableSanicTestClient(SanicTestClient):
 
 request_timeout_default_app = Sanic("test_request_timeout_default")
 request_no_timeout_app = Sanic("test_request_no_timeout")
-request_timeout_default_app.config.REQUEST_TIMEOUT = 0.6
-request_no_timeout_app.config.REQUEST_TIMEOUT = 0.6
+
+# Note: The delayed client pauses before making a request, so technically
+# it is in keep alive duration. Earlier Sanic versions entered a new connection
+# in request mode even if no bytes of request were received.
+request_timeout_default_app.config.KEEP_ALIVE_TIMEOUT = 0.6
+request_no_timeout_app.config.KEEP_ALIVE_TIMEOUT = 0.6
 
 
 @request_timeout_default_app.route("/1")

tests/test_response.py

@@ -469,6 +469,7 @@ def test_file_stream_response_range(
         )
 
     request, response = app.test_client.get("/files/{}".format(file_name))
+    print(response.body)
     assert response.status == 206
     assert "Content-Range" in response.headers
     assert response.headers["Content-Range"] == "bytes {}-{}/{}".format(