upgrade pytest version that compatible with pytest-cov, fixes some caplog unit tests (#1464)

setup.py

@@ -86,7 +86,7 @@ requirements = [
 ]
 
 tests_require = [
-    "pytest==3.3.2",
+    "pytest==4.1.0",
     "multidict>=4.0,<5.0",
     "gunicorn",
     "pytest-cov",

tests/test_app.py

@@ -155,8 +155,8 @@ def test_handle_request_with_nested_sanic_exception(app, monkeypatch, caplog):
         request, response = app.test_client.get("/")
     assert response.status == 500
     assert response.text == "Error: Mock SanicException"
-    assert caplog.record_tuples[0] == (
+    assert (
         "sanic.root",
         logging.ERROR,
         "Exception occurred while handling uri: 'http://127.0.0.1:42101/'",
-    )
+    ) in caplog.record_tuples

tests/test_keep_alive_timeout.py

@@ -161,7 +161,7 @@ class ReuseableSanicTestClient(SanicTestClient):
                 conn = self._tcp_connector
             else:
                 conn = ReuseableTCPConnector(
-                    verify_ssl=False,
+                    ssl=False,
                     loop=self._loop,
                     keepalive_timeout=request_keepalive,
                 )

tests/test_middleware.py

@@ -86,12 +86,12 @@ def test_middleware_response_raise_cancelled_error(app, caplog):
     with caplog.at_level(logging.ERROR):
         reqrequest, response = app.test_client.get("/")
 
-    assert response.status == 503
+        assert response.status == 503
-    assert caplog.record_tuples[0] == (
+        assert (
-        "sanic.root",
+            "sanic.root",
-        logging.ERROR,
+            logging.ERROR,
-        "Exception occurred while handling uri: 'http://127.0.0.1:42101/'",
+            "Exception occurred while handling uri: 'http://127.0.0.1:42101/'",
-    )
+        ) in caplog.record_tuples
 
 
 def test_middleware_response_raise_exception(app, caplog):
@@ -103,16 +103,16 @@ def test_middleware_response_raise_exception(app, caplog):
         reqrequest, response = app.test_client.get("/")
 
     assert response.status == 404
-    assert caplog.record_tuples[0] == (
+    assert (
         "sanic.root",
         logging.ERROR,
         "Exception occurred while handling uri: 'http://127.0.0.1:42101/'",
-    )
+    ) in caplog.record_tuples
-    assert caplog.record_tuples[1] == (
+    assert (
         "sanic.error",
         logging.ERROR,
         "Exception occurred in one of response middleware handlers",
-    )
+    ) in caplog.record_tuples
 
 
 def test_middleware_override_request(app):

tests/test_request_timeout.py

@@ -152,7 +152,7 @@ class DelayableSanicTestClient(SanicTestClient):
             )
         conn = DelayableTCPConnector(
             pre_request_delay=self._request_delay,
-            verify_ssl=False,
+            ssl=False,
             loop=self._loop,
         )
         async with aiohttp.ClientSession(

tox.ini

@@ -8,7 +8,7 @@ setenv =
     {py35,py36,py37}-no-ext: SANIC_NO_UVLOOP=1
 deps =
     coverage
-    pytest==3.3.2
+    pytest==4.1.0
     pytest-cov
     pytest-sanic
     pytest-sugar