Warn on duplicate route names (#2525)

This commit is contained in:
Adam Hopkins
2022-08-10 20:36:47 +03:00
committed by GitHub
parent 2f6f2bfa76
commit 8e9342e188
2 changed files with 31 additions and 0 deletions

View File

@@ -1521,6 +1521,18 @@ class Sanic(BaseSanic, RunnerMixin, metaclass=TouchUpMeta):
self.signalize(self.config.TOUCHUP)
self.finalize()
route_names = [route.name for route in self.router.routes]
duplicates = {
name for name in route_names if route_names.count(name) > 1
}
if duplicates:
names = ", ".join(duplicates)
deprecation(
f"Duplicate route names detected: {names}. In the future, "
"Sanic will enforce uniqueness in route naming.",
23.3,
)
# TODO: Replace in v22.6 to check against apps in app registry
if (
self.__class__._uvloop_setting is not None