Vasanko/sanic
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix tests for multiprocessing pickle app and pickle blueprint (#1680)

Browse Source 
The old tests were not quite checking for the right thing.
Fixing the test does not change Sanic code, expose any bugs, or fix any bugs.
This commit is contained in:
Ashley Sommer 2019-09-19 03:22:24 +10:00 committed by 7
parent 7674e917e4
commit 927c0e082e
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/test_multiprocessing.py
View File

@ -5,6 +5,7 @@ import signal
import pytest import pytest
from sanic import Blueprint
from sanic.response import text from sanic.response import text
from sanic.testing import HOST, PORT from sanic.testing import HOST, PORT
@ -37,8 +38,6 @@ def test_multiprocessing(app):
reason="SIGALRM is not implemented for this platform", reason="SIGALRM is not implemented for this platform",
) )
def test_multiprocessing_with_blueprint(app): def test_multiprocessing_with_blueprint(app):
from sanic import Blueprint
# Selects a number at random so we can spot check # Selects a number at random so we can spot check
num_workers = random.choice(range(2, multiprocessing.cpu_count() * 2 + 1)) num_workers = random.choice(range(2, multiprocessing.cpu_count() * 2 + 1))
process_list = set() process_list = set()
@ -64,27 +63,27 @@ def handler(request):
return text("Hello") return text("Hello")
# Muliprocessing on Windows requires app to be able to be pickled # Multiprocessing on Windows requires app to be able to be pickled
@pytest.mark.parametrize("protocol", [3, 4]) @pytest.mark.parametrize("protocol", [3, 4])
def test_pickle_app(app, protocol): def test_pickle_app(app, protocol):
app.route("/")(handler) app.route("/")(handler)
p_app = pickle.dumps(app, protocol=protocol) p_app = pickle.dumps(app, protocol=protocol)
del app
up_p_app = pickle.loads(p_app) up_p_app = pickle.loads(p_app)
assert up_p_app assert up_p_app
request, response = app.test_client.get("/") request, response = up_p_app.test_client.get("/")
assert response.text == "Hello" assert response.text == "Hello"
@pytest.mark.parametrize("protocol", [3, 4]) @pytest.mark.parametrize("protocol", [3, 4])
def test_pickle_app_with_bp(app, protocol): def test_pickle_app_with_bp(app, protocol):
from sanic import Blueprint
bp = Blueprint("test_text") bp = Blueprint("test_text")
bp.route("/")(handler) bp.route("/")(handler)
app.blueprint(bp) app.blueprint(bp)
p_app = pickle.dumps(app, protocol=protocol) p_app = pickle.dumps(app, protocol=protocol)
del app
up_p_app = pickle.loads(p_app) up_p_app = pickle.loads(p_app)
assert up_p_app assert up_p_app
request, response = app.test_client.get("/") request, response = up_p_app.test_client.get("/")
assert app.is_request_stream is False assert up_p_app.is_request_stream is False
assert response.text == "Hello" assert response.text == "Hello"