Vasanko/sanic
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Split create_server tests so loop isn't closed prematurely

Browse Source
This commit is contained in:
prryplatypus 2021-11-01 19:57:50 +01:00
parent 0dbf1b2504
commit 9de0e341e9
No known key found for this signature in database
GPG Key ID: 6687E128FB70819B
1 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/test_app.py
View File

@ -455,16 +455,29 @@ def test_uvloop_usage(app, monkeypatch):
app.test_client.get("/test") app.test_client.get("/test")
use_uvloop.assert_called_once() use_uvloop.assert_called_once()
# Try with create_server
use_uvloop.reset_mock() def test_uvloop_usage_with_create_server(app, monkeypatch):
@app.get("/test")
def handler(request):
return text("ok")
use_uvloop = Mock()
monkeypatch.setattr(sanic.app, "use_uvloop", use_uvloop)
loop = asyncio.get_event_loop() loop = asyncio.get_event_loop()
app.config["USE_UVLOOP"] = False app.config["USE_UVLOOP"] = False
asyncio_srv_coro = app.create_server(return_asyncio_server=True) asyncio_srv_coro = app.create_server(
return_asyncio_server=True,
asyncio_server_kwargs=dict(start_serving=False)
)
loop.run_until_complete(asyncio_srv_coro) loop.run_until_complete(asyncio_srv_coro)
use_uvloop.assert_not_called() use_uvloop.assert_not_called()
app.config["USE_UVLOOP"] = True app.config["USE_UVLOOP"] = True
asyncio_srv_coro = app.create_server(return_asyncio_server=True) asyncio_srv_coro = app.create_server(
return_asyncio_server=True,
asyncio_server_kwargs=dict(start_serving=False)
)
loop.run_until_complete(asyncio_srv_coro) loop.run_until_complete(asyncio_srv_coro)
use_uvloop.assert_called_once() use_uvloop.assert_called_once()