Vasanko/sanic
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Refactor test cases to improve unit test quality (#2796)

Browse Source 
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
This commit is contained in:
freddiewanah 2023-09-07 22:26:56 +10:00 committed by GitHub
parent 91d7e6a77d
commit a5a9658896
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/test_response.py
View File

@ -20,6 +20,7 @@ from pytest import LogCaptureFixture
from sanic import Request, Sanic from sanic import Request, Sanic
from sanic.compat import Header from sanic.compat import Header
from sanic.constants import DEFAULT_HTTP_CONTENT_TYPE
from sanic.cookies import CookieJar from sanic.cookies import CookieJar
from sanic.response import ( from sanic.response import (
HTTPResponse, HTTPResponse,
@ -545,7 +546,7 @@ def test_raw_response(app):
return raw(b"raw_response") return raw(b"raw_response")
request, response = app.test_client.get("/test") request, response = app.test_client.get("/test")
assert response.content_type == "application/octet-stream" assert response.content_type == DEFAULT_HTTP_CONTENT_TYPE
assert response.body == b"raw_response" assert response.body == b"raw_response"

10
tests/test_routes.py
View File

@ -502,7 +502,7 @@ def test_dynamic_route_int(app):
request, response = app.test_client.get("/folder/12345") request, response = app.test_client.get("/folder/12345")
assert response.text == "OK" assert response.text == "OK"
assert type(results[0]) is int assert isinstance(results[0], int)
request, response = app.test_client.get("/folder/asdf") request, response = app.test_client.get("/folder/asdf")
assert response.status == 404 assert response.status == 404
@ -518,7 +518,7 @@ def test_dynamic_route_number(app):
request, response = app.test_client.get("/weight/12345") request, response = app.test_client.get("/weight/12345")
assert response.text == "OK" assert response.text == "OK"
assert type(results[0]) is float assert isinstance(results[0], float)
request, response = app.test_client.get("/weight/1234.56") request, response = app.test_client.get("/weight/1234.56")
assert response.status == 200 assert response.status == 200
@ -567,7 +567,7 @@ def test_dynamic_route_uuid(app):
url = "/quirky/123e4567-e89b-12d3-a456-426655440000" url = "/quirky/123e4567-e89b-12d3-a456-426655440000"
request, response = app.test_client.get(url) request, response = app.test_client.get(url)
assert response.text == "OK" assert response.text == "OK"
assert type(results[0]) is uuid.UUID assert isinstance(results[0], uuid.UUID)
generated_uuid = uuid.uuid4() generated_uuid = uuid.uuid4()
request, response = app.test_client.get(f"/quirky/{generated_uuid}") request, response = app.test_client.get(f"/quirky/{generated_uuid}")
@ -861,7 +861,7 @@ def test_dynamic_add_route_int(app):
request, response = app.test_client.get("/folder/12345") request, response = app.test_client.get("/folder/12345")
assert response.text == "OK" assert response.text == "OK"
assert type(results[0]) is int assert isinstance(results[0], int)
request, response = app.test_client.get("/folder/asdf") request, response = app.test_client.get("/folder/asdf")
assert response.status == 404 assert response.status == 404
@ -878,7 +878,7 @@ def test_dynamic_add_route_number(app):
request, response = app.test_client.get("/weight/12345") request, response = app.test_client.get("/weight/12345")
assert response.text == "OK" assert response.text == "OK"
assert type(results[0]) is float assert isinstance(results[0], float)
request, response = app.test_client.get("/weight/1234.56") request, response = app.test_client.get("/weight/1234.56")
assert response.status == 200 assert response.status == 200