Merge pull request #1082 from channelcat/1042

fix exception handling
2018-01-13 17:06:46 -08:00 · 2018-01-13 17:06:46 -08:00 · ab97018c78
commit ab97018c78
parent be702b0924 7a1dab3319
1 changed files with 7 additions and 3 deletions
--- a/sanic/app.py
+++ b/sanic/app.py
@ -577,13 +577,17 @@ class Sanic:
                if isawaitable(response):
                    response = await response
            except Exception as e:
-                if self.debug:
+                if isinstance(e, SanicException):
+                    response = self.error_handler.default(request=request,
+                                                          exception=e)
+                elif self.debug:
                    response = HTTPResponse(
                        "Error while handling error: {}\nStack: {}".format(
-                            e, format_exc()))
+                            e, format_exc()), status=500)
                else:
                    response = HTTPResponse(
-                        "An error occurred while handling an error")
+                        "An error occurred while handling an error",
+                        status=500)
        finally:
            # -------------------------------------------- #
            # Response Middleware