Vasanko/sanic
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Enhance error logging

Browse Source 
- Prevent to fall into error logging recursion when it doesn't have
request info (Print 'Unknown' when the request is still `None`
- Print repr(e) rather than str(e)
This commit is contained in:
Jeong YunWon 2017-02-10 18:15:14 +09:00
parent 6ecf2a6eb2
commit b44e8167d7
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sanic/server.py
View File

@ -179,7 +179,8 @@ class HttpProtocol(asyncio.Protocol):
self.request.ip)) self.request.ip))
except Exception as e: except Exception as e:
self.bail_out( self.bail_out(
"Writing response failed, connection closed {}".format(e)) "Writing response failed, connection closed {}".format(
repr(e)))
finally: finally:
if not keep_alive: if not keep_alive:
self.transport.close() self.transport.close()
@ -196,10 +197,10 @@ class HttpProtocol(asyncio.Protocol):
except RuntimeError: except RuntimeError:
log.error( log.error(
'Connection lost before error written @ {}'.format( 'Connection lost before error written @ {}'.format(
self.request.ip)) self.request.ip if self.request else 'Unknown'))
except Exception as e: except Exception as e:
self.bail_out( self.bail_out(
"Writing error failed, connection closed {}".format(e), "Writing error failed, connection closed {}".format(repr(e)),
from_error=True) from_error=True)
finally: finally:
self.transport.close() self.transport.close()