Trigger http.lifecycle.request signal in ASGI mode (#2451)
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
This commit is contained in:
parent
65b53a5f3f
commit
b87982769f
|
@ -163,6 +163,13 @@ class ASGIApp:
|
|||
instance.request_body = True
|
||||
instance.request.conn_info = ConnInfo(instance.transport)
|
||||
|
||||
await sanic_app.dispatch(
|
||||
"http.lifecycle.request",
|
||||
inline=True,
|
||||
context={"request": instance.request},
|
||||
fail_not_found=False,
|
||||
)
|
||||
|
||||
return instance
|
||||
|
||||
async def read(self) -> Optional[bytes]:
|
||||
|
|
|
@ -13,6 +13,7 @@ from sanic.exceptions import BadRequest, Forbidden, ServiceUnavailable
|
|||
from sanic.request import Request
|
||||
from sanic.response import json, text
|
||||
from sanic.server.websockets.connection import WebSocketConnection
|
||||
from sanic.signals import RESERVED_NAMESPACES
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
|
@ -513,3 +514,34 @@ async def test_request_exception_suppressed_by_middleware(app):
|
|||
|
||||
_, response = await app.asgi_client.get("/error-prone")
|
||||
assert response.status_code == 403
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_signals_triggered(app):
|
||||
@app.get("/test_signals_triggered")
|
||||
async def _request(request):
|
||||
return text("test_signals_triggered")
|
||||
|
||||
signals_triggered = []
|
||||
signals_expected = [
|
||||
# "http.lifecycle.begin",
|
||||
# "http.lifecycle.read_head",
|
||||
"http.lifecycle.request",
|
||||
"http.lifecycle.handle",
|
||||
"http.routing.before",
|
||||
"http.routing.after",
|
||||
"http.lifecycle.response",
|
||||
# "http.lifecycle.send",
|
||||
# "http.lifecycle.complete",
|
||||
]
|
||||
|
||||
def signal_handler(signal):
|
||||
return lambda *a, **kw: signals_triggered.append(signal)
|
||||
|
||||
for signal in RESERVED_NAMESPACES["http"]:
|
||||
app.signal(signal)(signal_handler(signal))
|
||||
|
||||
_, response = await app.asgi_client.get("/test_signals_triggered")
|
||||
assert response.status_code == 200
|
||||
assert response.text == "test_signals_triggered"
|
||||
assert signals_triggered == signals_expected
|
||||
|
|
Loading…
Reference in New Issue
Block a user