From ec10d24ac6a018cb76bbecc983b9cd5677c0891d Mon Sep 17 00:00:00 2001 From: Channel Cat Date: Fri, 14 Oct 2016 03:57:48 -0700 Subject: [PATCH] Minor speed improvements --- sanic/sanic.py | 10 +++++----- sanic/server.py | 5 ++--- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/sanic/sanic.py b/sanic/sanic.py index 98bea9f9..a8b532ce 100644 --- a/sanic/sanic.py +++ b/sanic/sanic.py @@ -97,21 +97,21 @@ class Sanic: """ try: # Middleware process_request - response = None + response = False # The if improves speed. I don't know why if self.request_middleware: for middleware in self.request_middleware: response = middleware(request) if isawaitable(response): response = await response - if response is not None: + if response: break # No middleware results - if response is None: + if not response: # Fetch handler from router handler, args, kwargs = self.router.get(request) - if handler is None: + if not handler: raise ServerError("'None' was returned while requesting a handler from the router") # Run response handler @@ -125,7 +125,7 @@ class Sanic: _response = middleware(request, response) if isawaitable(_response): _response = await _response - if _response is not None: + if _response: response = _response break diff --git a/sanic/server.py b/sanic/server.py index f824d17e..2939b54f 100644 --- a/sanic/server.py +++ b/sanic/server.py @@ -25,7 +25,7 @@ class HttpProtocol(asyncio.Protocol): self.loop = loop self.transport = None self.request = None - self.parser = None + self.parser = False self.url = None self.headers = None self.signal = signal @@ -64,8 +64,7 @@ class HttpProtocol(asyncio.Protocol): return self.bail_out("Request too large ({}), connection closed".format(self._total_request_size)) # Create parser if this is the first time we're receiving data - if self.parser is None: - assert self.request is None + if not self.parser: self.headers = [] self.parser = httptools.HttpRequestParser(self)