Vasanko/sanic
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Add parameter check

Browse Source
This commit is contained in:
howie6879 2018-01-22 14:52:30 +08:00
parent 3844cec7a4
commit f20b854dd2
2 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sanic/app.py
View File

@ -154,7 +154,9 @@ class Sanic:
version=version, name=name) version=version, name=name)
return handler return handler
else: else:
raise ValueError('Required parameter `request` missing in the {0}()'.format(handler.__name__)) raise ValueError(
'Required parameter `request` missing in the {0}()'.format(
handler.__name__))
return response return response

18
tests/test_url_building.py
View File

@ -75,7 +75,7 @@ def test_fails_if_endpoint_not_found():
app = Sanic('fail_url_build') app = Sanic('fail_url_build')
@app.route('/fail') @app.route('/fail')
def fail(): def fail(request):
return text('this should fail') return text('this should fail')
with pytest.raises(URLBuildError) as e: with pytest.raises(URLBuildError) as e:
@ -93,7 +93,7 @@ def test_fails_url_build_if_param_not_passed():
app = Sanic('fail_url_build') app = Sanic('fail_url_build')
@app.route(url) @app.route(url)
def fail(): def fail(request):
return text('this should fail') return text('this should fail')
fail_args = list(string.ascii_letters) fail_args = list(string.ascii_letters)
@ -111,7 +111,7 @@ def test_fails_url_build_if_params_not_passed():
app = Sanic('fail_url_build') app = Sanic('fail_url_build')
@app.route('/fail') @app.route('/fail')
def fail(): def fail(request):
return text('this should fail') return text('this should fail')
with pytest.raises(ValueError) as e: with pytest.raises(ValueError) as e:
@ -134,7 +134,7 @@ def test_fails_with_int_message():
app = Sanic('fail_url_build') app = Sanic('fail_url_build')
@app.route(COMPLEX_PARAM_URL) @app.route(COMPLEX_PARAM_URL)
def fail(): def fail(request):
return text('this should fail') return text('this should fail')
failing_kwargs = dict(PASSING_KWARGS) failing_kwargs = dict(PASSING_KWARGS)
@ -153,7 +153,7 @@ def test_fails_with_two_letter_string_message():
app = Sanic('fail_url_build') app = Sanic('fail_url_build')
@app.route(COMPLEX_PARAM_URL) @app.route(COMPLEX_PARAM_URL)
def fail(): def fail(request):
return text('this should fail') return text('this should fail')
failing_kwargs = dict(PASSING_KWARGS) failing_kwargs = dict(PASSING_KWARGS)
@ -173,7 +173,7 @@ def test_fails_with_number_message():
app = Sanic('fail_url_build') app = Sanic('fail_url_build')
@app.route(COMPLEX_PARAM_URL) @app.route(COMPLEX_PARAM_URL)
def fail(): def fail(request):
return text('this should fail') return text('this should fail')
failing_kwargs = dict(PASSING_KWARGS) failing_kwargs = dict(PASSING_KWARGS)
@ -193,7 +193,7 @@ def test_adds_other_supplied_values_as_query_string():
app = Sanic('passes') app = Sanic('passes')
@app.route(COMPLEX_PARAM_URL) @app.route(COMPLEX_PARAM_URL)
def passes(): def passes(request):
return text('this should pass') return text('this should pass')
new_kwargs = dict(PASSING_KWARGS) new_kwargs = dict(PASSING_KWARGS)
@ -216,7 +216,7 @@ def blueprint_app():
second_print = Blueprint('second', url_prefix='/second') second_print = Blueprint('second', url_prefix='/second')
@first_print.route('/foo') @first_print.route('/foo')
def foo(): def foo(request):
return text('foo from first') return text('foo from first')
@first_print.route('/foo/<param>') @first_print.route('/foo/<param>')
@ -225,7 +225,7 @@ def blueprint_app():
'foo from first : {}'.format(param)) 'foo from first : {}'.format(param))
@second_print.route('/foo') # noqa @second_print.route('/foo') # noqa
def foo(): def foo(request):
return text('foo from second') return text('foo from second')
@second_print.route('/foo/<param>') # noqa @second_print.route('/foo/<param>') # noqa