Compare commits

...

3 Commits

Author SHA1 Message Date
L. Kärkkäinen
8027563144 Remove unused import 2023-09-20 20:11:45 +01:00
L. Kärkkäinen
875e921bda Do not strip entity-headers. 2023-09-20 19:59:35 +01:00
L. Kärkkäinen
11c841ab4e Add test for issue #2823 2023-09-20 19:58:44 +01:00
2 changed files with 8 additions and 4 deletions

View File

@ -24,7 +24,6 @@ from sanic.helpers import (
Default, Default,
_default, _default,
has_message_body, has_message_body,
remove_entity_headers,
) )
from sanic.http import Http from sanic.http import Http
@ -106,9 +105,6 @@ class BaseHTTPResponse:
Returns: Returns:
Iterator[Tuple[bytes, bytes]]: A list of header tuples encoded in bytes for sending Iterator[Tuple[bytes, bytes]]: A list of header tuples encoded in bytes for sending
""" # noqa: E501 """ # noqa: E501
# TODO: Make a blacklist set of header names and then filter with that
if self.status in (304, 412): # Not Modified, Precondition Failed
self.headers = remove_entity_headers(self.headers)
if has_message_body(self.status): if has_message_body(self.status):
self.headers.setdefault("content-type", self.content_type) self.headers.setdefault("content-type", self.content_type)
# Encode headers into bytes # Encode headers into bytes

View File

@ -178,6 +178,10 @@ def json_app(app):
async def unmodified_handler(request: Request): async def unmodified_handler(request: Request):
return json(JSON_DATA, status=304) return json(JSON_DATA, status=304)
@app.get("/precondition")
async def precondition_handler(request: Request):
return json(JSON_DATA, status=412)
@app.delete("/") @app.delete("/")
async def delete_handler(request: Request): async def delete_handler(request: Request):
return json(None, status=204) return json(None, status=204)
@ -193,6 +197,10 @@ def test_json_response(json_app):
assert response.text == json_dumps(JSON_DATA) assert response.text == json_dumps(JSON_DATA)
assert response.json == JSON_DATA assert response.json == JSON_DATA
request, response = json_app.test_client.get("/precondition")
assert response.status == 412
assert response.json == JSON_DATA
def test_no_content(json_app): def test_no_content(json_app):
request, response = json_app.test_client.get("/no-content") request, response = json_app.test_client.get("/no-content")