
* Streaming request by async for. * Make all requests streaming and preload body for non-streaming handlers. * Cleanup of code and avoid mixing streaming responses. * Async http protocol loop. * Change of test: don't require early bad request error but only after CRLF-CRLF. * Add back streaming requests. * Rewritten request body parser. * Misc. cleanup, down to 4 failing tests. * All tests OK. * Entirely remove request body queue. * Let black f*ckup the layout * Better testing error messages on protocol errors. * Remove StreamBuffer tests because the type is about to be removed. * Remove tests using the deprecated get_headers function that can no longer be supported. Chunked mode is now autodetected, so do not put content-length header if chunked mode is preferred. * Major refactoring of HTTP protocol handling (new module http.py added), all requests made streaming. A few compatibility issues and a lot of cleanup to be done remain, 16 tests failing. * Terminate check_timeouts once connection_task finishes. * Code cleanup, 14 tests failing. * Much cleanup, 12 failing... * Even more cleanup and error checking, 8 failing tests. * Remove keep-alive header from responses. First of all, it should say timeout=<value> which wasn't the case with existing implementation, and secondly none of the other web servers I tried include this header. * Everything but CustomServer OK. * Linter * Disable custom protocol test * Remove unnecessary variables, optimise performance. * A test was missing that body_init/body_push/body_finish are never called. Rewritten using receive_body and case switching to make it fail if bypassed. * Minor fixes. * Remove unused code. * Py 3.8 check for deprecated loop argument. * Fix a middleware cancellation handling test with py38. * Linter 'n fixes * Typing * Stricter handling of request header size * More specific error messages on Payload Too Large. * Init http.response = None * Messages further tuned. * Always try to consume request body, plus minor cleanup. * Add a missing check in case of close_if_idle on a dead connection. * Avoid error messages on PayloadTooLarge. * Add test for new API. * json takes str, not bytes * Default to no maximum request size for streaming handlers. * Fix chunked mode crash. * Header values should be strictly ASCII but both UTF-8 and Latin-1 exist. Use UTF-8B to cope with all. * Refactoring and cleanup. * Unify response header processing of ASGI and asyncio modes. * Avoid special handling of StreamingHTTPResponse. * 35 % speedup in HTTP/1.1 response formatting (not so much overall effect). * Duplicate set-cookie headers were being produced. * Cleanup processed_headers some more. * Linting * Import ordering * Response middleware ran by async request.respond(). * Need to check if transport is closing to avoid getting stuck in sending loops after peer has disconnected. * Middleware and error handling refactoring. * Linter * Fix tracking of HTTP stage when writing to transport fails. * Add clarifying comment * Add a check for request body functions and a test for NotImplementedError. * Linter and typing * These must be tuples + hack mypy warnings away. * New streaming test and minor fixes. * Constant receive buffer size. * 256 KiB send and receive buffers. * Revert "256 KiB send and receive buffers." This reverts commit abc1e3edb21a5e6925fa4c856657559608a8d65b. * app.handle_exception already sends the response. * Improved handling of errors during request. * An odd hack to avoid an httpx limitation that causes test failures. * Limit request header size to 8 KiB at most. * Remove unnecessary use of format string. * Cleanup tests * Remove artifact * Fix type checking * Mark test for skipping * Cleanup some edge cases * Add ignore_body flag to safe methods * Add unit tests for timeout logic * Add unit tests for timeout logic * Fix Mock usage in timeout test * Change logging test to only logger in handler * Windows py3.8 logging issue with current testing client * Add test_header_size_exceeded * Resolve merge conflicts * Add request middleware to hard exception handling * Add request middleware to hard exception handling * Request middleware on exception handlers * Linting * Cleanup deprecations Co-authored-by: L. Kärkkäinen <tronic@users.noreply.github.com> Co-authored-by: Adam Hopkins <admhpkns@gmail.com>
246 lines
6.7 KiB
Python
246 lines
6.7 KiB
Python
import pytest as pytest
|
|
|
|
from sanic.blueprints import Blueprint
|
|
from sanic.constants import HTTP_METHODS
|
|
from sanic.exceptions import InvalidUsage
|
|
from sanic.request import Request
|
|
from sanic.response import HTTPResponse, text
|
|
from sanic.views import CompositionView, HTTPMethodView
|
|
|
|
|
|
@pytest.mark.parametrize("method", HTTP_METHODS)
|
|
def test_methods(app, method):
|
|
class DummyView(HTTPMethodView):
|
|
async def get(self, request):
|
|
return text("", headers={"method": "GET"})
|
|
|
|
def post(self, request):
|
|
return text("", headers={"method": "POST"})
|
|
|
|
async def put(self, request):
|
|
return text("", headers={"method": "PUT"})
|
|
|
|
def head(self, request):
|
|
return text("", headers={"method": "HEAD"})
|
|
|
|
def options(self, request):
|
|
return text("", headers={"method": "OPTIONS"})
|
|
|
|
async def patch(self, request):
|
|
return text("", headers={"method": "PATCH"})
|
|
|
|
def delete(self, request):
|
|
return text("", headers={"method": "DELETE"})
|
|
|
|
app.add_route(DummyView.as_view(), "/")
|
|
|
|
request, response = getattr(app.test_client, method.lower())("/")
|
|
assert response.headers["method"] == method
|
|
|
|
|
|
def test_unexisting_methods(app):
|
|
class DummyView(HTTPMethodView):
|
|
def get(self, request):
|
|
return text("I am get method")
|
|
|
|
app.add_route(DummyView.as_view(), "/")
|
|
request, response = app.test_client.get("/")
|
|
assert response.text == "I am get method"
|
|
request, response = app.test_client.post("/")
|
|
assert "Method POST not allowed for URL /" in response.text
|
|
|
|
|
|
def test_argument_methods(app):
|
|
class DummyView(HTTPMethodView):
|
|
def get(self, request, my_param_here):
|
|
return text("I am get method with %s" % my_param_here)
|
|
|
|
app.add_route(DummyView.as_view(), "/<my_param_here>")
|
|
|
|
request, response = app.test_client.get("/test123")
|
|
|
|
assert response.text == "I am get method with test123"
|
|
|
|
|
|
def test_with_bp(app):
|
|
bp = Blueprint("test_text")
|
|
|
|
class DummyView(HTTPMethodView):
|
|
def get(self, request):
|
|
return text("I am get method")
|
|
|
|
bp.add_route(DummyView.as_view(), "/")
|
|
|
|
app.blueprint(bp)
|
|
request, response = app.test_client.get("/")
|
|
|
|
assert response.text == "I am get method"
|
|
|
|
|
|
def test_with_bp_with_url_prefix(app):
|
|
bp = Blueprint("test_text", url_prefix="/test1")
|
|
|
|
class DummyView(HTTPMethodView):
|
|
def get(self, request):
|
|
return text("I am get method")
|
|
|
|
bp.add_route(DummyView.as_view(), "/")
|
|
|
|
app.blueprint(bp)
|
|
request, response = app.test_client.get("/test1/")
|
|
|
|
assert response.text == "I am get method"
|
|
|
|
|
|
def test_with_middleware(app):
|
|
class DummyView(HTTPMethodView):
|
|
def get(self, request):
|
|
return text("I am get method")
|
|
|
|
app.add_route(DummyView.as_view(), "/")
|
|
|
|
results = []
|
|
|
|
@app.middleware
|
|
async def handler(request):
|
|
results.append(request)
|
|
|
|
request, response = app.test_client.get("/")
|
|
|
|
assert response.text == "I am get method"
|
|
assert type(results[0]) is Request
|
|
|
|
|
|
def test_with_middleware_response(app):
|
|
results = []
|
|
|
|
@app.middleware("request")
|
|
async def process_request(request):
|
|
results.append(request)
|
|
|
|
@app.middleware("response")
|
|
async def process_response(request, response):
|
|
results.append(request)
|
|
results.append(response)
|
|
|
|
class DummyView(HTTPMethodView):
|
|
def get(self, request):
|
|
return text("I am get method")
|
|
|
|
app.add_route(DummyView.as_view(), "/")
|
|
|
|
request, response = app.test_client.get("/")
|
|
|
|
assert response.text == "I am get method"
|
|
assert type(results[0]) is Request
|
|
assert type(results[1]) is Request
|
|
assert isinstance(results[2], HTTPResponse)
|
|
|
|
|
|
def test_with_custom_class_methods(app):
|
|
class DummyView(HTTPMethodView):
|
|
global_var = 0
|
|
|
|
def _iternal_method(self):
|
|
self.global_var += 10
|
|
|
|
def get(self, request):
|
|
self._iternal_method()
|
|
return text(
|
|
f"I am get method and global var " f"is {self.global_var}"
|
|
)
|
|
|
|
app.add_route(DummyView.as_view(), "/")
|
|
request, response = app.test_client.get("/")
|
|
assert response.text == "I am get method and global var is 10"
|
|
|
|
|
|
def test_with_decorator(app):
|
|
results = []
|
|
|
|
def stupid_decorator(view):
|
|
def decorator(*args, **kwargs):
|
|
results.append(1)
|
|
return view(*args, **kwargs)
|
|
|
|
return decorator
|
|
|
|
class DummyView(HTTPMethodView):
|
|
decorators = [stupid_decorator]
|
|
|
|
def get(self, request):
|
|
return text("I am get method")
|
|
|
|
app.add_route(DummyView.as_view(), "/")
|
|
request, response = app.test_client.get("/")
|
|
assert response.text == "I am get method"
|
|
assert results[0] == 1
|
|
|
|
|
|
def test_composition_view_rejects_incorrect_methods():
|
|
def foo(request):
|
|
return text("Foo")
|
|
|
|
view = CompositionView()
|
|
|
|
with pytest.raises(InvalidUsage) as e:
|
|
view.add(["GET", "FOO"], foo)
|
|
|
|
assert str(e.value) == "FOO is not a valid HTTP method."
|
|
|
|
|
|
def test_composition_view_rejects_duplicate_methods():
|
|
def foo(request):
|
|
return text("Foo")
|
|
|
|
view = CompositionView()
|
|
|
|
with pytest.raises(InvalidUsage) as e:
|
|
view.add(["GET", "POST", "GET"], foo)
|
|
|
|
assert str(e.value) == "Method GET is already registered."
|
|
|
|
|
|
@pytest.mark.parametrize("method", HTTP_METHODS)
|
|
def test_composition_view_runs_methods_as_expected(app, method):
|
|
view = CompositionView()
|
|
|
|
def first(request):
|
|
return text("first method")
|
|
|
|
view.add(["GET", "POST", "PUT"], first)
|
|
view.add(["DELETE", "PATCH"], lambda x: text("second method"))
|
|
|
|
app.add_route(view, "/")
|
|
|
|
if method in ["GET", "POST", "PUT"]:
|
|
request, response = getattr(app.test_client, method.lower())("/")
|
|
assert response.text == "first method"
|
|
|
|
response = view(request)
|
|
assert response.body.decode() == "first method"
|
|
|
|
if method in ["DELETE", "PATCH"]:
|
|
request, response = getattr(app.test_client, method.lower())("/")
|
|
assert response.text == "second method"
|
|
|
|
response = view(request)
|
|
assert response.body.decode() == "second method"
|
|
|
|
|
|
@pytest.mark.parametrize("method", HTTP_METHODS)
|
|
def test_composition_view_rejects_invalid_methods(app, method):
|
|
view = CompositionView()
|
|
view.add(["GET", "POST", "PUT"], lambda x: text("first method"))
|
|
|
|
app.add_route(view, "/")
|
|
|
|
if method in ["GET", "POST", "PUT"]:
|
|
request, response = getattr(app.test_client, method.lower())("/")
|
|
assert response.status == 200
|
|
assert response.text == "first method"
|
|
|
|
if method in ["DELETE", "PATCH"]:
|
|
request, response = getattr(app.test_client, method.lower())("/")
|
|
assert response.status == 405
|