Merge pull request #327 from awiddersheim/logging-override

Make it easier to override logging

sanic/log.py

@@ -1,3 +1,3 @@
 import logging
 
-log = logging.getLogger(__name__)
+log = logging.getLogger('sanic')

sanic/sanic.py

@@ -22,6 +22,15 @@ from os import set_inheritable
 class Sanic:
     def __init__(self, name=None, router=None,
                  error_handler=None):
+        # Only set up a default log handler if the
+        # end-user application didn't set anything up.
+        if not logging.root.handlers and log.level == logging.NOTSET:
+            formatter = logging.Formatter(
+                "%(asctime)s: %(levelname)s: %(message)s")
+            handler = logging.StreamHandler()
+            handler.setFormatter(formatter)
+            log.addHandler(handler)
+            log.setLevel(logging.INFO)
         if name is None:
             frame_records = stack()[1]
             name = getmodulename(frame_records[1])
@@ -292,10 +301,6 @@ class Sanic:
         :param protocol: Subclass of asyncio protocol class
         :return: Nothing
         """
-        logging.basicConfig(
-            level=logging.INFO,
-            format="%(asctime)s: %(levelname)s: %(message)s"
-        )
         self.error_handler.debug = True
         self.debug = debug
         self.loop = loop
@@ -383,12 +388,6 @@ class Sanic:
         :param stop_event: if provided, is used as a stop signal
         :return:
         """
-        # In case this is called directly, we configure logging here too.
-        # This won't interfere with the same call from run()
-        logging.basicConfig(
-            level=logging.INFO,
-            format="%(asctime)s: %(levelname)s: %(message)s"
-        )
         server_settings['reuse_port'] = True
 
         # Create a stop event to be triggered by a signal