Merge pull request #1848 from ashleysommer/fix_named_response_middleware

Reverse named_response_middlware execution order, to match normal response middleware execution order.

.appveyor.yml

@@ -12,6 +12,11 @@ environment:
       PYTHON_VERSION: "3.7.x"
       PYTHON_ARCH: "64"
 
+    - TOXENV: py38-no-ext
+      PYTHON: "C:\\Python38-x64"
+      PYTHON_VERSION: "3.8.x"
+      PYTHON_ARCH: "64"
+
 init: SET "PATH=%PYTHON%;%PYTHON%\\Scripts;%PATH%"
 
 install:

.travis.yml

@@ -21,23 +21,46 @@ matrix:
       dist: xenial
       sudo: true
       name: "Python 3.7 without Extensions"
+    - env: TOX_ENV=py38
+      python: 3.8
+      dist: xenial
+      sudo: true
+      name: "Python 3.8 with Extensions"
+    - env: TOX_ENV=py38-no-ext
+      python: 3.8
+      dist: xenial
+      sudo: true
+      name: "Python 3.8 without Extensions"
     - env: TOX_ENV=type-checking
       python: 3.6
       name: "Python 3.6 Type checks"
     - env: TOX_ENV=type-checking
       python: 3.7
       name: "Python 3.7 Type checks"
+    - env: TOX_ENV=type-checking
+      python: 3.8
+      name: "Python 3.8 Type checks"
     - env: TOX_ENV=lint
       python: 3.6
       name: "Python 3.6 Linter checks"
     - env: TOX_ENV=check
       python: 3.6
       name: "Python 3.6 Package checks"
+    - env: TOX_ENV=security
+      python: 3.6
+      dist: xenial
+      sudo: true
+      name: "Python 3.6 Bandit security scan"
     - env: TOX_ENV=security
       python: 3.7
       dist: xenial
       sudo: true
       name: "Python 3.7 Bandit security scan"
+    - env: TOX_ENV=security
+      python: 3.8
+      dist: xenial
+      sudo: true
+      name: "Python 3.8 Bandit security scan"
     - env: TOX_ENV=docs
       python: 3.7
       dist: xenial

CHANGELOG.rst

@@ -24,7 +24,7 @@ Bugfixes
 Improved Documentation
 **********************
 
-- Move docs from RST to MD
+- Move docs from MD to RST
 
   Moved all docs from markdown to restructured text like the rest of the docs to unify the scheme and make it easier in
   the future to update documentation. (`#1691 <https://github.com/huge-success/sanic/issues/1691>`__)

README.rst

@@ -83,6 +83,9 @@ Installation
   If you are running on a clean install of Fedora 28 or above, please make sure you have the ``redhat-rpm-config`` package installed in case if you want to
   use ``sanic`` with ``ujson`` dependency.
 
+.. note::
+
+  Windows support is currently "experimental" and on a best-effort basis. Multiple workers are also not currently supported on Windows (see `Issue #1517 <https://github.com/huge-success/sanic/issues/1517>`_), but setting ``workers=1`` should launch the server successfully.
 
 Hello World Example
 -------------------

docs/index.rst

@@ -28,6 +28,7 @@ Guides
    sanic/debug_mode
    sanic/testing
    sanic/deploying
+   sanic/nginx
    sanic/extensions
    sanic/examples
    sanic/changelog

docs/sanic/class_based_views.rst

@@ -28,14 +28,15 @@ using all these methods would look like the following.
     from sanic.views import HTTPMethodView
     from sanic.response import text
 
-    app = Sanic('some_name')
+    app = Sanic("class_views_example")
 
     class SimpleView(HTTPMethodView):
 
       def get(self, request):
           return text('I am get method')
 
-      def post(self, request):
+      # You can also use async syntax
+      async def post(self, request):
           return text('I am post method')
 
       def put(self, request):
@@ -49,22 +50,6 @@ using all these methods would look like the following.
 
     app.add_route(SimpleView.as_view(), '/')
 
-You can also use `async` syntax.
-
-.. code-block:: python
-
-    from sanic import Sanic
-    from sanic.views import HTTPMethodView
-    from sanic.response import text
-
-    app = Sanic('some_name')
-
-    class SimpleAsyncView(HTTPMethodView):
-
-      async def get(self, request):
-          return text('I am async get method')
-
-    app.add_route(SimpleAsyncView.as_view(), '/')
 
 URL parameters
 --------------
@@ -154,7 +139,7 @@ lambda:
     from sanic.views import CompositionView
     from sanic.response import text
 
-    app = Sanic(__name__)
+    app = Sanic("composition_example")
 
     def get_handler(request):
         return text('I am a get method')

docs/sanic/config.rst

@@ -39,13 +39,13 @@ Any variables defined with the `SANIC_` prefix will be applied to the sanic conf
 
 .. code-block:: python
 
-    app = Sanic(load_env='MYAPP_')
+    app = Sanic(__name__, load_env='MYAPP_')
 
 Then the above variable would be `MYAPP_REQUEST_TIMEOUT`. If you want to disable loading from environment variables you can set it to `False` instead:
 
 .. code-block:: python
 
-    app = Sanic(load_env=False)
+    app = Sanic(__name__, load_env=False)
 
 From an Object
 ~~~~~~~~~~~~~~
@@ -115,15 +115,25 @@ Out of the box there are just a few predefined values which can be overwritten w
 +---------------------------+-------------------+-----------------------------------------------------------------------------+
 | KEEP_ALIVE_TIMEOUT        | 5                 | How long to hold a TCP connection open (sec)                                |
 +---------------------------+-------------------+-----------------------------------------------------------------------------+
+| WEBSOCKET_MAX_SIZE        | 2^20              | Maximum size for incoming messages (bytes)                                  |
++---------------------------+-------------------+-----------------------------------------------------------------------------+
+| WEBSOCKET_MAX_QUEUE       | 32                | Maximum length of the queue that holds incoming messages                    |
++---------------------------+-------------------+-----------------------------------------------------------------------------+
+| WEBSOCKET_READ_LIMIT      | 2^16              | High-water limit of the buffer for incoming bytes                           |
++---------------------------+-------------------+-----------------------------------------------------------------------------+
+| WEBSOCKET_WRITE_LIMIT     | 2^16              | High-water limit of the buffer for outgoing bytes                           |
++---------------------------+-------------------+-----------------------------------------------------------------------------+
 | GRACEFUL_SHUTDOWN_TIMEOUT | 15.0              | How long to wait to force close non-idle connection (sec)                   |
 +---------------------------+-------------------+-----------------------------------------------------------------------------+
 | ACCESS_LOG                | True              | Disable or enable access log                                                |
 +---------------------------+-------------------+-----------------------------------------------------------------------------+
-| PROXIES_COUNT             | -1                | The number of proxy servers in front of the app (e.g. nginx; see below)     |
+| FORWARDED_SECRET          | None              | Used to securely identify a specific proxy server (see below)               |
++---------------------------+-------------------+-----------------------------------------------------------------------------+
+| PROXIES_COUNT             | None              | The number of proxy servers in front of the app (e.g. nginx; see below)     |
 +---------------------------+-------------------+-----------------------------------------------------------------------------+
 | FORWARDED_FOR_HEADER      | "X-Forwarded-For" | The name of "X-Forwarded-For" HTTP header that contains client and proxy ip |
 +---------------------------+-------------------+-----------------------------------------------------------------------------+
-| REAL_IP_HEADER            | "X-Real-IP"       | The name of "X-Real-IP" HTTP header that contains real client ip            |
+| REAL_IP_HEADER            |  None             | The name of "X-Real-IP" HTTP header that contains real client ip            |
 +---------------------------+-------------------+-----------------------------------------------------------------------------+
 
 The different Timeout variables:
@@ -228,9 +238,7 @@ Proxy config if using ...
 * a proxy that supports `forwarded`: set `FORWARDED_SECRET` to the value that the proxy inserts in the header
     * Apache Traffic Server: `CONFIG proxy.config.http.insert_forwarded STRING for|proto|host|by=_secret`
     * NGHTTPX: `nghttpx --add-forwarded=for,proto,host,by --forwarded-for=ip --forwarded-by=_secret`
-    * NGINX: after `the official instructions <https://www.nginx.com/resources/wiki/start/topics/examples/forwarded/>`_, add anywhere in your config:
+    * NGINX: :ref:`nginx`.
-
-..        proxy_set_header Forwarded "$proxy_add_forwarded;by=\"_$server_name\";proto=$scheme;host=\"$http_host\";path=\"$request_uri\";secret=_secret";
 
 * a custom header with client IP: set `REAL_IP_HEADER` to the name of that header
 * `x-forwarded-for`: set `PROXIES_COUNT` to `1` for a single proxy, or a greater number to allow Sanic to select the correct IP

docs/sanic/debug_mode.rst

@@ -21,7 +21,7 @@ and the Automatic Reloader will be activated.
     from sanic import Sanic
     from sanic.response import json
 
-    app = Sanic()
+    app = Sanic(__name__)
 
     @app.route('/')
     async def hello_world(request):
@@ -43,7 +43,7 @@ the ``auto_reload`` argument will activate or deactivate the Automatic Reloader.
     from sanic import Sanic
     from sanic.response import json
 
-    app = Sanic()
+    app = Sanic(__name__)
 
     @app.route('/')
     async def hello_world(request):

docs/sanic/deploying.rst

@@ -1,9 +1,12 @@
 Deploying
 =========
 
-Deploying Sanic is very simple using one of three options: the inbuilt webserver,
+Sanic has three serving options: the inbuilt webserver,
 an `ASGI webserver <https://asgi.readthedocs.io/en/latest/implementations.html>`_, or `gunicorn`.
-It is also very common to place Sanic behind a reverse proxy, like `nginx`.
+
+Sanic's own webserver is the fastest option, and it can be securely run on
+the Internet. Still, it is also very common to place Sanic behind a reverse
+proxy, as shown in :ref:`nginx`.
 
 Running via Sanic webserver
 ---------------------------
@@ -85,7 +88,11 @@ before shutdown, and after shutdown. Therefore, in ASGI mode, the startup and sh
 run consecutively and not actually around the server process beginning and ending (since that
 is now controlled by the ASGI server). Therefore, it is best to use `after_server_start` and
 `before_server_stop`.
-3. ASGI mode is still in "beta" as of Sanic v19.6.
+
+Sanic has experimental support for running on `Trio <https://trio.readthedocs.io/en/stable/>`_ with::
+
+    hypercorn -k trio myapp:app
+
 
 Running via Gunicorn
 --------------------
@@ -110,28 +117,6 @@ See the `Gunicorn Docs <http://docs.gunicorn.org/en/latest/settings.html#max-req
 Other deployment considerations
 -------------------------------
 
-Running behind a reverse proxy
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-Sanic can be used with a reverse proxy (e.g. nginx). There's a simple example of nginx configuration:
-
-
-::
-
-    server {
-      listen 80;
-      server_name example.org;
-      location / {
-        proxy_pass http://127.0.0.1:8000;
-        proxy_set_header Host $host;
-        proxy_set_header X-Real-IP $remote_addr;
-        proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
-      }
-    }
-
-
-If you want to get real client ip, you should configure `X-Real-IP` and `X-Forwarded-For` HTTP headers and set `app.config.PROXIES_COUNT` to `1`; see the configuration page for more information.
-
 Disable debug logging for performance
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 

docs/sanic/examples.rst

@@ -25,7 +25,7 @@ A simple sanic application with a single ``async`` method with ``text`` and ``js
 Simple App with ``Sanic Views``
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-Showcasing the simple mechanism of using :class:`sanic.viewes.HTTPMethodView` as well as a way to extend the same
+Showcasing the simple mechanism of using :class:`sanic.views.HTTPMethodView` as well as a way to extend the same
 into providing a custom ``async`` behavior for ``view``.
 
 .. literalinclude:: ../../examples/simple_async_view.py

docs/sanic/exceptions.rst

@@ -59,7 +59,7 @@ You can also add an exception handler as such:
     async def server_error_handler(request, exception):
         return text("Oops, server error", status=500)
 
-    app = Sanic()
+    app = Sanic("error_handler_example")
     app.error_handler.add(Exception, server_error_handler)
 
 In some cases, you might want to add some more error handling
@@ -77,7 +77,7 @@ can subclass Sanic's default error handler as such:
             # You custom error handling logic...
             return super().default(request, exception)
 
-    app = Sanic()
+    app = Sanic("custom_error_handler_example")
     app.error_handler = CustomErrorHandler()
 
 Useful exceptions

docs/sanic/getting_started.rst

@@ -8,19 +8,19 @@ syntax, so earlier versions of python won't work.
 1. Install Sanic
 ----------------
 
->   If you are running on a clean install of Fedora 28 or above, please make sure you have the ``redhat-rpm-config`` package installed in case if you want to use ``sanic`` with ``ujson`` dependency.
+If you are running on a clean install of Fedora 28 or above, please make sure you have the ``redhat-rpm-config`` package installed in case if you want to use ``sanic`` with ``ujson`` dependency.
 
 .. code-block:: bash
 
     pip3 install sanic
 
 To install sanic without `uvloop` or `ujson` using bash, you can provide either or both of these environmental variables
-using any truthy string like `'y', 'yes', 't', 'true', 'on', '1'` and setting the `SANIC_NO_X` (`X` = `UVLOOP`/`UJSON`)
+using any truthy string like `'y', 'yes', 't', 'true', 'on', '1'` and setting the `SANIC_NO_X` ( with`X` = `UVLOOP`/`UJSON`)
 to true will stop that features installation.
 
 .. code-block:: bash
 
-    SANIC_NO_UVLOOP=true SANIC_NO_UJSON=true pip3 install sanic
+    SANIC_NO_UVLOOP=true SANIC_NO_UJSON=true pip3 install --no-binary :all: sanic
 
 You can also install Sanic from `conda-forge <https://anaconda.org/conda-forge/sanic>`_
 
@@ -37,7 +37,7 @@ You can also install Sanic from `conda-forge <https://anaconda.org/conda-forge/s
     from sanic import Sanic
     from sanic.response import json
 
-    app = Sanic()
+    app = Sanic("hello_example")
 
     @app.route("/")
     async def test(request):

docs/sanic/index.rst

@@ -15,7 +15,7 @@ Sanic aspires to be simple
     from sanic import Sanic
     from sanic.response import json
 
-    app = Sanic()
+    app = Sanic("App Name")
 
     @app.route("/")
     async def test(request):

docs/sanic/logging.rst

@@ -17,7 +17,7 @@ A simple example using default settings would be like this:
    from sanic.log import logger
    from sanic.response import text
 
-   app = Sanic('test')
+   app = Sanic('logging_example')
 
    @app.route('/')
    async def test(request):
@@ -47,7 +47,7 @@ initialize ``Sanic`` app:
 
 .. code:: python
 
-   app = Sanic('test', log_config=LOGGING_CONFIG)
+   app = Sanic('logging_example', log_config=LOGGING_CONFIG)
 
 And to close logging, simply assign access_log=False:
 

docs/sanic/middleware.rst

@@ -132,13 +132,24 @@ For example:
     async def close_db(app, loop):
         await app.db.close()
 
+Note:
+
+The listeners are deconstructed in the reverse order of being constructed.
+
+For example:
+
+If the first listener in before_server_start handler setups a database connection,
+ones registered after it can rely on that connection being alive both when they are started
+and stopped, because stopping is done in reverse order, and the database connection is
+torn down last.
+
 It's also possible to register a listener using the `register_listener` method.
 This may be useful if you define your listeners in another module besides
 the one you instantiate your app in.
 
 .. code-block:: python
 
-    app = Sanic()
+    app = Sanic(__name__)
 
     async def setup_db(app, loop):
         app.db = await db_setup()

docs/sanic/nginx.rst

@@ -0,0 +1,222 @@
+
+.. _nginx:
+
+Nginx Deployment
+================
+
+Introduction
+~~~~~~~~~~~~
+
+Although Sanic can be run directly on Internet, it may be useful to use a proxy
+server such as Nginx in front of it. This is particularly useful for running
+multiple virtual hosts on the same IP, serving NodeJS or other services beside
+a single Sanic app, and it also allows for efficient serving of static files.
+SSL and HTTP/2 are also easily implemented on such proxy.
+
+We are setting the Sanic app to serve only locally at `127.0.0.1:8000`, while the
+Nginx installation is responsible for providing the service to public Internet
+on domain `example.com`. Static files will be served from `/var/www/`.
+
+
+Proxied Sanic app
+~~~~~~~~~~~~~~~~~
+
+The app needs to be setup with a secret key used to identify a trusted proxy,
+so that real client IP and other information can be identified. This protects
+against anyone on the Internet sending fake headers to spoof their IP addresses
+and other details. Choose any random string and configure it both on the app
+and in Nginx config.
+
+.. code-block:: python
+
+    from sanic import Sanic
+    from sanic.response import text
+
+    app = Sanic("proxied_example")
+    app.config.FORWARDED_SECRET = "YOUR SECRET"
+
+    @app.get("/")
+    def index(request):
+        # This should display external (public) addresses:
+        return text(
+            f"{request.remote_addr} connected to {request.url_for('index')}\n"
+            f"Forwarded: {request.forwarded}\n"
+        )
+
+    if __name__ == '__main__':
+        app.run(host='127.0.0.1', port=8000, workers=8, access_log=False)
+
+Since this is going to be a system service, save your code to
+`/srv/sanicexample/sanicexample.py`.
+
+For testing, run your app in a terminal.
+
+
+Nginx configuration
+~~~~~~~~~~~~~~~~~~~
+
+Quite much configuration is required to allow fast transparent proxying, but
+for the most part these don't need to be modified, so bear with me.
+
+Upstream servers need to be configured in a separate `upstream` block to enable
+HTTP keep-alive, which can drastically improve performance, so we use this
+instead of directly providing an upstream address in `proxy_pass` directive. In
+this example, the upstream section is named by `server_name`, i.e. the public
+domain name, which then also gets passed to Sanic in the `Host` header. You may
+change the naming as you see fit. Multiple servers may also be provided for
+load balancing and failover.
+
+Change the two occurrences of `example.com` to your true domain name, and
+instead of `YOUR SECRET` use the secret you chose for your app.
+
+::
+
+    upstream example.com {
+      keepalive 100;
+      server 127.0.0.1:8000;
+      #server unix:/tmp/sanic.sock;
+    }
+
+    server {
+      server_name example.com;
+      listen 443 ssl http2 default_server;
+      listen [::]:443 ssl http2 default_server;
+      # Serve static files if found, otherwise proxy to Sanic
+      location / {
+        root /var/www;
+        try_files $uri @sanic;
+      }
+      location @sanic {
+        proxy_pass http://$server_name;
+        # Allow fast streaming HTTP/1.1 pipes (keep-alive, unbuffered)
+        proxy_http_version 1.1;
+        proxy_request_buffering off;
+        proxy_buffering off;
+        # Proxy forwarding (password configured in app.config.FORWARDED_SECRET)
+        proxy_set_header forwarded "$proxy_forwarded;secret=\"YOUR SECRET\"";
+        # Allow websockets
+        proxy_set_header connection "upgrade";
+        proxy_set_header upgrade $http_upgrade;
+      }
+    }
+
+To avoid cookie visibility issues and inconsistent addresses on search engines,
+it is a good idea to redirect all visitors to one true domain, always using
+HTTPS:
+
+::
+
+    # Redirect all HTTP to HTTPS with no-WWW
+    server {
+      listen 80 default_server;
+      listen [::]:80 default_server;
+      server_name ~^(?:www\.)?(.*)$;
+      return 301 https://$1$request_uri;
+    }
+
+    # Redirect WWW to no-WWW
+    server {
+      listen 443 ssl http2;
+      listen [::]:443 ssl http2;
+      server_name ~^www\.(.*)$;
+      return 301 $scheme://$1$request_uri;
+    }
+
+The above config sections may be placed in `/etc/nginx/sites-available/default`
+or in other site configs (be sure to symlink them to `sites-enabled` if you
+create new ones).
+
+Make sure that your SSL certificates are configured in the main config, or
+add the `ssl_certificate` and `ssl_certificate_key` directives to each
+`server` section that listens on SSL.
+
+Additionally, copy&paste all of this into `nginx/conf.d/forwarded.conf`:
+
+::
+
+    # RFC 7239 Forwarded header for Nginx proxy_pass
+
+    # Add within your server or location block:
+    #    proxy_set_header forwarded "$proxy_forwarded;secret=\"YOUR SECRET\"";
+
+    # Configure your upstream web server to identify this proxy by that password
+    # because otherwise anyone on the Internet could spoof these headers and fake
+    # their real IP address and other information to your service.
+
+
+    # Provide the full proxy chain in $proxy_forwarded
+    map $proxy_add_forwarded $proxy_forwarded {
+      default "$proxy_add_forwarded;by=\"_$hostname\";proto=$scheme;host=\"$http_host\";path=\"$request_uri\"";
+    }
+
+    # The following mappings are based on
+    # https://www.nginx.com/resources/wiki/start/topics/examples/forwarded/
+
+    map $remote_addr $proxy_forwarded_elem {
+      # IPv4 addresses can be sent as-is
+      ~^[0-9.]+$          "for=$remote_addr";
+
+      # IPv6 addresses need to be bracketed and quoted
+      ~^[0-9A-Fa-f:.]+$   "for=\"[$remote_addr]\"";
+
+      # Unix domain socket names cannot be represented in RFC 7239 syntax
+      default             "for=unknown";
+    }
+
+    map $http_forwarded $proxy_add_forwarded {
+      # If the incoming Forwarded header is syntactically valid, append to it
+      "~^(,[ \\t]*)*([!#$%&'*+.^_`|~0-9A-Za-z-]+=([!#$%&'*+.^_`|~0-9A-Za-z-]+|\"([\\t \\x21\\x23-\\x5B\\x5D-\\x7E\\x80-\\xFF]|\\\\[\\t \\x21-\\x7E\\x80-\\xFF])*\"))?(;([!#$%&'*+.^_`|~0-9A-Za-z-]+=([!#$%&'*+.^_`|~0-9A-Za-z-]+|\"([\\t \\x21\\x23-\\x5B\\x5D-\\x7E\\x80-\\xFF]|\\\\[\\t \\x21-\\x7E\\x80-\\xFF])*\"))?)*([ \\t]*,([ \\t]*([!#$%&'*+.^_`|~0-9A-Za-z-]+=([!#$%&'*+.^_`|~0-9A-Za-z-]+|\"([\\t \\x21\\x23-\\x5B\\x5D-\\x7E\\x80-\\xFF]|\\\\[\\t \\x21-\\x7E\\x80-\\xFF])*\"))?(;([!#$%&'*+.^_`|~0-9A-Za-z-]+=([!#$%&'*+.^_`|~0-9A-Za-z-]+|\"([\\t \\x21\\x23-\\x5B\\x5D-\\x7E\\x80-\\xFF]|\\\\[\\t \\x21-\\x7E\\x80-\\xFF])*\"))?)*)?)*$" "$http_forwarded, $proxy_forwarded_elem";
+
+      # Otherwise, replace it
+      default "$proxy_forwarded_elem";
+    }
+
+For installs that don't use `conf.d` and `sites-available`, all of the above
+configs may also be placed inside the `http` section of the main `nginx.conf`.
+
+Reload Nginx config after changes:
+
+::
+
+    sudo nginx -s reload
+
+Now you should be able to connect your app on `https://example.com/`. Any 404
+errors and such will be handled by Sanic's error pages, and whenever a static
+file is present at a given path, it will be served by Nginx.
+
+
+SSL certificates
+~~~~~~~~~~~~~~~~
+
+If you haven't already configured valid certificates on your server, now is a
+good time to do so. Install `certbot` and `python3-certbot-nginx`, then run
+
+::
+
+    certbot --nginx -d example.com -d www.example.com
+
+`<https://www.nginx.com/blog/using-free-ssltls-certificates-from-lets-encrypt-with-nginx/>`_
+
+Running as a service
+~~~~~~~~~~~~~~~~~~~~
+
+This part is for Linux distributions based on `systemd`. Create a unit file
+`/etc/systemd/system/sanicexample.service`::
+
+    [Unit]
+    Description=Sanic Example
+
+    [Service]
+    User=nobody
+    WorkingDirectory=/srv/sanicexample
+    ExecStart=/usr/bin/env python3 sanicexample.py
+    Restart=always
+
+    [Install]
+    WantedBy=multi-user.target
+
+Then reload service files, start your service and enable it on boot::
+
+    sudo systemctl daemon-reload
+    sudo systemctl start sanicexample
+    sudo systemctl enable sanicexample

docs/sanic/request_data.rst

@@ -56,7 +56,6 @@ The difference between Request.args and Request.query_args for the queryset `?ke
           "url": request.url,
           "query_string": request.query_string,
           "args": request.args,
-          "raw_args": request.raw_args,
           "query_args": request.query_args,
       })
 
@@ -72,12 +71,9 @@ The difference between Request.args and Request.query_args for the queryset `?ke
         "url":"http:\/\/0.0.0.0:8000\/test_request_args?key1=value1&key2=value2&key1=value3",
         "query_string":"key1=value1&key2=value2&key1=value3",
         "args":{"key1":["value1","value3"],"key2":["value2"]},
-        "raw_args":{"key1":"value1","key2":"value2"},
         "query_args":[["key1","value1"],["key2","value2"],["key1","value3"]]
     }
 
-- `raw_args` contains only the first entry of `key1`. Will be deprecated in the future versions.
-
 - `files` (dictionary of `File` objects) - List of files that have a name, body, and type
 
 .. code-block:: python
@@ -228,7 +224,7 @@ The key difference when using this object is the distinction between the `get` a
     from sanic import Sanic
     from sanic.response import json
 
-    app = Sanic(name="example")
+    app = Sanic(__name__)
 
     @app.route("/")
     def get_handler(request):
@@ -247,7 +243,7 @@ route will return "hello".
     from sanic.response import text
     from sanic import Sanic
 
-    app = Sanic()
+    app = Sanic(__name__)
 
     @app.get("/")
     def hello(request):

docs/sanic/response.rst

@@ -107,6 +107,19 @@ Response without encoding the body
     def handle_request(request):
         return response.raw(b'raw data')
 
+Empty
+--------------
+
+For responding with an empty message as defined by `RFC 2616 <https://tools.ietf.org/search/rfc2616#section-7.2.1>`_
+
+.. code-block:: python
+
+    from sanic import response
+
+    @app.route('/empty')
+    async def handle_request(request):
+        return response.empty()
+
 Modify headers or status
 ------------------------
 

docs/sanic/routing.rst

@@ -406,7 +406,7 @@ Build URL for static files
 ==========================
 
 Sanic supports using `url_for` method to build static file urls. In case if the static url
-is pointing to a directory, `filename` parameter to the `url_for` can be ignored.   q
+is pointing to a directory, `filename` parameter to the `url_for` can be ignored.
 
 .. code-block:: python
 

docs/sanic/sockets.rst

@@ -16,7 +16,7 @@ IPv6 example:
     sock = socket.socket(socket.AF_INET6, socket.SOCK_STREAM)
     sock.bind(('::', 7777))
 
-    app = Sanic()
+    app = Sanic("ipv6_example")
 
 
     @app.route("/")
@@ -46,7 +46,7 @@ UNIX socket example:
     sock = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
     sock.bind(server_socket)
 
-    app = Sanic()
+    app = Sanic("unix_socket_example")
 
 
     @app.route("/")

docs/sanic/streaming.rst

@@ -16,7 +16,7 @@ Sanic allows you to get request data by stream, as below. When the request ends,
     from sanic.response import stream, text
 
     bp = Blueprint('blueprint_request_stream')
-    app = Sanic('request_stream')
+    app = Sanic(__name__)
 
 
     class SimpleView(HTTPMethodView):

docs/sanic/websocket.rst

@@ -12,7 +12,7 @@ To setup a WebSocket:
     from sanic.response import json
     from sanic.websocket import WebSocketProtocol
 
-    app = Sanic()
+    app = Sanic("websocket_example")
 
     @app.websocket('/feed')
     async def feed(request, ws):

environment.yml

@@ -1,19 +0,0 @@
-name: py36
-dependencies:
-- pip=18.1=py36_0
-- python=3.6=0
-- setuptools=40.4.3=py36_0
-- pip:
-  - httptools>=0.0.10
-  - uvloop>=0.5.3
-  - ujson>=1.35
-  - aiofiles>=0.3.0
-  - websockets>=6.0,<7.0
-  - multidict>=4.0,<5.0
-  - sphinx==1.8.3
-  - sphinx_rtd_theme==0.4.2
-  - recommonmark==0.5.0
-  - httpx==0.9.3
-  - sphinxcontrib-asyncio>=0.2.0
-  - docutils==0.14
-  - pygments==2.3.1

examples/blueprint_middlware_execution_order.py

@@ -0,0 +1,43 @@
+from sanic import Sanic, Blueprint
+from sanic.response import text
+'''
+Demonstrates that blueprint request middleware are executed in the order they 
+are added. And blueprint response middleware are executed in _reverse_ order.
+On a valid request, it should print "1 2 3 6 5 4" to terminal
+'''
+
+app = Sanic(__name__)
+
+bp = Blueprint("bp_"+__name__)
+
+@bp.middleware('request')
+def request_middleware_1(request):
+    print('1')
+
+@bp.middleware('request')
+def request_middleware_2(request):
+    print('2')
+
+@bp.middleware('request')
+def request_middleware_3(request):
+    print('3')
+
+@bp.middleware('response')
+def resp_middleware_4(request, response):
+    print('4')
+
+@bp.middleware('response')
+def resp_middleware_5(request, response):
+    print('5')
+
+@bp.middleware('response')
+def resp_middleware_6(request, response):
+    print('6')
+
+@bp.route('/')
+def pop_handler(request):
+    return text('hello world')
+
+app.blueprint(bp, url_prefix='/bp')
+
+app.run(host="0.0.0.0", port=8000, debug=True, auto_reload=False)

readthedocs.yml

@@ -1,2 +1,9 @@
-conda:
+version: 2
-    file: environment.yml
+python:
+   version: 3.8
+   install:
+      - method: pip
+        path: .
+        extra_requirements:
+            - docs
+   system_packages: true

sanic/__main__.py

@@ -28,12 +28,12 @@ if __name__ == "__main__":
 
         module = import_module(module_name)
         app = getattr(module, app_name, None)
+        app_name = type(app).__name__
+
         if not isinstance(app, Sanic):
             raise ValueError(
-                "Module is not a Sanic app, it is a {}.  "
+                f"Module is not a Sanic app, it is a {app_name}.  "
-                "Perhaps you meant {}.app?".format(
+                f"Perhaps you meant {args.module}.app?"
-                    type(app).__name__, args.module
-                )
             )
         if args.cert is not None or args.key is not None:
             ssl = {
@@ -52,9 +52,9 @@ if __name__ == "__main__":
         )
     except ImportError as e:
         logger.error(
-            "No module named {} found.\n"
+            f"No module named {e.name} found.\n"
-            "  Example File: project/sanic_server.py -> app\n"
+            f"  Example File: project/sanic_server.py -> app\n"
-            "  Example Module: project.sanic_server.app".format(e.name)
+            f"  Example Module: project.sanic_server.app"
         )
     except ValueError:
         logger.exception("Failed to run app")

sanic/__version__.py

@@ -1 +1 @@
-__version__ = "19.12.0"
+__version__ = "20.3.0"

sanic/app.py

@@ -81,6 +81,7 @@ class Sanic:
         self.sock = None
         self.strict_slashes = strict_slashes
         self.listeners = defaultdict(list)
+        self.is_stopping = False
         self.is_running = False
         self.is_request_stream = False
         self.websocket_enabled = False
@@ -194,18 +195,27 @@ class Sanic:
             strict_slashes = self.strict_slashes
 
         def response(handler):
+            if isinstance(handler, tuple):
+                # if a handler fn is already wrapped in a route, the handler
+                # variable will be a tuple of (existing routes, handler fn)
+                routes, handler = handler
+            else:
+                routes = []
             args = list(signature(handler).parameters.keys())
 
             if not args:
+                handler_name = handler.__name__
+
                 raise ValueError(
-                    "Required parameter `request` missing "
+                    f"Required parameter `request` missing "
-                    "in the {0}() route?".format(handler.__name__)
+                    f"in the {handler_name}() route?"
                 )
 
             if stream:
                 handler.is_stream = stream
 
-            routes = self.router.add(
+            routes.extend(
+                self.router.add(
                     uri=uri,
                     methods=methods,
                     handler=handler,
@@ -214,6 +224,7 @@ class Sanic:
                     version=version,
                     name=name,
                 )
+            )
             return routes, handler
 
         return response
@@ -476,6 +487,13 @@ class Sanic:
             strict_slashes = self.strict_slashes
 
         def response(handler):
+            if isinstance(handler, tuple):
+                # if a handler fn is already wrapped in a route, the handler
+                # variable will be a tuple of (existing routes, handler fn)
+                routes, handler = handler
+            else:
+                routes = []
+
             async def websocket_handler(request, *args, **kwargs):
                 request.app = self
                 if not getattr(handler, "__blueprintname__", False):
@@ -491,12 +509,7 @@ class Sanic:
                 if self.asgi:
                     ws = request.transport.get_websocket_connection()
                 else:
-                    try:
                     protocol = request.transport.get_protocol()
-                    except AttributeError:
-                        # On Python3.5 the Transport classes in asyncio do not
-                        # have a get_protocol() method as in uvloop
-                        protocol = request.transport._protocol
                     protocol.app = self
 
                     ws = await protocol.websocket_handshake(
@@ -516,7 +529,8 @@ class Sanic:
                     self.websocket_tasks.remove(fut)
                 await ws.close()
 
-            routes = self.router.add(
+            routes.extend(
+                self.router.add(
                     uri=uri,
                     handler=websocket_handler,
                     methods=frozenset({"GET"}),
@@ -524,6 +538,7 @@ class Sanic:
                     strict_slashes=strict_slashes,
                     name=name,
                 )
+            )
             return routes, handler
 
         return response
@@ -581,29 +596,6 @@ class Sanic:
 
         self.websocket_enabled = enable
 
-    def remove_route(self, uri, clean_cache=True, host=None):
-        """
-        This method provides the app user a mechanism by which an already
-        existing route can be removed from the :class:`Sanic` object
-
-        .. warning::
-            remove_route is deprecated in v19.06 and will be removed
-            from future versions.
-
-        :param uri: URL Path to be removed from the app
-        :param clean_cache: Instruct sanic if it needs to clean up the LRU
-            route cache
-        :param host: IP address or FQDN specific to the host
-        :return: None
-        """
-        warnings.warn(
-            "remove_route is deprecated and will be removed "
-            "from future versions.",
-            DeprecationWarning,
-            stacklevel=2,
-        )
-        self.router.remove(uri, clean_cache, host)
-
     # Decorator
     def exception(self, *exceptions):
         """Decorate a function to be registered as a handler for exceptions
@@ -661,7 +653,7 @@ class Sanic:
                 if _rn not in self.named_response_middleware:
                     self.named_response_middleware[_rn] = deque()
                 if middleware not in self.named_response_middleware[_rn]:
-                    self.named_response_middleware[_rn].append(middleware)
+                    self.named_response_middleware[_rn].appendleft(middleware)
 
     # Decorator
     def middleware(self, middleware_or_request):
@@ -810,9 +802,17 @@ class Sanic:
         uri, route = self.router.find_route_by_view_name(view_name, **kw)
         if not (uri and route):
             raise URLBuildError(
-                "Endpoint with name `{}` was not found".format(view_name)
+                f"Endpoint with name `{view_name}` was not found"
             )
 
+        # If the route has host defined, split that off
+        # TODO: Retain netloc and path separately in Route objects
+        host = uri.find("/")
+        if host > 0:
+            host, uri = uri[:host], uri[host:]
+        else:
+            host = None
+
         if view_name == "static" or view_name.endswith(".static"):
             filename = kwargs.pop("filename", None)
             # it's static folder
@@ -824,7 +824,7 @@ class Sanic:
                 if filename.startswith("/"):
                     filename = filename[1:]
 
-                uri = "{}/{}".format(folder_, filename)
+                uri = f"{folder_}/{filename}"
 
         if uri != "/" and uri.endswith("/"):
             uri = uri[:-1]
@@ -845,7 +845,7 @@ class Sanic:
 
         netloc = kwargs.pop("_server", None)
         if netloc is None and external:
-            netloc = self.config.get("SERVER_NAME", "")
+            netloc = host or self.config.get("SERVER_NAME", "")
 
         if external:
             if not scheme:
@@ -860,7 +860,7 @@ class Sanic:
         for match in matched_params:
             name, _type, pattern = self.router.parse_parameter_string(match)
             # we only want to match against each individual parameter
-            specific_pattern = "^{}$".format(pattern)
+            specific_pattern = f"^{pattern}$"
             supplied_param = None
 
             if name in kwargs:
@@ -868,9 +868,7 @@ class Sanic:
                 del kwargs[name]
             else:
                 raise URLBuildError(
-                    "Required parameter `{}` was not passed to url_for".format(
+                    f"Required parameter `{name}` was not passed to url_for"
-                        name
-                    )
                 )
 
             supplied_param = str(supplied_param)
@@ -880,23 +878,22 @@ class Sanic:
 
             if not passes_pattern:
                 if _type != str:
+                    type_name = _type.__name__
+
                     msg = (
-                        'Value "{}" for parameter `{}` does not '
+                        f'Value "{supplied_param}" '
-                        "match pattern for type `{}`: {}".format(
+                        f"for parameter `{name}` does not "
-                            supplied_param, name, _type.__name__, pattern
+                        f"match pattern for type `{type_name}`: {pattern}"
-                        )
                     )
                 else:
                     msg = (
-                        'Value "{}" for parameter `{}` '
+                        f'Value "{supplied_param}" for parameter `{name}` '
-                        "does not satisfy pattern {}".format(
+                        f"does not satisfy pattern {pattern}"
-                            supplied_param, name, pattern
-                        )
                     )
                 raise URLBuildError(msg)
 
             # replace the parameter in the URL with the supplied value
-            replacement_regex = "(<{}.*?>)".format(name)
+            replacement_regex = f"(<{name}.*?>)"
 
             out = re.sub(replacement_regex, supplied_param, out)
 
@@ -997,9 +994,8 @@ class Sanic:
                     )
                 elif self.debug:
                     response = HTTPResponse(
-                        "Error while handling error: {}\nStack: {}".format(
+                        f"Error while "
-                            e, format_exc()
+                        f"handling error: {e}\nStack: {format_exc()}",
-                        ),
                         status=500,
                     )
                 else:
@@ -1071,7 +1067,7 @@ class Sanic:
         stop_event: Any = None,
         register_sys_signals: bool = True,
         access_log: Optional[bool] = None,
-        **kwargs: Any
+        **kwargs: Any,
     ) -> None:
         """Run the HTTP Server and listen until keyboard interrupt or term
         signal. On termination, drain connections before closing.
@@ -1152,6 +1148,13 @@ class Sanic:
 
         try:
             self.is_running = True
+            self.is_stopping = False
+            if workers > 1 and os.name != "posix":
+                logger.warn(
+                    f"Multiprocessing is currently not supported on {os.name},"
+                    " using workers=1 instead"
+                )
+                workers = 1
             if workers == 1:
                 if auto_reload and os.name != "posix":
                     # This condition must be removed after implementing
@@ -1178,6 +1181,8 @@ class Sanic:
 
     def stop(self):
         """This kills the Sanic"""
+        if not self.is_stopping:
+            self.is_stopping = True
             get_event_loop().stop()
 
     async def create_server(
@@ -1363,33 +1368,15 @@ class Sanic:
 
         server_settings = {
             "protocol": protocol,
-            "request_class": self.request_class,
-            "is_request_stream": self.is_request_stream,
-            "router": self.router,
             "host": host,
             "port": port,
             "sock": sock,
             "ssl": ssl,
             "app": self,
             "signal": Signal(),
-            "debug": debug,
-            "request_handler": self.handle_request,
-            "error_handler": self.error_handler,
-            "request_timeout": self.config.REQUEST_TIMEOUT,
-            "response_timeout": self.config.RESPONSE_TIMEOUT,
-            "keep_alive_timeout": self.config.KEEP_ALIVE_TIMEOUT,
-            "request_max_size": self.config.REQUEST_MAX_SIZE,
-            "request_buffer_queue_size": self.config.REQUEST_BUFFER_QUEUE_SIZE,
-            "keep_alive": self.config.KEEP_ALIVE,
             "loop": loop,
             "register_sys_signals": register_sys_signals,
             "backlog": backlog,
-            "access_log": self.config.ACCESS_LOG,
-            "websocket_max_size": self.config.WEBSOCKET_MAX_SIZE,
-            "websocket_max_queue": self.config.WEBSOCKET_MAX_QUEUE,
-            "websocket_read_limit": self.config.WEBSOCKET_READ_LIMIT,
-            "websocket_write_limit": self.config.WEBSOCKET_WRITE_LIMIT,
-            "graceful_shutdown_timeout": self.config.GRACEFUL_SHUTDOWN_TIMEOUT,
         }
 
         # -------------------------------------------- #
@@ -1430,7 +1417,7 @@ class Sanic:
             proto = "http"
             if ssl is not None:
                 proto = "https"
-            logger.info("Goin' Fast @ {}://{}:{}".format(proto, host, port))
+            logger.info(f"Goin' Fast @ {proto}://{host}:{port}")
 
         return server_settings
 

sanic/blueprints.py

@@ -151,7 +151,7 @@ class Blueprint:
                     future.middleware,
                     route_names,
                     *future.args,
-                    **future.kwargs
+                    **future.kwargs,
                 )
             else:
                 app.register_named_middleware(future.middleware, route_names)
@@ -376,7 +376,7 @@ class Blueprint:
         """
         name = kwargs.pop("name", "static")
         if not name.startswith(self.name + "."):
-            name = "{}.{}".format(self.name, name)
+            name = f"{self.name}.{name}"
         kwargs.update(name=name)
 
         strict_slashes = kwargs.get("strict_slashes")

sanic/compat.py

@@ -1,6 +1,52 @@
+import asyncio
+import signal
+
+from sys import argv
+
 from multidict import CIMultiDict  # type: ignore
 
 
 class Header(CIMultiDict):
     def get_all(self, key):
         return self.getall(key, default=[])
+
+
+use_trio = argv[0].endswith("hypercorn") and "trio" in argv
+
+if use_trio:
+    from trio import open_file as open_async, Path  # type: ignore
+
+    def stat_async(path):
+        return Path(path).stat()
+
+
+else:
+    from aiofiles import open as aio_open  # type: ignore
+    from aiofiles.os import stat as stat_async  # type: ignore  # noqa: F401
+
+    async def open_async(file, mode="r", **kwargs):
+        return aio_open(file, mode, **kwargs)
+
+
+def ctrlc_workaround_for_windows(app):
+    async def stay_active(app):
+        """Asyncio wakeups to allow receiving SIGINT in Python"""
+        while not die:
+            # If someone else stopped the app, just exit
+            if app.is_stopping:
+                return
+            # Windows Python blocks signal handlers while the event loop is
+            # waiting for I/O. Frequent wakeups keep interrupts flowing.
+            await asyncio.sleep(0.1)
+        # Can't be called from signal handler, so call it from here
+        app.stop()
+
+    def ctrlc_handler(sig, frame):
+        nonlocal die
+        if die:
+            raise KeyboardInterrupt("Non-graceful Ctrl+C")
+        die = True
+
+    die = False
+    signal.signal(signal.SIGINT, ctrlc_handler)
+    app.add_task(stay_active)

sanic/config.py

@@ -20,7 +20,7 @@ DEFAULT_CONFIG = {
     "RESPONSE_TIMEOUT": 60,  # 60 seconds
     "KEEP_ALIVE": True,
     "KEEP_ALIVE_TIMEOUT": 5,  # 5 seconds
-    "WEBSOCKET_MAX_SIZE": 2 ** 20,  # 1 megabytes
+    "WEBSOCKET_MAX_SIZE": 2 ** 20,  # 1 megabyte
     "WEBSOCKET_MAX_QUEUE": 32,
     "WEBSOCKET_READ_LIMIT": 2 ** 16,
     "WEBSOCKET_WRITE_LIMIT": 2 ** 16,
@@ -51,7 +51,7 @@ class Config(dict):
         try:
             return self[attr]
         except KeyError as ke:
-            raise AttributeError("Config has no '{}'".format(ke.args[0]))
+            raise AttributeError(f"Config has no '{ke.args[0]}'")
 
     def __setattr__(self, attr, value):
         self[attr] = value

sanic/errorpages.py

@@ -0,0 +1,117 @@
+import sys
+
+from traceback import extract_tb
+
+from sanic.exceptions import SanicException
+from sanic.helpers import STATUS_CODES
+from sanic.response import html
+
+
+# Here, There Be Dragons (custom HTML formatting to follow)
+
+
+def escape(text):
+    """Minimal HTML escaping, not for attribute values (unlike html.escape)."""
+    return f"{text}".replace("&", "&amp;").replace("<", "&lt;")
+
+
+def exception_response(request, exception, debug):
+    status = 500
+    text = (
+        "The server encountered an internal error "
+        "and cannot complete your request."
+    )
+
+    headers = {}
+    if isinstance(exception, SanicException):
+        text = f"{exception}"
+        status = getattr(exception, "status_code", status)
+        headers = getattr(exception, "headers", headers)
+    elif debug:
+        text = f"{exception}"
+
+    status_text = STATUS_CODES.get(status, b"Error Occurred").decode()
+    title = escape(f"{status} — {status_text}")
+    text = escape(text)
+
+    if debug and not getattr(exception, "quiet", False):
+        return html(
+            f"<!DOCTYPE html><meta charset=UTF-8><title>{title}</title>"
+            f"<style>{TRACEBACK_STYLE}</style>\n"
+            f"<h1>⚠️ {title}</h1><p>{text}\n"
+            f"{_render_traceback_html(request, exception)}",
+            status=status,
+        )
+
+    # Keeping it minimal with trailing newline for pretty curl/console output
+    return html(
+        f"<!DOCTYPE html><meta charset=UTF-8><title>{title}</title>"
+        "<style>html { font-family: sans-serif }</style>\n"
+        f"<h1>⚠️ {title}</h1><p>{text}\n",
+        status=status,
+        headers=headers,
+    )
+
+
+def _render_exception(exception):
+    frames = extract_tb(exception.__traceback__)
+    frame_html = "".join(TRACEBACK_LINE_HTML.format(frame) for frame in frames)
+    return TRACEBACK_WRAPPER_HTML.format(
+        exc_name=escape(exception.__class__.__name__),
+        exc_value=escape(exception),
+        frame_html=frame_html,
+    )
+
+
+def _render_traceback_html(request, exception):
+    exc_type, exc_value, tb = sys.exc_info()
+    exceptions = []
+    while exc_value:
+        exceptions.append(_render_exception(exc_value))
+        exc_value = exc_value.__cause__
+
+    traceback_html = TRACEBACK_BORDER.join(reversed(exceptions))
+    appname = escape(request.app.name)
+    name = escape(exception.__class__.__name__)
+    value = escape(exception)
+    path = escape(request.path)
+    return (
+        f"<h2>Traceback of {appname} (most recent call last):</h2>"
+        f"{traceback_html}"
+        "<div class=summary><p>"
+        f"<b>{name}: {value}</b> while handling path <code>{path}</code>"
+    )
+
+
+TRACEBACK_STYLE = """
+    html { font-family: sans-serif }
+    h2 { color: #888; }
+    .tb-wrapper p { margin: 0 }
+    .frame-border { margin: 1rem }
+    .frame-line > * { padding: 0.3rem 0.6rem }
+    .frame-line { margin-bottom: 0.3rem }
+    .frame-code { font-size: 16px; padding-left: 4ch }
+    .tb-wrapper { border: 1px solid #eee }
+    .tb-header { background: #eee; padding: 0.3rem; font-weight: bold }
+    .frame-descriptor { background: #e2eafb; font-size: 14px }
+"""
+
+TRACEBACK_WRAPPER_HTML = (
+    "<div class=tb-header>{exc_name}: {exc_value}</div>"
+    "<div class=tb-wrapper>{frame_html}</div>"
+)
+
+TRACEBACK_BORDER = (
+    "<div class=frame-border>"
+    "The above exception was the direct cause of the following exception:"
+    "</div>"
+)
+
+TRACEBACK_LINE_HTML = (
+    "<div class=frame-line>"
+    "<p class=frame-descriptor>"
+    "File {0.filename}, line <i>{0.lineno}</i>, "
+    "in <code><b>{0.name}</b></code>"
+    "<p class=frame-code><code>{0.line}</code>"
+    "</div>"
+)

sanic/exceptions.py

@@ -1,133 +1,18 @@
 from sanic.helpers import STATUS_CODES
 
 
-TRACEBACK_STYLE = """
-    <style>
-        body {
-            padding: 20px;
-            font-family: Arial, sans-serif;
-        }
-
-        p {
-            margin: 0;
-        }
-
-        .summary {
-            padding: 10px;
-        }
-
-        h1 {
-            margin-bottom: 0;
-        }
-
-        h3 {
-            margin-top: 10px;
-        }
-
-        h3 code {
-            font-size: 24px;
-        }
-
-        .frame-line > * {
-            padding: 5px 10px;
-        }
-
-        .frame-line {
-            margin-bottom: 5px;
-        }
-
-        .frame-code {
-            font-size: 16px;
-            padding-left: 30px;
-        }
-
-        .tb-wrapper {
-            border: 1px solid #f3f3f3;
-        }
-
-        .tb-header {
-            background-color: #f3f3f3;
-            padding: 5px 10px;
-        }
-
-        .tb-border {
-            padding-top: 20px;
-        }
-
-        .frame-descriptor {
-            background-color: #e2eafb;
-        }
-
-        .frame-descriptor {
-            font-size: 14px;
-        }
-    </style>
-"""
-
-TRACEBACK_WRAPPER_HTML = """
-    <html>
-        <head>
-            {style}
-        </head>
-        <body>
-            {inner_html}
-            <div class="summary">
-                <p>
-                <b>{exc_name}: {exc_value}</b>
-                    while handling path <code>{path}</code>
-                </p>
-            </div>
-        </body>
-    </html>
-"""
-
-TRACEBACK_WRAPPER_INNER_HTML = """
-    <h1>{exc_name}</h1>
-    <h3><code>{exc_value}</code></h3>
-    <div class="tb-wrapper">
-        <p class="tb-header">Traceback (most recent call last):</p>
-        {frame_html}
-    </div>
-"""
-
-TRACEBACK_BORDER = """
-    <div class="tb-border">
-        <b><i>
-            The above exception was the direct cause of the
-            following exception:
-        </i></b>
-    </div>
-"""
-
-TRACEBACK_LINE_HTML = """
-    <div class="frame-line">
-        <p class="frame-descriptor">
-            File {0.filename}, line <i>{0.lineno}</i>,
-            in <code><b>{0.name}</b></code>
-        </p>
-        <p class="frame-code"><code>{0.line}</code></p>
-    </div>
-"""
-
-INTERNAL_SERVER_ERROR_HTML = """
-    <h1>Internal Server Error</h1>
-    <p>
-        The server encountered an internal error and cannot complete
-        your request.
-    </p>
-"""
-
-
 _sanic_exceptions = {}
 
 
-def add_status_code(code):
+def add_status_code(code, quiet=None):
     """
     Decorator used for adding exceptions to :class:`SanicException`.
     """
 
     def class_decorator(cls):
         cls.status_code = code
+        if quiet or quiet is None and code != 500:
+            cls.quiet = True
         _sanic_exceptions[code] = cls
         return cls
 
@@ -135,12 +20,16 @@ def add_status_code(code):
 
 
 class SanicException(Exception):
-    def __init__(self, message, status_code=None):
+    def __init__(self, message, status_code=None, quiet=None):
         super().__init__(message)
 
         if status_code is not None:
             self.status_code = status_code
 
+        # quiet=None/False/True with None meaning choose by status
+        if quiet or quiet is None and status_code not in (None, 500):
+            self.quiet = True
+
 
 @add_status_code(404)
 class NotFound(SanicException):
@@ -156,10 +45,7 @@ class InvalidUsage(SanicException):
 class MethodNotSupported(SanicException):
     def __init__(self, message, method, allowed_methods):
         super().__init__(message)
-        self.headers = dict()
+        self.headers = {"Allow": ", ".join(allowed_methods)}
-        self.headers["Allow"] = ", ".join(allowed_methods)
-        if method in ["HEAD", "PATCH", "PUT", "DELETE"]:
-            self.headers["Content-Length"] = 0
 
 
 @add_status_code(500)
@@ -212,10 +98,7 @@ class HeaderNotFound(InvalidUsage):
 class ContentRangeError(SanicException):
     def __init__(self, message, content_range):
         super().__init__(message)
-        self.headers = {
+        self.headers = {"Content-Range": f"bytes */{content_range.total}"}
-            "Content-Type": "text/plain",
-            "Content-Range": "bytes */%s" % (content_range.total,),
-        }
 
 
 @add_status_code(417)
@@ -282,7 +165,7 @@ class Unauthorized(SanicException):
             challenge = ", ".join(values)
 
             self.headers = {
-                "WWW-Authenticate": "{} {}".format(scheme, challenge).rstrip()
+                "WWW-Authenticate": f"{scheme} {challenge}".rstrip()
             }
 
 

sanic/handlers.py

@@ -1,21 +1,13 @@
-import sys
+from traceback import format_exc
-
-from traceback import extract_tb, format_exc
 
+from sanic.errorpages import exception_response
 from sanic.exceptions import (
-    INTERNAL_SERVER_ERROR_HTML,
-    TRACEBACK_BORDER,
-    TRACEBACK_LINE_HTML,
-    TRACEBACK_STYLE,
-    TRACEBACK_WRAPPER_HTML,
-    TRACEBACK_WRAPPER_INNER_HTML,
     ContentRangeError,
     HeaderNotFound,
     InvalidRangeType,
-    SanicException,
 )
 from sanic.log import logger
-from sanic.response import html, text
+from sanic.response import text
 
 
 class ErrorHandler:
@@ -40,35 +32,6 @@ class ErrorHandler:
         self.cached_handlers = {}
         self.debug = False
 
-    def _render_exception(self, exception):
-        frames = extract_tb(exception.__traceback__)
-
-        frame_html = []
-        for frame in frames:
-            frame_html.append(TRACEBACK_LINE_HTML.format(frame))
-
-        return TRACEBACK_WRAPPER_INNER_HTML.format(
-            exc_name=exception.__class__.__name__,
-            exc_value=exception,
-            frame_html="".join(frame_html),
-        )
-
-    def _render_traceback_html(self, exception, request):
-        exc_type, exc_value, tb = sys.exc_info()
-        exceptions = []
-
-        while exc_value:
-            exceptions.append(self._render_exception(exc_value))
-            exc_value = exc_value.__cause__
-
-        return TRACEBACK_WRAPPER_HTML.format(
-            style=TRACEBACK_STYLE,
-            exc_name=exception.__class__.__name__,
-            exc_value=exception,
-            inner_html=TRACEBACK_BORDER.join(reversed(exceptions)),
-            path=request.path,
-        )
-
     def add(self, exception, handler):
         """
         Add a new exception handler to an already existing handler object.
@@ -166,27 +129,17 @@ class ErrorHandler:
             :class:`Exception`
         :return:
         """
-        self.log(format_exc())
+        quiet = getattr(exception, "quiet", False)
+        if quiet is False:
             try:
                 url = repr(request.url)
             except AttributeError:
                 url = "unknown"
 
-        response_message = "Exception occurred while handling uri: %s"
+            self.log(format_exc())
-        logger.exception(response_message, url)
+            logger.exception("Exception occurred while handling uri: %s", url)
 
-        if issubclass(type(exception), SanicException):
+        return exception_response(request, exception, self.debug)
-            return text(
-                "Error: {}".format(exception),
-                status=getattr(exception, "status_code", 500),
-                headers=getattr(exception, "headers", dict()),
-            )
-        elif self.debug:
-            html_output = self._render_traceback_html(exception, request)
-
-            return html(html_output, status=500)
-        else:
-            return html(INTERNAL_SERVER_ERROR_HTML, status=500)
 
 
 class ContentRangeHandler:

sanic/headers.py

@@ -3,6 +3,8 @@ import re
 from typing import Any, Dict, Iterable, List, Optional, Tuple, Union
 from urllib.parse import unquote
 
+from sanic.helpers import STATUS_CODES
+
 
 HeaderIterable = Iterable[Tuple[str, Any]]  # Values convertible to str
 Options = Dict[str, Union[int, str]]  # key=value fields in various headers
@@ -180,3 +182,19 @@ def format_http1(headers: HeaderIterable) -> bytes:
     - Values are converted into strings if necessary.
     """
     return "".join(f"{name}: {val}\r\n" for name, val in headers).encode()
+
+
+def format_http1_response(
+    status: int, headers: HeaderIterable, body=b""
+) -> bytes:
+    """Format a full HTTP/1.1 response.
+
+    - If `body` is included, content-length must be specified in headers.
+    """
+    headerbytes = format_http1(headers)
+    return b"HTTP/1.1 %d %b\r\n%b\r\n%b" % (
+        status,
+        STATUS_CODES.get(status, b"UNKNOWN"),
+        headerbytes,
+        body,
+    )

sanic/reloader_helpers.py

@@ -72,7 +72,7 @@ def kill_process_children_unix(pid):
     :param pid: PID of parent process (process ID)
     :return: Nothing
     """
-    root_process_path = "/proc/{pid}/task/{pid}/children".format(pid=pid)
+    root_process_path = f"/proc/{pid}/task/{pid}/children"
     if not os.path.isfile(root_process_path):
         return
     with open(root_process_path) as children_list_file:

sanic/request.py

@@ -1,6 +1,5 @@
 import asyncio
 import email.utils
-import warnings
 
 from collections import defaultdict, namedtuple
 from http.cookies import SimpleCookie
@@ -56,6 +55,14 @@ class StreamBuffer:
         self._queue.task_done()
         return payload
 
+    async def __aiter__(self):
+        """Support `async for data in request.stream`"""
+        while True:
+            data = await self.read()
+            if not data:
+                break
+            yield data
+
     async def put(self, payload):
         await self._queue.put(payload)
 
@@ -123,44 +130,37 @@ class Request:
         self.endpoint = None
 
     def __repr__(self):
-        return "<{0}: {1} {2}>".format(
+        class_name = self.__class__.__name__
-            self.__class__.__name__, self.method, self.path
+        return f"<{class_name}: {self.method} {self.path}>"
-        )
-
-    def get(self, key, default=None):
-        """.. deprecated:: 19.9
-           Custom context is now stored in `request.custom_context.yourkey`"""
-        return self.ctx.__dict__.get(key, default)
-
-    def __contains__(self, key):
-        """.. deprecated:: 19.9
-           Custom context is now stored in `request.custom_context.yourkey`"""
-        return key in self.ctx.__dict__
-
-    def __getitem__(self, key):
-        """.. deprecated:: 19.9
-           Custom context is now stored in `request.custom_context.yourkey`"""
-        return self.ctx.__dict__[key]
-
-    def __delitem__(self, key):
-        """.. deprecated:: 19.9
-           Custom context is now stored in `request.custom_context.yourkey`"""
-        del self.ctx.__dict__[key]
-
-    def __setitem__(self, key, value):
-        """.. deprecated:: 19.9
-           Custom context is now stored in `request.custom_context.yourkey`"""
-        setattr(self.ctx, key, value)
 
     def body_init(self):
+        """.. deprecated:: 20.3"""
         self.body = []
 
     def body_push(self, data):
+        """.. deprecated:: 20.3"""
         self.body.append(data)
 
     def body_finish(self):
+        """.. deprecated:: 20.3"""
         self.body = b"".join(self.body)
 
+    async def receive_body(self):
+        """Receive request.body, if not already received.
+
+        Streaming handlers may call this to receive the full body.
+
+        This is added as a compatibility shim in Sanic 20.3 because future
+        versions of Sanic will make all requests streaming and will use this
+        function instead of the non-async body_init/push/finish functions.
+
+        Please make an issue if your code depends on the old functionality and
+        cannot be upgraded to the new API.
+        """
+        if not self.stream:
+            return
+        self.body = b"".join([data async for data in self.stream])
+
     @property
     def json(self):
         if self.parsed_json is None:
@@ -282,18 +282,6 @@ class Request:
 
     args = property(get_args)
 
-    @property
-    def raw_args(self) -> dict:
-        if self.app.debug:  # pragma: no cover
-            warnings.simplefilter("default")
-        warnings.warn(
-            "Use of raw_args will be deprecated in "
-            "the future versions. Please use args or query_args "
-            "properties instead",
-            DeprecationWarning,
-        )
-        return {k: v[0] for k, v in self.args.items()}
-
     def get_query_args(
         self,
         keep_blank_values: bool = False,
@@ -538,7 +526,7 @@ class Request:
         ):
             netloc = host
         else:
-            netloc = "{}:{}".format(host, port)
+            netloc = f"{host}:{port}"
 
         return self.app.url_for(
             view_name, _external=True, _scheme=scheme, _server=netloc, **kwargs

sanic/response.py

@@ -1,14 +1,14 @@
+import warnings
+
 from functools import partial
 from mimetypes import guess_type
 from os import path
 from urllib.parse import quote_plus
 
-from aiofiles import open as open_async  # type: ignore
+from sanic.compat import Header, open_async
-
-from sanic.compat import Header
 from sanic.cookies import CookieJar
-from sanic.headers import format_http1
+from sanic.headers import format_http1, format_http1_response
-from sanic.helpers import STATUS_CODES, has_message_body, remove_entity_headers
+from sanic.helpers import has_message_body, remove_entity_headers
 
 
 try:
@@ -23,12 +23,7 @@ except ImportError:
 
 class BaseHTTPResponse:
     def _encode_body(self, data):
-        try:
+        return data.encode() if hasattr(data, "encode") else data
-            # Try to encode it regularly
-            return data.encode()
-        except AttributeError:
-            # Convert it to a str if you can't
-            return str(data).encode()
 
     def _parse_headers(self):
         return format_http1(self.headers.items())
@@ -39,6 +34,32 @@ class BaseHTTPResponse:
             self._cookies = CookieJar(self.headers)
         return self._cookies
 
+    def get_headers(
+        self,
+        version="1.1",
+        keep_alive=False,
+        keep_alive_timeout=None,
+        body=b"",
+    ):
+        """.. deprecated:: 20.3:
+           This function is not public API and will be removed."""
+
+        # self.headers get priority over content_type
+        if self.content_type and "Content-Type" not in self.headers:
+            self.headers["Content-Type"] = self.content_type
+
+        if keep_alive:
+            self.headers["Connection"] = "keep-alive"
+            if keep_alive_timeout is not None:
+                self.headers["Keep-Alive"] = keep_alive_timeout
+        else:
+            self.headers["Connection"] = "close"
+
+        if self.status in (304, 412):
+            self.headers = remove_entity_headers(self.headers)
+
+        return format_http1_response(self.status, self.headers.items(), body)
+
 
 class StreamingHTTPResponse(BaseHTTPResponse):
     __slots__ = (
@@ -56,7 +77,7 @@ class StreamingHTTPResponse(BaseHTTPResponse):
         streaming_fn,
         status=200,
         headers=None,
-        content_type="text/plain",
+        content_type="text/plain; charset=utf-8",
         chunked=True,
     ):
         self.content_type = content_type
@@ -65,13 +86,13 @@ class StreamingHTTPResponse(BaseHTTPResponse):
         self.headers = Header(headers or {})
         self.chunked = chunked
         self._cookies = None
+        self.protocol = None
 
     async def write(self, data):
         """Writes a chunk of data to the streaming response.
 
-        :param data: bytes-ish data to be written.
+        :param data: str or bytes-ish data to be written.
         """
-        if type(data) != bytes:
         data = self._encode_body(data)
 
         if self.chunked:
@@ -104,33 +125,11 @@ class StreamingHTTPResponse(BaseHTTPResponse):
     def get_headers(
         self, version="1.1", keep_alive=False, keep_alive_timeout=None
     ):
-        # This is all returned in a kind-of funky way
-        # We tried to make this as fast as possible in pure python
-        timeout_header = b""
-        if keep_alive and keep_alive_timeout is not None:
-            timeout_header = b"Keep-Alive: %d\r\n" % keep_alive_timeout
-
         if self.chunked and version == "1.1":
             self.headers["Transfer-Encoding"] = "chunked"
             self.headers.pop("Content-Length", None)
-        self.headers["Content-Type"] = self.headers.get(
-            "Content-Type", self.content_type
-        )
 
-        headers = self._parse_headers()
+        return super().get_headers(version, keep_alive, keep_alive_timeout)
-
-        if self.status == 200:
-            status = b"OK"
-        else:
-            status = STATUS_CODES.get(self.status)
-
-        return (b"HTTP/%b %d %b\r\n" b"%b" b"%b\r\n") % (
-            version.encode(),
-            self.status,
-            status,
-            timeout_header,
-            headers,
-        )
 
 
 class HTTPResponse(BaseHTTPResponse):
@@ -145,23 +144,12 @@ class HTTPResponse(BaseHTTPResponse):
         body_bytes=b"",
     ):
         self.content_type = content_type
-
+        self.body = body_bytes if body is None else self._encode_body(body)
-        if body is not None:
-            self.body = self._encode_body(body)
-        else:
-            self.body = body_bytes
-
         self.status = status
         self.headers = Header(headers or {})
         self._cookies = None
 
     def output(self, version="1.1", keep_alive=False, keep_alive_timeout=None):
-        # This is all returned in a kind-of funky way
-        # We tried to make this as fast as possible in pure python
-        timeout_header = b""
-        if keep_alive and keep_alive_timeout is not None:
-            timeout_header = b"Keep-Alive: %d\r\n" % keep_alive_timeout
-
         body = b""
         if has_message_body(self.status):
             body = self.body
@@ -169,31 +157,7 @@ class HTTPResponse(BaseHTTPResponse):
                 "Content-Length", len(self.body)
             )
 
-        # self.headers get priority over content_type
+        return self.get_headers(version, keep_alive, keep_alive_timeout, body)
-        if self.content_type and "Content-Type" not in self.headers:
-            self.headers["Content-Type"] = self.content_type
-
-        if self.status in (304, 412):
-            self.headers = remove_entity_headers(self.headers)
-
-        headers = self._parse_headers()
-
-        if self.status == 200:
-            status = b"OK"
-        else:
-            status = STATUS_CODES.get(self.status, b"UNKNOWN RESPONSE")
-
-        return (
-            b"HTTP/%b %d %b\r\n" b"Connection: %b\r\n" b"%b" b"%b\r\n" b"%b"
-        ) % (
-            version.encode(),
-            self.status,
-            status,
-            b"keep-alive" if keep_alive else b"close",
-            timeout_header,
-            headers,
-            body,
-        )
 
     @property
     def cookies(self):
@@ -202,16 +166,14 @@ class HTTPResponse(BaseHTTPResponse):
         return self._cookies
 
 
-def empty(
+def empty(status=204, headers=None):
-    status=204, headers=None,
-):
     """
     Returns an empty response to the client.
 
     :param status Response code.
     :param headers Custom Headers.
     """
-    return HTTPResponse(body_bytes=b"", status=status, headers=headers,)
+    return HTTPResponse(body_bytes=b"", status=status, headers=headers)
 
 
 def json(
@@ -220,7 +182,7 @@ def json(
     headers=None,
     content_type="application/json",
     dumps=json_dumps,
-    **kwargs
+    **kwargs,
 ):
     """
     Returns response object with body in json format.
@@ -249,6 +211,21 @@ def text(
     :param headers: Custom Headers.
     :param content_type: the content type (string) of the response
     """
+    if not isinstance(body, str):
+        warnings.warn(
+            "Types other than str will be deprecated in future versions for"
+            f" response.text, got type {type(body).__name__})",
+            DeprecationWarning,
+        )
+    # Type conversions are deprecated and quite b0rked but still supported for
+    # text() until applications get fixed. This try-except should be removed.
+    try:
+        # Avoid repr(body).encode() b0rkage for body that is already encoded.
+        # memoryview used only to test bytes-ishness.
+        with memoryview(body):
+            pass
+    except TypeError:
+        body = f"{body}"  # no-op if body is already str
     return HTTPResponse(
         body, status=status, headers=headers, content_type=content_type
     )
@@ -277,10 +254,14 @@ def html(body, status=200, headers=None):
     """
     Returns response object with body in html format.
 
-    :param body: Response data to be encoded.
+    :param body: str or bytes-ish, or an object with __html__ or _repr_html_.
     :param status: Response code.
     :param headers: Custom Headers.
     """
+    if hasattr(body, "__html__"):
+        body = body.__html__()
+    elif hasattr(body, "_repr_html_"):
+        body = body._repr_html_()
     return HTTPResponse(
         body,
         status=status,
@@ -308,22 +289,20 @@ async def file(
     headers = headers or {}
     if filename:
         headers.setdefault(
-            "Content-Disposition", 'attachment; filename="{}"'.format(filename)
+            "Content-Disposition", f'attachment; filename="{filename}"'
         )
     filename = filename or path.split(location)[-1]
 
-    async with open_async(location, mode="rb") as _file:
+    async with await open_async(location, mode="rb") as f:
         if _range:
-            await _file.seek(_range.start)
+            await f.seek(_range.start)
-            out_stream = await _file.read(_range.size)
+            out_stream = await f.read(_range.size)
-            headers["Content-Range"] = "bytes %s-%s/%s" % (
+            headers[
-                _range.start,
+                "Content-Range"
-                _range.end,
+            ] = f"bytes {_range.start}-{_range.end}/{_range.total}"
-                _range.total,
-            )
             status = 206
         else:
-            out_stream = await _file.read()
+            out_stream = await f.read()
 
     mime_type = mime_type or guess_type(filename)[0] or "text/plain"
     return HTTPResponse(
@@ -357,43 +336,36 @@ async def file_stream(
     headers = headers or {}
     if filename:
         headers.setdefault(
-            "Content-Disposition", 'attachment; filename="{}"'.format(filename)
+            "Content-Disposition", f'attachment; filename="{filename}"'
         )
     filename = filename or path.split(location)[-1]
+    mime_type = mime_type or guess_type(filename)[0] or "text/plain"
+    if _range:
+        start = _range.start
+        end = _range.end
+        total = _range.total
 
-    _file = await open_async(location, mode="rb")
+        headers["Content-Range"] = f"bytes {start}-{end}/{total}"
+        status = 206
 
     async def _streaming_fn(response):
-        nonlocal _file, chunk_size
+        async with await open_async(location, mode="rb") as f:
-        try:
             if _range:
-                chunk_size = min((_range.size, chunk_size))
+                await f.seek(_range.start)
-                await _file.seek(_range.start)
                 to_send = _range.size
                 while to_send > 0:
-                    content = await _file.read(chunk_size)
+                    content = await f.read(min((_range.size, chunk_size)))
                     if len(content) < 1:
                         break
                     to_send -= len(content)
                     await response.write(content)
             else:
                 while True:
-                    content = await _file.read(chunk_size)
+                    content = await f.read(chunk_size)
                     if len(content) < 1:
                         break
                     await response.write(content)
-        finally:
-            await _file.close()
-        return  # Returning from this fn closes the stream
 
-    mime_type = mime_type or guess_type(filename)[0] or "text/plain"
-    if _range:
-        headers["Content-Range"] = "bytes %s-%s/%s" % (
-            _range.start,
-            _range.end,
-            _range.total,
-        )
-        status = 206
     return StreamingHTTPResponse(
         streaming_fn=_streaming_fn,
         status=status,

sanic/router.py

@@ -109,7 +109,7 @@ class Router:
             name, pattern = parameter_string.split(":", 1)
             if not name:
                 raise ValueError(
-                    "Invalid parameter syntax: {}".format(parameter_string)
+                    f"Invalid parameter syntax: {parameter_string}"
                 )
 
         default = (str, pattern)
@@ -143,7 +143,7 @@ class Router:
         routes = []
         if version is not None:
             version = re.escape(str(version).strip("/").lstrip("v"))
-            uri = "/".join(["/v{}".format(version), uri.lstrip("/")])
+            uri = "/".join([f"/v{version}", uri.lstrip("/")])
         # add regular version
         routes.append(self._add(uri, methods, handler, host, name))
 
@@ -203,8 +203,8 @@ class Router:
             else:
                 if not isinstance(host, Iterable):
                     raise ValueError(
-                        "Expected either string or Iterable of "
+                        f"Expected either string or Iterable of "
-                        "host strings, not {!r}".format(host)
+                        f"host strings, not {host!r}"
                     )
 
                 for host_ in host:
@@ -225,8 +225,7 @@ class Router:
 
             if name in parameter_names:
                 raise ParameterNameConflicts(
-                    "Multiple parameter named <{name}> "
+                    f"Multiple parameter named <{name}> " f"in route uri {uri}"
-                    "in route uri {uri}".format(name=name, uri=uri)
                 )
             parameter_names.add(name)
 
@@ -240,23 +239,23 @@ class Router:
             elif re.search(r"/", pattern):
                 properties["unhashable"] = True
 
-            return "({})".format(pattern)
+            return f"({pattern})"
 
         pattern_string = re.sub(self.parameter_pattern, add_parameter, uri)
-        pattern = re.compile(r"^{}$".format(pattern_string))
+        pattern = re.compile(fr"^{pattern_string}$")
 
         def merge_route(route, methods, handler):
             # merge to the existing route when possible.
             if not route.methods or not methods:
                 # method-unspecified routes are not mergeable.
-                raise RouteExists("Route already registered: {}".format(uri))
+                raise RouteExists(f"Route already registered: {uri}")
             elif route.methods.intersection(methods):
                 # already existing method is not overloadable.
                 duplicated = methods.intersection(route.methods)
+                duplicated_methods = ",".join(list(duplicated))
+
                 raise RouteExists(
-                    "Route already registered: {} [{}]".format(
+                    f"Route already registered: {uri} [{duplicated_methods}]"
-                        uri, ",".join(list(duplicated))
-                    )
                 )
             if isinstance(route.handler, CompositionView):
                 view = route.handler
@@ -296,9 +295,9 @@ class Router:
             name = name.split("_static_", 1)[-1]
 
         if hasattr(handler, "__blueprintname__"):
-            handler_name = "{}.{}".format(
+            bp_name = handler.__blueprintname__
-                handler.__blueprintname__, name or handler.__name__
+
-            )
+            handler_name = f"{bp_name}.{name or handler.__name__}"
         else:
             handler_name = name or getattr(handler, "__name__", None)
 
@@ -352,37 +351,6 @@ class Router:
         else:
             return -1, None
 
-    def remove(self, uri, clean_cache=True, host=None):
-        if host is not None:
-            uri = host + uri
-        try:
-            route = self.routes_all.pop(uri)
-            for handler_name, pairs in self.routes_names.items():
-                if pairs[0] == uri:
-                    self.routes_names.pop(handler_name)
-                    break
-
-            for handler_name, pairs in self.routes_static_files.items():
-                if pairs[0] == uri:
-                    self.routes_static_files.pop(handler_name)
-                    break
-
-        except KeyError:
-            raise RouteDoesNotExist("Route was not registered: {}".format(uri))
-
-        if route in self.routes_always_check:
-            self.routes_always_check.remove(route)
-        elif (
-            url_hash(uri) in self.routes_dynamic
-            and route in self.routes_dynamic[url_hash(uri)]
-        ):
-            self.routes_dynamic[url_hash(uri)].remove(route)
-        else:
-            self.routes_static.pop(uri)
-
-        if clean_cache:
-            self._get.cache_clear()
-
     @lru_cache(maxsize=ROUTER_CACHE_SIZE)
     def find_route_by_view_name(self, view_name, name=None):
         """Find a route in the router based on the specified view name.
@@ -442,7 +410,7 @@ class Router:
         # Check against known static routes
         route = self.routes_static.get(url)
         method_not_supported = MethodNotSupported(
-            "Method {} not allowed for URL {}".format(method, url),
+            f"Method {method} not allowed for URL {url}",
             method=method,
             allowed_methods=self.get_supported_methods(url),
         )
@@ -472,7 +440,7 @@ class Router:
                     # Route was found but the methods didn't match
                     if route_found:
                         raise method_not_supported
-                    raise NotFound("Requested URL {} not found".format(url))
+                    raise NotFound(f"Requested URL {url} not found")
 
         kwargs = {
             p.name: p.cast(value)

sanic/server.py

@@ -1,11 +1,12 @@
 import asyncio
+import multiprocessing
 import os
+import sys
 import traceback
 
 from collections import deque
 from functools import partial
 from inspect import isawaitable
-from multiprocessing import Process
 from signal import SIG_IGN, SIGINT, SIGTERM, Signals
 from signal import signal as signal_func
 from socket import SO_REUSEADDR, SOL_SOCKET, socket
@@ -14,7 +15,7 @@ from time import time
 from httptools import HttpRequestParser  # type: ignore
 from httptools.parser.errors import HttpParserError  # type: ignore
 
-from sanic.compat import Header
+from sanic.compat import Header, ctrlc_workaround_for_windows
 from sanic.exceptions import (
     HeaderExpectationFailed,
     InvalidUsage,
@@ -36,6 +37,8 @@ try:
 except ImportError:
     pass
 
+OS_IS_WINDOWS = os.name == "nt"
+
 
 class Signal:
     stopped = False
@@ -68,7 +71,6 @@ class HttpProtocol(asyncio.Protocol):
         "request_buffer_queue_size",
         "request_class",
         "is_request_stream",
-        "router",
         "error_handler",
         # enable or disable access log purpose
         "access_log",
@@ -86,7 +88,6 @@ class HttpProtocol(asyncio.Protocol):
         "_keep_alive",
         "_header_fragment",
         "state",
-        "_debug",
         "_body_chunks",
     )
 
@@ -95,46 +96,36 @@ class HttpProtocol(asyncio.Protocol):
         *,
         loop,
         app,
-        request_handler,
-        error_handler,
         signal=Signal(),
         connections=None,
-        request_timeout=60,
-        response_timeout=60,
-        keep_alive_timeout=5,
-        request_max_size=None,
-        request_buffer_queue_size=100,
-        request_class=None,
-        access_log=True,
-        keep_alive=True,
-        is_request_stream=False,
-        router=None,
         state=None,
-        debug=False,
+        **kwargs,
-        **kwargs
     ):
+        asyncio.set_event_loop(loop)
         self.loop = loop
+        deprecated_loop = self.loop if sys.version_info < (3, 7) else None
         self.app = app
         self.transport = None
         self.request = None
         self.parser = None
         self.url = None
         self.headers = None
-        self.router = router
         self.signal = signal
-        self.access_log = access_log
+        self.access_log = self.app.config.ACCESS_LOG
         self.connections = connections if connections is not None else set()
-        self.request_handler = request_handler
+        self.request_handler = self.app.handle_request
-        self.error_handler = error_handler
+        self.error_handler = self.app.error_handler
-        self.request_timeout = request_timeout
+        self.request_timeout = self.app.config.REQUEST_TIMEOUT
-        self.request_buffer_queue_size = request_buffer_queue_size
+        self.request_buffer_queue_size = (
-        self.response_timeout = response_timeout
+            self.app.config.REQUEST_BUFFER_QUEUE_SIZE
-        self.keep_alive_timeout = keep_alive_timeout
+        )
-        self.request_max_size = request_max_size
+        self.response_timeout = self.app.config.RESPONSE_TIMEOUT
-        self.request_class = request_class or Request
+        self.keep_alive_timeout = self.app.config.KEEP_ALIVE_TIMEOUT
-        self.is_request_stream = is_request_stream
+        self.request_max_size = self.app.config.REQUEST_MAX_SIZE
+        self.request_class = self.app.request_class or Request
+        self.is_request_stream = self.app.is_request_stream
         self._is_stream_handler = False
-        self._not_paused = asyncio.Event(loop=loop)
+        self._not_paused = asyncio.Event(loop=deprecated_loop)
         self._total_request_size = 0
         self._request_timeout_handler = None
         self._response_timeout_handler = None
@@ -143,12 +134,11 @@ class HttpProtocol(asyncio.Protocol):
         self._last_response_time = None
         self._request_handler_task = None
         self._request_stream_task = None
-        self._keep_alive = keep_alive
+        self._keep_alive = self.app.config.KEEP_ALIVE
         self._header_fragment = b""
         self.state = state if state else {}
         if "requests_count" not in self.state:
             self.state["requests_count"] = 0
-        self._debug = debug
         self._not_paused.set()
         self._body_chunks = deque()
 
@@ -276,7 +266,7 @@ class HttpProtocol(asyncio.Protocol):
             self.parser.feed_data(data)
         except HttpParserError:
             message = "Bad Request"
-            if self._debug:
+            if self.app.debug:
                 message += "\n" + traceback.format_exc()
             self.write_error(InvalidUsage(message))
 
@@ -324,7 +314,7 @@ class HttpProtocol(asyncio.Protocol):
             self.expect_handler()
 
         if self.is_request_stream:
-            self._is_stream_handler = self.router.is_stream_handler(
+            self._is_stream_handler = self.app.router.is_stream_handler(
                 self.request
             )
             if self._is_stream_handler:
@@ -343,9 +333,7 @@ class HttpProtocol(asyncio.Protocol):
                 self.transport.write(b"HTTP/1.1 100 Continue\r\n\r\n")
             else:
                 self.write_error(
-                    HeaderExpectationFailed(
+                    HeaderExpectationFailed(f"Unknown Expect: {expect}")
-                        "Unknown Expect: {expect}".format(expect=expect)
-                    )
                 )
 
     def on_body(self, body):
@@ -452,13 +440,9 @@ class HttpProtocol(asyncio.Protocol):
             extra["host"] = "UNKNOWN"
             if self.request is not None:
                 if self.request.ip:
-                    extra["host"] = "{0}:{1}".format(
+                    extra["host"] = f"{self.request.ip}:{self.request.port}"
-                        self.request.ip, self.request.port
-                    )
 
-                extra["request"] = "{0} {1}".format(
+                extra["request"] = f"{self.request.method} {self.request.url}"
-                    self.request.method, self.request.url
-                )
             else:
                 extra["request"] = "nil"
 
@@ -488,16 +472,14 @@ class HttpProtocol(asyncio.Protocol):
             )
             self.write_error(ServerError("Invalid response type"))
         except RuntimeError:
-            if self._debug:
+            if self.app.debug:
                 logger.error(
                     "Connection lost before response written @ %s",
                     self.request.ip,
                 )
             keep_alive = False
         except Exception as e:
-            self.bail_out(
+            self.bail_out(f"Writing response failed, connection closed {e!r}")
-                "Writing response failed, connection closed {}".format(repr(e))
-            )
         finally:
             if not keep_alive:
                 self.transport.close()
@@ -541,16 +523,14 @@ class HttpProtocol(asyncio.Protocol):
             )
             self.write_error(ServerError("Invalid response type"))
         except RuntimeError:
-            if self._debug:
+            if self.app.debug:
                 logger.error(
                     "Connection lost before response written @ %s",
                     self.request.ip,
                 )
             keep_alive = False
         except Exception as e:
-            self.bail_out(
+            self.bail_out(f"Writing response failed, connection closed {e!r}")
-                "Writing response failed, connection closed {}".format(repr(e))
-            )
         finally:
             if not keep_alive:
                 self.transport.close()
@@ -574,14 +554,14 @@ class HttpProtocol(asyncio.Protocol):
             version = self.request.version if self.request else "1.1"
             self.transport.write(response.output(version))
         except RuntimeError:
-            if self._debug:
+            if self.app.debug:
                 logger.error(
                     "Connection lost before error written @ %s",
                     self.request.ip if self.request else "Unknown",
                 )
         except Exception as e:
             self.bail_out(
-                "Writing error failed, connection closed {}".format(repr(e)),
+                f"Writing error failed, connection closed {e!r}",
                 from_error=True,
             )
         finally:
@@ -642,7 +622,7 @@ class HttpProtocol(asyncio.Protocol):
 
         :return: boolean - True if closed, false if staying open
         """
-        if not self.parser:
+        if not self.parser and self.transport is not None:
             self.transport.close()
             return True
         return False
@@ -731,6 +711,26 @@ class AsyncioServer:
             task = asyncio.ensure_future(coro, loop=self.loop)
             return task
 
+    def start_serving(self):
+        if self.server:
+            try:
+                return self.server.start_serving()
+            except AttributeError:
+                raise NotImplementedError(
+                    "server.start_serving not available in this version "
+                    "of asyncio or uvloop."
+                )
+
+    def serve_forever(self):
+        if self.server:
+            try:
+                return self.server.serve_forever()
+            except AttributeError:
+                raise NotImplementedError(
+                    "server.serve_forever not available in this version "
+                    "of asyncio or uvloop."
+                )
+
     def __await__(self):
         """Starts the asyncio server, returns AsyncServerCoro"""
         task = asyncio.ensure_future(self.serve_coro)
@@ -744,20 +744,12 @@ def serve(
     host,
     port,
     app,
-    request_handler,
-    error_handler,
     before_start=None,
     after_start=None,
     before_stop=None,
     after_stop=None,
-    debug=False,
-    request_timeout=60,
-    response_timeout=60,
-    keep_alive_timeout=5,
     ssl=None,
     sock=None,
-    request_max_size=None,
-    request_buffer_queue_size=100,
     reuse_port=False,
     loop=None,
     protocol=HttpProtocol,
@@ -767,25 +759,13 @@ def serve(
     run_async=False,
     connections=None,
     signal=Signal(),
-    request_class=None,
-    access_log=True,
-    keep_alive=True,
-    is_request_stream=False,
-    router=None,
-    websocket_max_size=None,
-    websocket_max_queue=None,
-    websocket_read_limit=2 ** 16,
-    websocket_write_limit=2 ** 16,
     state=None,
-    graceful_shutdown_timeout=15.0,
     asyncio_server_kwargs=None,
 ):
     """Start asynchronous HTTP Server on an individual process.
 
     :param host: Address to host on
     :param port: Port to host on
-    :param request_handler: Sanic request handler with middleware
-    :param error_handler: Sanic error handler with middleware
     :param before_start: function to be executed before the server starts
                          listening. Takes arguments `app` instance and `loop`
     :param after_start: function to be executed after the server starts
@@ -796,35 +776,12 @@ def serve(
     :param after_stop: function to be executed when a stop signal is
                        received after it is respected. Takes arguments
                        `app` instance and `loop`
-    :param debug: enables debug output (slows server)
-    :param request_timeout: time in seconds
-    :param response_timeout: time in seconds
-    :param keep_alive_timeout: time in seconds
     :param ssl: SSLContext
     :param sock: Socket for the server to accept connections from
-    :param request_max_size: size in bytes, `None` for no limit
     :param reuse_port: `True` for multiple workers
     :param loop: asyncio compatible event loop
-    :param protocol: subclass of asyncio protocol class
     :param run_async: bool: Do not create a new event loop for the server,
                       and return an AsyncServer object rather than running it
-    :param request_class: Request class to use
-    :param access_log: disable/enable access log
-    :param websocket_max_size: enforces the maximum size for
-                               incoming messages in bytes.
-    :param websocket_max_queue: sets the maximum length of the queue
-                                that holds incoming messages.
-    :param websocket_read_limit: sets the high-water limit of the buffer for
-                                 incoming bytes, the low-water limit is half
-                                 the high-water limit.
-    :param websocket_write_limit: sets the high-water limit of the buffer for
-                                  outgoing bytes, the low-water limit is a
-                                  quarter of the high-water limit.
-    :param is_request_stream: disable/enable Request.stream
-    :param request_buffer_queue_size: streaming request buffer queue size
-    :param router: Router object
-    :param graceful_shutdown_timeout: How long take to Force close non-idle
-                                      connection
     :param asyncio_server_kwargs: key-value args for asyncio/uvloop
                                   create_server method
     :return: Nothing
@@ -834,8 +791,8 @@ def serve(
         loop = asyncio.new_event_loop()
         asyncio.set_event_loop(loop)
 
-    if debug:
+    if app.debug:
-        loop.set_debug(debug)
+        loop.set_debug(app.debug)
 
     app.asgi = False
 
@@ -846,24 +803,7 @@ def serve(
         connections=connections,
         signal=signal,
         app=app,
-        request_handler=request_handler,
-        error_handler=error_handler,
-        request_timeout=request_timeout,
-        response_timeout=response_timeout,
-        keep_alive_timeout=keep_alive_timeout,
-        request_max_size=request_max_size,
-        request_buffer_queue_size=request_buffer_queue_size,
-        request_class=request_class,
-        access_log=access_log,
-        keep_alive=keep_alive,
-        is_request_stream=is_request_stream,
-        router=router,
-        websocket_max_size=websocket_max_size,
-        websocket_max_queue=websocket_max_queue,
-        websocket_read_limit=websocket_read_limit,
-        websocket_write_limit=websocket_write_limit,
         state=state,
-        debug=debug,
     )
     asyncio_server_kwargs = (
         asyncio_server_kwargs if asyncio_server_kwargs else {}
@@ -876,17 +816,17 @@ def serve(
         reuse_port=reuse_port,
         sock=sock,
         backlog=backlog,
-        **asyncio_server_kwargs
+        **asyncio_server_kwargs,
     )
 
     if run_async:
         return AsyncioServer(
-            loop,
+            loop=loop,
-            server_coroutine,
+            serve_coro=server_coroutine,
-            connections,
+            connections=connections,
-            after_start,
+            after_start=after_start,
-            before_stop,
+            before_stop=before_stop,
-            after_stop,
+            after_stop=after_stop,
         )
 
     trigger_events(before_start, loop)
@@ -905,15 +845,11 @@ def serve(
 
     # Register signals for graceful termination
     if register_sys_signals:
-        _singals = (SIGTERM,) if run_multiple else (SIGINT, SIGTERM)
+        if OS_IS_WINDOWS:
-        for _signal in _singals:
+            ctrlc_workaround_for_windows(app)
-            try:
+        else:
-                loop.add_signal_handler(_signal, loop.stop)
+            for _signal in [SIGTERM] if run_multiple else [SIGINT, SIGTERM]:
-            except NotImplementedError:
+                loop.add_signal_handler(_signal, app.stop)
-                logger.warning(
-                    "Sanic tried to use loop.add_signal_handler "
-                    "but it is not implemented on this platform."
-                )
     pid = os.getpid()
     try:
         logger.info("Starting worker [%s]", pid)
@@ -937,8 +873,9 @@ def serve(
         # We should provide graceful_shutdown_timeout,
         # instead of letting connection hangs forever.
         # Let's roughly calcucate time.
+        graceful = app.config.GRACEFUL_SHUTDOWN_TIMEOUT
         start_shutdown = 0
-        while connections and (start_shutdown < graceful_shutdown_timeout):
+        while connections and (start_shutdown < graceful):
             loop.run_until_complete(asyncio.sleep(0.1))
             start_shutdown = start_shutdown + 0.1
 
@@ -951,7 +888,7 @@ def serve(
             else:
                 conn.close()
 
-        _shutdown = asyncio.gather(*coros, loop=loop)
+        _shutdown = asyncio.gather(*coros)
         loop.run_until_complete(_shutdown)
 
         trigger_events(after_stop, loop)
@@ -990,9 +927,10 @@ def serve_multiple(server_settings, workers):
 
     signal_func(SIGINT, lambda s, f: sig_handler(s, f))
     signal_func(SIGTERM, lambda s, f: sig_handler(s, f))
+    mp = multiprocessing.get_context("fork")
 
     for _ in range(workers):
-        process = Process(target=serve, kwargs=server_settings)
+        process = mp.Process(target=serve, kwargs=server_settings)
         process.daemon = True
         process.start()
         processes.append(process)

sanic/static.py

@@ -4,8 +4,7 @@ from re import sub
 from time import gmtime, strftime
 from urllib.parse import unquote
 
-from aiofiles.os import stat  # type: ignore
+from sanic.compat import stat_async
-
 from sanic.exceptions import (
     ContentRangeError,
     FileNotFound,
@@ -84,7 +83,7 @@ def register(
             # and it has not been modified since
             stats = None
             if use_modified_since:
-                stats = await stat(file_path)
+                stats = await stat_async(file_path)
                 modified_since = strftime(
                     "%a, %d %b %Y %H:%M:%S GMT", gmtime(stats.st_mtime)
                 )
@@ -95,7 +94,7 @@ def register(
             if use_content_range:
                 _range = None
                 if not stats:
-                    stats = await stat(file_path)
+                    stats = await stat_async(file_path)
                 headers["Accept-Ranges"] = "bytes"
                 headers["Content-Length"] = str(stats.st_size)
                 if request.method != "HEAD":
@@ -120,7 +119,7 @@ def register(
                         threshold = 1024 * 1024
 
                     if not stats:
-                        stats = await stat(file_path)
+                        stats = await stat_async(file_path)
                     if stats.st_size >= threshold:
                         return await file_stream(
                             file_path, headers=headers, _range=_range
@@ -135,7 +134,7 @@ def register(
 
     # special prefix for static files
     if not name.startswith("_static_"):
-        name = "_static_{}".format(name)
+        name = f"_static_{name}"
 
     app.route(
         uri,

sanic/testing.py

@@ -12,7 +12,7 @@ from sanic.response import text
 
 ASGI_HOST = "mockserver"
 HOST = "127.0.0.1"
-PORT = 42101
+PORT = None
 
 
 class SanicTestClient:
@@ -23,7 +23,7 @@ class SanicTestClient:
         self.host = host
 
     def get_new_session(self):
-        return httpx.Client()
+        return httpx.AsyncClient(verify=False)
 
     async def _local_request(self, method, url, *args, **kwargs):
         logger.info(url)
@@ -38,20 +38,22 @@ class SanicTestClient:
 
                 try:
                     response = await getattr(session, method.lower())(
-                        url, verify=False, *args, **kwargs
+                        url, *args, **kwargs
                     )
                 except NameError:
                     raise Exception(response.status_code)
 
+                response.body = await response.aread()
+                response.status = response.status_code
+                response.content_type = response.headers.get("content-type")
+
+                # response can be decoded as json after response._content
+                # is set by response.aread()
                 try:
                     response.json = response.json()
                 except (JSONDecodeError, UnicodeDecodeError):
                     response.json = None
 
-                response.body = await response.read()
-                response.status = response.status_code
-                response.content_type = response.headers.get("content-type")
-
                 if raw_cookies:
                     response.raw_cookies = {}
 
@@ -93,7 +95,7 @@ class SanicTestClient:
 
         if self.port:
             server_kwargs = dict(
-                host=host or self.host, port=self.port, **server_kwargs
+                host=host or self.host, port=self.port, **server_kwargs,
             )
             host, port = host or self.host, self.port
         else:
@@ -101,17 +103,19 @@ class SanicTestClient:
             sock.bind((host or self.host, 0))
             server_kwargs = dict(sock=sock, **server_kwargs)
             host, port = sock.getsockname()
+            self.port = port
 
         if uri.startswith(
             ("http:", "https:", "ftp:", "ftps://", "//", "ws:", "wss:")
         ):
             url = uri
         else:
-            uri = uri if uri.startswith("/") else "/{uri}".format(uri=uri)
+            uri = uri if uri.startswith("/") else f"/{uri}"
             scheme = "ws" if method == "websocket" else "http"
-            url = "{scheme}://{host}:{port}{uri}".format(
+            url = f"{scheme}://{host}:{port}{uri}"
-                scheme=scheme, host=host, port=port, uri=uri
+        # Tests construct URLs using PORT = None, which means random port not
-            )
+        # known until this function is called, so fix that here
+        url = url.replace(":None/", f":{port}/")
 
         @self.app.listener("after_server_start")
         async def _collect_response(sanic, loop):
@@ -129,7 +133,7 @@ class SanicTestClient:
         self.app.listeners["after_server_start"].pop()
 
         if exceptions:
-            raise ValueError("Exception during request: {}".format(exceptions))
+            raise ValueError(f"Exception during request: {exceptions}")
 
         if gather_request:
             try:
@@ -137,17 +141,13 @@ class SanicTestClient:
                 return request, response
             except BaseException:  # noqa
                 raise ValueError(
-                    "Request and response object expected, got ({})".format(
+                    f"Request and response object expected, got ({results})"
-                        results
-                    )
                 )
         else:
             try:
                 return results[-1]
             except BaseException:  # noqa
-                raise ValueError(
+                raise ValueError(f"Request object expected, got ({results})")
-                    "Request object expected, got ({})".format(results)
-                )
 
     def get(self, *args, **kwargs):
         return self._sanic_endpoint_test("get", *args, **kwargs)
@@ -185,15 +185,15 @@ async def app_call_with_return(self, scope, receive, send):
     return await asgi_app()
 
 
-class SanicASGIDispatch(httpx.dispatch.ASGIDispatch):
+class SanicASGIDispatch(httpx.ASGIDispatch):
     pass
 
 
-class SanicASGITestClient(httpx.Client):
+class SanicASGITestClient(httpx.AsyncClient):
     def __init__(
         self,
         app,
-        base_url: str = "http://{}".format(ASGI_HOST),
+        base_url: str = f"http://{ASGI_HOST}",
         suppress_exceptions: bool = False,
     ) -> None:
         app.__class__.__call__ = app_call_with_return
@@ -201,7 +201,7 @@ class SanicASGITestClient(httpx.Client):
 
         self.app = app
 
-        dispatch = SanicASGIDispatch(app=app, client=(ASGI_HOST, PORT))
+        dispatch = SanicASGIDispatch(app=app, client=(ASGI_HOST, PORT or 0))
         super().__init__(dispatch=dispatch, base_url=base_url)
 
         self.last_request = None
@@ -224,7 +224,7 @@ class SanicASGITestClient(httpx.Client):
     async def websocket(self, uri, subprotocols=None, *args, **kwargs):
         scheme = "ws"
         path = uri
-        root_path = "{}://{}".format(scheme, ASGI_HOST)
+        root_path = f"{scheme}://{ASGI_HOST}"
 
         headers = kwargs.get("headers", {})
         headers.setdefault("connection", "upgrade")

sanic/views.py

@@ -96,14 +96,10 @@ class CompositionView:
             handler.is_stream = stream
         for method in methods:
             if method not in HTTP_METHODS:
-                raise InvalidUsage(
+                raise InvalidUsage(f"{method} is not a valid HTTP method.")
-                    "{} is not a valid HTTP method.".format(method)
-                )
 
             if method in self.handlers:
-                raise InvalidUsage(
+                raise InvalidUsage(f"Method {method} is already registered.")
-                    "Method {} is already registered.".format(method)
-                )
             self.handlers[method] = handler
 
     def __call__(self, request, *args, **kwargs):

setup.py

@@ -68,6 +68,7 @@ setup_kwargs = {
         "License :: OSI Approved :: MIT License",
         "Programming Language :: Python :: 3.6",
         "Programming Language :: Python :: 3.7",
+        "Programming Language :: Python :: 3.8",
     ],
 }
 
@@ -84,7 +85,7 @@ requirements = [
     "aiofiles>=0.3.0",
     "websockets>=7.0,<9.0",
     "multidict>=4.0,<5.0",
-    "httpx==0.9.3",
+    "httpx==0.11.1",
 ]
 
 tests_require = [

tests/conftest.py

@@ -103,7 +103,7 @@ def sanic_router():
         for method, route in route_details:
             try:
                 router._add(
-                    uri="/{}".format(route),
+                    uri=f"/{route}",
                     methods=frozenset({method}),
                     host="localhost",
                     handler=_handler,

tests/test_app.py

@@ -6,6 +6,7 @@ from inspect import isawaitable
 
 import pytest
 
+from sanic import Sanic
 from sanic.exceptions import SanicException
 from sanic.response import text
 
@@ -44,16 +45,35 @@ def test_create_asyncio_server(app):
 @pytest.mark.skipif(
     sys.version_info < (3, 7), reason="requires python3.7 or higher"
 )
-def test_asyncio_server_start_serving(app):
+def test_asyncio_server_no_start_serving(app):
     if not uvloop_installed():
         loop = asyncio.get_event_loop()
         asyncio_srv_coro = app.create_server(
+            port=43123,
             return_asyncio_server=True,
             asyncio_server_kwargs=dict(start_serving=False),
         )
         srv = loop.run_until_complete(asyncio_srv_coro)
         assert srv.is_serving() is False
 
+@pytest.mark.skipif(
+    sys.version_info < (3, 7), reason="requires python3.7 or higher"
+)
+def test_asyncio_server_start_serving(app):
+    if not uvloop_installed():
+        loop = asyncio.get_event_loop()
+        asyncio_srv_coro = app.create_server(
+            port=43124,
+            return_asyncio_server=True,
+            asyncio_server_kwargs=dict(start_serving=False),
+        )
+        srv = loop.run_until_complete(asyncio_srv_coro)
+        assert srv.is_serving() is False
+        loop.run_until_complete(srv.start_serving())
+        assert srv.is_serving() is True
+        wait_close = srv.close()
+        loop.run_until_complete(wait_close)
+        # Looks like we can't easily test `serve_forever()`
 
 def test_app_loop_not_running(app):
     with pytest.raises(SanicException) as excinfo:
@@ -105,10 +125,7 @@ def test_app_handle_request_handler_is_none(app, monkeypatch):
 
     request, response = app.test_client.get("/test")
 
-    assert (
+    assert "'None' was returned while requesting a handler from the router" in response.text
-        response.text
-        == "Error: 'None' was returned while requesting a handler from the router"
-    )
 
 
 @pytest.mark.parametrize("websocket_enabled", [True, False])
@@ -166,9 +183,7 @@ def test_handle_request_with_nested_exception_debug(app, monkeypatch):
     request, response = app.test_client.get("/", debug=True)
     assert response.status == 500
     assert response.text.startswith(
-        "Error while handling error: {}\nStack: Traceback (most recent call last):\n".format(
+        f"Error while handling error: {err_msg}\nStack: Traceback (most recent call last):\n"
-            err_msg
-        )
     )
 
 
@@ -188,10 +203,17 @@ def test_handle_request_with_nested_sanic_exception(app, monkeypatch, caplog):
 
     with caplog.at_level(logging.ERROR):
         request, response = app.test_client.get("/")
+    port = request.server_port
+    assert port > 0
     assert response.status == 500
-    assert response.text == "Error: Mock SanicException"
+    assert "Mock SanicException" in response.text
     assert (
         "sanic.root",
         logging.ERROR,
-        "Exception occurred while handling uri: 'http://127.0.0.1:42101/'",
+        f"Exception occurred while handling uri: 'http://127.0.0.1:{port}/'",
     ) in caplog.record_tuples
+
+
+def test_app_name_required():
+    with pytest.deprecated_call():
+        Sanic()

tests/test_asgi.py

@@ -1,4 +1,5 @@
 import asyncio
+import sys
 
 from collections import deque, namedtuple
 
@@ -81,7 +82,12 @@ def test_listeners_triggered(app):
     with pytest.warns(UserWarning):
         server.run()
 
-    for task in asyncio.Task.all_tasks():
+    all_tasks = (
+        asyncio.Task.all_tasks()
+        if sys.version_info < (3, 7) else
+        asyncio.all_tasks(asyncio.get_event_loop())
+    )
+    for task in all_tasks:
         task.cancel()
 
     assert before_server_start
@@ -126,7 +132,12 @@ def test_listeners_triggered_async(app):
     with pytest.warns(UserWarning):
         server.run()
 
-    for task in asyncio.Task.all_tasks():
+    all_tasks = (
+        asyncio.Task.all_tasks()
+        if sys.version_info < (3, 7) else
+        asyncio.all_tasks(asyncio.get_event_loop())
+    )
+    for task in all_tasks:
         task.cancel()
 
     assert before_server_start
@@ -221,7 +232,7 @@ async def test_request_class_custom():
     class MyCustomRequest(Request):
         pass
 
-    app = Sanic(request_class=MyCustomRequest)
+    app = Sanic(name=__name__, request_class=MyCustomRequest)
 
     @app.get("/custom")
     def custom_request(request):

tests/test_bad_request.py

@@ -18,4 +18,4 @@ def test_bad_request_response(app):
 
     app.run(host="127.0.0.1", port=42101, debug=False)
     assert lines[0] == b"HTTP/1.1 400 Bad Request\r\n"
-    assert lines[-1] == b"Error: Bad Request"
+    assert b"Bad Request" in lines[-1]

tests/test_blueprint_group.py

@@ -40,9 +40,9 @@ def test_bp_group_with_additional_route_params(app: Sanic):
     )
     def blueprint_2_named_method(request: Request, param):
         if request.method == "DELETE":
-            return text("DELETE_{}".format(param))
+            return text(f"DELETE_{param}")
         elif request.method == "PATCH":
-            return text("PATCH_{}".format(param))
+            return text(f"PATCH_{param}")
 
     blueprint_group = Blueprint.group(
         blueprint_1, blueprint_2, url_prefix="/api"

tests/test_blueprints.py

@@ -46,19 +46,19 @@ def test_versioned_routes_get(app, method):
     func = getattr(bp, method)
     if callable(func):
 
-        @func("/{}".format(method), version=1)
+        @func(f"/{method}", version=1)
         def handler(request):
             return text("OK")
 
     else:
         print(func)
-        raise Exception("{} is not callable".format(func))
+        raise Exception(f"{func} is not callable")
 
     app.blueprint(bp)
 
     client_method = getattr(app.test_client, method)
 
-    request, response = client_method("/v1/{}".format(method))
+    request, response = client_method(f"/v1/{method}")
     assert response.status == 200
 
 
@@ -253,7 +253,7 @@ def test_several_bp_with_host(app):
 
 
 def test_bp_middleware(app):
-    blueprint = Blueprint("test_middleware")
+    blueprint = Blueprint("test_bp_middleware")
 
     @blueprint.middleware("response")
     async def process_response(request, response):
@@ -270,6 +270,38 @@ def test_bp_middleware(app):
     assert response.status == 200
     assert response.text == "FAIL"
 
+def test_bp_middleware_order(app):
+    blueprint = Blueprint("test_bp_middleware_order")
+    order = list()
+    @blueprint.middleware("request")
+    def mw_1(request):
+        order.append(1)
+    @blueprint.middleware("request")
+    def mw_2(request):
+        order.append(2)
+    @blueprint.middleware("request")
+    def mw_3(request):
+        order.append(3)
+    @blueprint.middleware("response")
+    def mw_4(request, response):
+        order.append(6)
+    @blueprint.middleware("response")
+    def mw_5(request, response):
+        order.append(5)
+    @blueprint.middleware("response")
+    def mw_6(request, response):
+        order.append(4)
+
+    @blueprint.route("/")
+    def process_response(request):
+        return text("OK")
+
+    app.blueprint(blueprint)
+    order.clear()
+    request, response = app.test_client.get("/")
+
+    assert response.status == 200
+    assert order == [1, 2, 3, 4, 5, 6]
 
 def test_bp_exception_handler(app):
     blueprint = Blueprint("test_middleware")
@@ -554,7 +586,7 @@ def test_bp_group_with_default_url_prefix(app):
 
     resource_id = str(uuid4())
     request, response = app.test_client.get(
-        "/api/v1/resources/{0}".format(resource_id)
+        f"/api/v1/resources/{resource_id}"
     )
     assert response.json == {"resource_id": resource_id}
 
@@ -669,9 +701,9 @@ def test_duplicate_blueprint(app):
         app.blueprint(bp1)
 
     assert str(excinfo.value) == (
-        'A blueprint with the name "{}" is already registered.  '
+        f'A blueprint with the name "{bp_name}" is already registered.  '
         "Blueprint names must be unique."
-    ).format(bp_name)
+    )
 
 
 @pytest.mark.parametrize("debug", [True, False, None])

tests/test_config.py

@@ -44,42 +44,42 @@ def test_load_from_object_string_exception(app):
 
 def test_auto_load_env():
     environ["SANIC_TEST_ANSWER"] = "42"
-    app = Sanic()
+    app = Sanic(name=__name__)
     assert app.config.TEST_ANSWER == 42
     del environ["SANIC_TEST_ANSWER"]
 
 
 def test_auto_load_bool_env():
     environ["SANIC_TEST_ANSWER"] = "True"
-    app = Sanic()
+    app = Sanic(name=__name__)
     assert app.config.TEST_ANSWER == True
     del environ["SANIC_TEST_ANSWER"]
 
 
 def test_dont_load_env():
     environ["SANIC_TEST_ANSWER"] = "42"
-    app = Sanic(load_env=False)
+    app = Sanic(name=__name__, load_env=False)
     assert getattr(app.config, "TEST_ANSWER", None) is None
     del environ["SANIC_TEST_ANSWER"]
 
 
 def test_load_env_prefix():
     environ["MYAPP_TEST_ANSWER"] = "42"
-    app = Sanic(load_env="MYAPP_")
+    app = Sanic(name=__name__, load_env="MYAPP_")
     assert app.config.TEST_ANSWER == 42
     del environ["MYAPP_TEST_ANSWER"]
 
 
 def test_load_env_prefix_float_values():
     environ["MYAPP_TEST_ROI"] = "2.3"
-    app = Sanic(load_env="MYAPP_")
+    app = Sanic(name=__name__, load_env="MYAPP_")
     assert app.config.TEST_ROI == 2.3
     del environ["MYAPP_TEST_ROI"]
 
 
 def test_load_env_prefix_string_value():
     environ["MYAPP_TEST_TOKEN"] = "somerandomtesttoken"
-    app = Sanic(load_env="MYAPP_")
+    app = Sanic(name=__name__, load_env="MYAPP_")
     assert app.config.TEST_TOKEN == "somerandomtesttoken"
     del environ["MYAPP_TEST_TOKEN"]
 

tests/test_cookies.py

@@ -15,7 +15,8 @@ from sanic.response import text
 def test_cookies(app):
     @app.route("/")
     def handler(request):
-        response = text("Cookies are: {}".format(request.cookies["test"]))
+        cookie_value = request.cookies["test"]
+        response = text(f"Cookies are: {cookie_value}")
         response.cookies["right_back"] = "at you"
         return response
 
@@ -31,7 +32,8 @@ def test_cookies(app):
 async def test_cookies_asgi(app):
     @app.route("/")
     def handler(request):
-        response = text("Cookies are: {}".format(request.cookies["test"]))
+        cookie_value = request.cookies["test"]
+        response = text(f"Cookies are: {cookie_value}")
         response.cookies["right_back"] = "at you"
         return response
 
@@ -52,7 +54,7 @@ def test_false_cookies_encoded(app, httponly, expected):
         response = text("hello cookies")
         response.cookies["hello"] = "world"
         response.cookies["hello"]["httponly"] = httponly
-        return text(response.cookies["hello"].encode("utf8"))
+        return text(response.cookies["hello"].encode("utf8").decode())
 
     request, response = app.test_client.get("/")
 
@@ -78,7 +80,8 @@ def test_false_cookies(app, httponly, expected):
 def test_http2_cookies(app):
     @app.route("/")
     async def handler(request):
-        response = text("Cookies are: {}".format(request.cookies["test"]))
+        cookie_value = request.cookies["test"]
+        response = text(f"Cookies are: {cookie_value}")
         return response
 
     headers = {"cookie": "test=working!"}

tests/test_create_task.py

@@ -17,12 +17,12 @@ def test_create_task(app):
 
     @app.route("/early")
     def not_set(request):
-        return text(e.is_set())
+        return text(str(e.is_set()))
 
     @app.route("/late")
     async def set(request):
         await asyncio.sleep(0.1)
-        return text(e.is_set())
+        return text(str(e.is_set()))
 
     request, response = app.test_client.get("/early")
     assert response.body == b"False"

tests/test_custom_request.py

@@ -20,7 +20,7 @@ class CustomRequest(Request):
 
 
 def test_custom_request():
-    app = Sanic(request_class=CustomRequest)
+    app = Sanic(name=__name__, request_class=CustomRequest)
 
     @app.route("/post", methods=["POST"])
     async def post_handler(request):

tests/test_exceptions.py

@@ -172,7 +172,7 @@ def test_handled_unhandled_exception(exception_app):
     request, response = exception_app.test_client.get("/divide_by_zero")
     assert response.status == 500
     soup = BeautifulSoup(response.body, "html.parser")
-    assert soup.h1.text == "Internal Server Error"
+    assert "Internal Server Error" in soup.h1.text
 
     message = " ".join(soup.p.text.split())
     assert message == (
@@ -218,4 +218,4 @@ def test_abort(exception_app):
 
     request, response = exception_app.test_client.get("/abort/message")
     assert response.status == 500
-    assert response.text == "Error: Abort"
+    assert "Abort" in response.text

tests/test_exceptions_handler.py

@@ -43,7 +43,7 @@ def handler_6(request, arg):
     try:
         foo = 1 / arg
     except Exception as e:
-        raise e from ValueError("{}".format(arg))
+        raise e from ValueError(f"{arg}")
     return text(foo)
 
 
@@ -86,7 +86,7 @@ def test_html_traceback_output_in_debug_mode():
 
     summary_text = " ".join(soup.select(".summary")[0].text.split())
     assert (
-        "NameError: name 'bar' " "is not defined while handling path /4"
+        "NameError: name 'bar' is not defined while handling path /4"
     ) == summary_text
 
 
@@ -112,7 +112,7 @@ def test_chained_exception_handler():
 
     summary_text = " ".join(soup.select(".summary")[0].text.split())
     assert (
-        "ZeroDivisionError: division by zero " "while handling path /6/0"
+        "ZeroDivisionError: division by zero while handling path /6/0"
     ) == summary_text
 
 

tests/test_keep_alive_timeout.py

@@ -7,17 +7,33 @@ import httpx
 
 from sanic import Sanic, server
 from sanic.response import text
-from sanic.testing import HOST, PORT, SanicTestClient
+from sanic.testing import HOST, SanicTestClient
-
 
 CONFIG_FOR_TESTS = {"KEEP_ALIVE_TIMEOUT": 2, "KEEP_ALIVE": True}
 
 old_conn = None
+PORT = 42101  # test_keep_alive_timeout_reuse doesn't work with random port
 
 
 class ReusableSanicConnectionPool(
     httpx.dispatch.connection_pool.ConnectionPool
 ):
+    @property
+    def cert(self):
+        return self.ssl.cert
+
+    @property
+    def verify(self):
+        return self.ssl.verify
+
+    @property
+    def trust_env(self):
+        return self.ssl.trust_env
+
+    @property
+    def http2(self):
+        return self.ssl.http2
+
     async def acquire_connection(self, origin, timeout):
         global old_conn
         connection = self.pop_connection(origin)
@@ -26,14 +42,17 @@ class ReusableSanicConnectionPool(
             pool_timeout = None if timeout is None else timeout.pool_timeout
 
             await self.max_connections.acquire(timeout=pool_timeout)
+            ssl_config = httpx.config.SSLConfig(
+                cert=self.cert,
+                verify=self.verify,
+                trust_env=self.trust_env,
+                http2=self.http2
+            )
             connection = httpx.dispatch.connection.HTTPConnection(
                 origin,
-                verify=self.verify,
+                ssl=ssl_config,
-                cert=self.cert,
-                http2=self.http2,
                 backend=self.backend,
                 release_func=self.release_connection,
-                trust_env=self.trust_env,
                 uds=self.uds,
             )
 
@@ -49,7 +68,7 @@ class ReusableSanicConnectionPool(
         return connection
 
 
-class ResusableSanicSession(httpx.Client):
+class ResusableSanicSession(httpx.AsyncClient):
     def __init__(self, *args, **kwargs) -> None:
         dispatch = ReusableSanicConnectionPool()
         super().__init__(dispatch=dispatch, *args, **kwargs)
@@ -97,11 +116,9 @@ class ReuseableSanicTestClient(SanicTestClient):
         ):
             url = uri
         else:
-            uri = uri if uri.startswith("/") else "/{uri}".format(uri=uri)
+            uri = uri if uri.startswith("/") else f"/{uri}"
             scheme = "http"
-            url = "{scheme}://{host}:{port}{uri}".format(
+            url = f"{scheme}://{HOST}:{PORT}{uri}"
-                scheme=scheme, host=HOST, port=PORT, uri=uri
-            )
 
         @self.app.listener("after_server_start")
         async def _collect_response(loop):
@@ -134,7 +151,7 @@ class ReuseableSanicTestClient(SanicTestClient):
         self.app.listeners["after_server_start"].pop()
 
         if exceptions:
-            raise ValueError("Exception during request: {}".format(exceptions))
+            raise ValueError(f"Exception during request: {exceptions}")
 
         if gather_request:
             self.app.request_middleware.pop()
@@ -143,16 +160,14 @@ class ReuseableSanicTestClient(SanicTestClient):
                 return request, response
             except Exception:
                 raise ValueError(
-                    "Request and response object expected, got ({})".format(
+                    f"Request and response object expected, got ({results})"
-                        results
-                    )
                 )
         else:
             try:
                 return results[-1]
             except Exception:
                 raise ValueError(
-                    "Request object expected, got ({})".format(results)
+                    f"Request object expected, got ({results})"
                 )
 
     def kill_server(self):
@@ -163,7 +178,7 @@ class ReuseableSanicTestClient(SanicTestClient):
                 self._server = None
 
             if self._session:
-                self._loop.run_until_complete(self._session.close())
+                self._loop.run_until_complete(self._session.aclose())
                 self._session = None
 
         except Exception as e3:
@@ -182,7 +197,7 @@ class ReuseableSanicTestClient(SanicTestClient):
             self._session = self.get_new_session()
         try:
             response = await getattr(self._session, method.lower())(
-                url, verify=False, timeout=request_keepalive, *args, **kwargs
+                url, timeout=request_keepalive, *args, **kwargs
             )
         except NameError:
             raise Exception(response.status_code)
@@ -192,7 +207,7 @@ class ReuseableSanicTestClient(SanicTestClient):
         except (JSONDecodeError, UnicodeDecodeError):
             response.json = None
 
-        response.body = await response.read()
+        response.body = await response.aread()
         response.status = response.status_code
         response.content_type = response.headers.get("content-type")
 

tests/test_logging.py

@@ -1,4 +1,5 @@
 import logging
+import os
 import uuid
 
 from importlib import reload
@@ -12,6 +13,7 @@ import sanic
 from sanic import Sanic
 from sanic.log import LOGGING_CONFIG_DEFAULTS, logger
 from sanic.response import text
+from sanic.testing import SanicTestClient
 
 
 logging_format = """module: %(module)s; \
@@ -127,7 +129,7 @@ def test_log_connection_lost(app, debug, monkeypatch):
 def test_logger(caplog):
     rand_string = str(uuid.uuid4())
 
-    app = Sanic()
+    app = Sanic(name=__name__)
 
     @app.get("/")
     def log_info(request):
@@ -137,15 +139,67 @@ def test_logger(caplog):
     with caplog.at_level(logging.INFO):
         request, response = app.test_client.get("/")
 
+    port = request.server_port
+
+    # Note: testing with random port doesn't show the banner because it doesn't
+    # define host and port. This test supports both modes.
+    if caplog.record_tuples[0] == (
+        "sanic.root",
+        logging.INFO,
+        f"Goin' Fast @ http://127.0.0.1:{port}",
+    ):
+        caplog.record_tuples.pop(0)
+
     assert caplog.record_tuples[0] == (
         "sanic.root",
         logging.INFO,
-        "Goin' Fast @ http://127.0.0.1:42101",
+        f"http://127.0.0.1:{port}/",
+    )
+    assert caplog.record_tuples[1] == ("sanic.root", logging.INFO, rand_string)
+    assert caplog.record_tuples[-1] == (
+        "sanic.root",
+        logging.INFO,
+        "Server Stopped",
+    )
+
+
+def test_logger_static_and_secure(caplog):
+    # Same as test_logger, except for more coverage:
+    # - test_client initialised separately for static port
+    # - using ssl
+    rand_string = str(uuid.uuid4())
+
+    app = Sanic(name=__name__)
+
+    @app.get("/")
+    def log_info(request):
+        logger.info(rand_string)
+        return text("hello")
+
+    current_dir = os.path.dirname(os.path.realpath(__file__))
+    ssl_cert = os.path.join(current_dir, "certs/selfsigned.cert")
+    ssl_key = os.path.join(current_dir, "certs/selfsigned.key")
+
+    ssl_dict = {"cert": ssl_cert, "key": ssl_key}
+
+    test_client = SanicTestClient(app, port=42101)
+    with caplog.at_level(logging.INFO):
+        request, response = test_client.get(
+            f"https://127.0.0.1:{test_client.port}/",
+            server_kwargs=dict(ssl=ssl_dict),
+        )
+
+    port = test_client.port
+
+    assert caplog.record_tuples[0] == (
+        "sanic.root",
+        logging.INFO,
+        f"Goin' Fast @ https://127.0.0.1:{port}",
     )
     assert caplog.record_tuples[1] == (
         "sanic.root",
         logging.INFO,
-        "http://127.0.0.1:42101/",
+        f"https://127.0.0.1:{port}/",
     )
     assert caplog.record_tuples[2] == ("sanic.root", logging.INFO, rand_string)
     assert caplog.record_tuples[-1] == (

tests/test_logo.py

@@ -49,10 +49,10 @@ def test_logo_false(app, caplog):
     loop.run_until_complete(_server.wait_closed())
     app.stop()
 
+    banner, port = caplog.record_tuples[ROW][2].rsplit(":", 1)
     assert caplog.record_tuples[ROW][1] == logging.INFO
-    assert caplog.record_tuples[ROW][
+    assert banner == "Goin' Fast @ http://127.0.0.1"
-        2
+    assert int(port) > 0
-    ] == "Goin' Fast @ http://127.0.0.1:{}".format(PORT)
 
 
 def test_logo_true(app, caplog):

tests/test_middleware.py

@@ -2,7 +2,7 @@ import logging
 
 from asyncio import CancelledError
 
-from sanic.exceptions import NotFound
+from sanic.exceptions import NotFound, SanicException
 from sanic.request import Request
 from sanic.response import HTTPResponse, text
 
@@ -93,7 +93,7 @@ def test_middleware_response_raise_cancelled_error(app, caplog):
             "sanic.root",
             logging.ERROR,
             "Exception occurred while handling uri: 'http://127.0.0.1:42101/'",
-        ) in caplog.record_tuples
+        ) not in caplog.record_tuples
 
 
 def test_middleware_response_raise_exception(app, caplog):
@@ -102,14 +102,16 @@ def test_middleware_response_raise_exception(app, caplog):
         raise Exception("Exception at response middleware")
 
     with caplog.at_level(logging.ERROR):
-        reqrequest, response = app.test_client.get("/")
+        reqrequest, response = app.test_client.get("/fail")
 
     assert response.status == 404
+    # 404 errors are not logged
     assert (
         "sanic.root",
         logging.ERROR,
         "Exception occurred while handling uri: 'http://127.0.0.1:42101/'",
-    ) in caplog.record_tuples
+    ) not in caplog.record_tuples
+    # Middleware exception ignored but logged
     assert (
         "sanic.error",
         logging.ERROR,

tests/test_named_routes.py

@@ -21,13 +21,13 @@ def test_versioned_named_routes_get(app, method):
     bp = Blueprint("test_bp", url_prefix="/bp")
 
     method = method.lower()
-    route_name = "route_{}".format(method)
+    route_name = f"route_{method}"
-    route_name2 = "route2_{}".format(method)
+    route_name2 = f"route2_{method}"
 
     func = getattr(app, method)
     if callable(func):
 
-        @func("/{}".format(method), version=1, name=route_name)
+        @func(f"/{method}", version=1, name=route_name)
         def handler(request):
             return text("OK")
 
@@ -38,7 +38,7 @@ def test_versioned_named_routes_get(app, method):
     func = getattr(bp, method)
     if callable(func):
 
-        @func("/{}".format(method), version=1, name=route_name2)
+        @func(f"/{method}", version=1, name=route_name2)
         def handler2(request):
             return text("OK")
 
@@ -48,14 +48,14 @@ def test_versioned_named_routes_get(app, method):
 
     app.blueprint(bp)
 
-    assert app.router.routes_all["/v1/{}".format(method)].name == route_name
+    assert app.router.routes_all[f"/v1/{method}"].name == route_name
 
-    route = app.router.routes_all["/v1/bp/{}".format(method)]
+    route = app.router.routes_all[f"/v1/bp/{method}"]
-    assert route.name == "test_bp.{}".format(route_name2)
+    assert route.name == f"test_bp.{route_name2}"
 
-    assert app.url_for(route_name) == "/v1/{}".format(method)
+    assert app.url_for(route_name) == f"/v1/{method}"
-    url = app.url_for("test_bp.{}".format(route_name2))
+    url = app.url_for(f"test_bp.{route_name2}")
-    assert url == "/v1/bp/{}".format(method)
+    assert url == f"/v1/bp/{method}"
     with pytest.raises(URLBuildError):
         app.url_for("handler")
 

tests/test_payload_too_large.py

@@ -27,7 +27,7 @@ def test_payload_too_large_at_data_received_default(app):
 
     response = app.test_client.get("/1", gather_request=False)
     assert response.status == 413
-    assert response.text == "Error: Payload Too Large"
+    assert "Payload Too Large" in response.text
 
 
 def test_payload_too_large_at_on_header_default(app):
@@ -40,4 +40,4 @@ def test_payload_too_large_at_on_header_default(app):
     data = "a" * 1000
     response = app.test_client.post("/1", gather_request=False, data=data)
     assert response.status == 413
-    assert response.text == "Error: Payload Too Large"
+    assert "Payload Too Large" in response.text

tests/test_redirect.py

@@ -115,14 +115,14 @@ def test_redirect_with_params(app, test_str):
 
     @app.route("/api/v1/test/<test>/")
     async def init_handler(request, test):
-        return redirect("/api/v2/test/{}/".format(use_in_uri))
+        return redirect(f"/api/v2/test/{use_in_uri}/")
 
     @app.route("/api/v2/test/<test>/")
     async def target_handler(request, test):
         assert test == test_str
         return text("OK")
 
-    _, response = app.test_client.get("/api/v1/test/{}/".format(use_in_uri))
+    _, response = app.test_client.get(f"/api/v1/test/{use_in_uri}/")
     assert response.status == 200
 
     assert response.content == b"OK"

tests/test_request_data.py

@@ -44,44 +44,6 @@ def test_custom_context(app):
     }
 
 
-# Remove this once the deprecated API is abolished.
-def test_custom_context_old(app):
-    @app.middleware("request")
-    def store(request):
-        try:
-            request["foo"]
-        except KeyError:
-            pass
-        request["user"] = "sanic"
-        sidekick = request.get("sidekick", "tails")  # Item missing -> default
-        request["sidekick"] = sidekick
-        request["bar"] = request["sidekick"]
-        del request["sidekick"]
-
-    @app.route("/")
-    def handler(request):
-        return json(
-            {
-                "user": request.get("user"),
-                "sidekick": request.get("sidekick"),
-                "has_bar": "bar" in request,
-                "has_sidekick": "sidekick" in request,
-            }
-        )
-
-    request, response = app.test_client.get("/")
-
-    assert response.json == {
-        "user": "sanic",
-        "sidekick": None,
-        "has_bar": True,
-        "has_sidekick": False,
-    }
-    response_json = loads(response.text)
-    assert response_json["user"] == "sanic"
-    assert response_json.get("sidekick") is None
-
-
 def test_app_injection(app):
     expected = random.choice(range(0, 100))
 

tests/test_request_stream.py

@@ -3,12 +3,12 @@ import pytest
 from sanic.blueprints import Blueprint
 from sanic.exceptions import HeaderExpectationFailed
 from sanic.request import StreamBuffer
-from sanic.response import stream, text
+from sanic.response import json, stream, text
 from sanic.views import CompositionView, HTTPMethodView
 from sanic.views import stream as stream_decorator
 
 
-data = "abc" * 10000000
+data = "abc" * 1_000_000
 
 
 def test_request_stream_method_view(app):
@@ -329,15 +329,12 @@ def test_request_stream_handle_exception(app):
     # 404
     request, response = app.test_client.post("/in_valid_post", data=data)
     assert response.status == 404
-    assert response.text == "Error: Requested URL /in_valid_post not found"
+    assert "Requested URL /in_valid_post not found" in response.text
 
     # 405
     request, response = app.test_client.get("/post/random_id")
     assert response.status == 405
-    assert (
+    assert "Method GET not allowed for URL /post/random_id" in response.text
-        response.text == "Error: Method GET not allowed for URL"
-        " /post/random_id"
-    )
 
 
 def test_request_stream_blueprint(app):
@@ -616,3 +613,43 @@ def test_request_stream(app):
     request, response = app.test_client.post("/bp_stream", data=data)
     assert response.status == 200
     assert response.text == data
+
+def test_streaming_new_api(app):
+    @app.post("/non-stream")
+    async def handler(request):
+        assert request.body == b"x"
+        await request.receive_body()  # This should do nothing
+        assert request.body == b"x"
+        return text("OK")
+
+    @app.post("/1", stream=True)
+    async def handler(request):
+        assert request.stream
+        assert not request.body
+        await request.receive_body()
+        return text(request.body.decode().upper())
+
+    @app.post("/2", stream=True)
+    async def handler(request):
+        ret = []
+        async for data in request.stream:
+            # We should have no b"" or None, just proper chunks
+            assert data
+            assert isinstance(data, bytes)
+            ret.append(data.decode("ASCII"))
+        return json(ret)
+
+    request, response = app.test_client.post("/non-stream", data="x")
+    assert response.status == 200
+
+    request, response = app.test_client.post("/1", data="TEST data")
+    assert request.body == b"TEST data"
+    assert response.status == 200
+    assert response.text == "TEST DATA"
+
+    request, response = app.test_client.post("/2", data=data)
+    assert response.status == 200
+    res = response.json
+    assert isinstance(res, list)
+    assert len(res) > 1
+    assert "".join(res) == data

tests/test_request_timeout.py

@@ -14,18 +14,15 @@ class DelayableHTTPConnection(httpx.dispatch.connection.HTTPConnection):
             self._request_delay = kwargs.pop("request_delay")
         super().__init__(*args, **kwargs)
 
-    async def send(self, request, verify=None, cert=None, timeout=None):
+    async def send(self, request, timeout=None):
-        if self.h11_connection is None and self.h2_connection is None:
+
-            await self.connect(verify=verify, cert=cert, timeout=timeout)
+        if self.connection is None:
+            self.connection = (await self.connect(timeout=timeout))
 
         if self._request_delay:
             await asyncio.sleep(self._request_delay)
 
-        if self.h2_connection is not None:
+        response = await self.connection.send(request, timeout=timeout)
-            response = await self.h2_connection.send(request, timeout=timeout)
-        else:
-            assert self.h11_connection is not None
-            response = await self.h11_connection.send(request, timeout=timeout)
 
         return response
 
@@ -46,12 +43,9 @@ class DelayableSanicConnectionPool(
             await self.max_connections.acquire(timeout=pool_timeout)
             connection = DelayableHTTPConnection(
                 origin,
-                verify=self.verify,
+                ssl=self.ssl,
-                cert=self.cert,
-                http2=self.http2,
                 backend=self.backend,
                 release_func=self.release_connection,
-                trust_env=self.trust_env,
                 uds=self.uds,
                 request_delay=self._request_delay,
             )
@@ -61,7 +55,7 @@ class DelayableSanicConnectionPool(
         return connection
 
 
-class DelayableSanicSession(httpx.Client):
+class DelayableSanicSession(httpx.AsyncClient):
     def __init__(self, request_delay=None, *args, **kwargs) -> None:
         dispatch = DelayableSanicConnectionPool(request_delay=request_delay)
         super().__init__(dispatch=dispatch, *args, **kwargs)
@@ -102,7 +96,7 @@ def test_default_server_error_request_timeout():
     client = DelayableSanicTestClient(request_timeout_default_app, 2)
     request, response = client.get("/1")
     assert response.status == 408
-    assert response.text == "Error: Request Timeout"
+    assert "Request Timeout" in response.text
 
 
 def test_default_server_error_request_dont_timeout():
@@ -125,4 +119,4 @@ def test_default_server_error_websocket_request_timeout():
     request, response = client.get("/ws1", headers=headers)
 
     assert response.status == 408
-    assert response.text == "Error: Request Timeout"
+    assert "Request Timeout" in response.text

tests/test_requests.py

@@ -11,8 +11,8 @@ import pytest
 from sanic import Blueprint, Sanic
 from sanic.exceptions import ServerError
 from sanic.request import DEFAULT_HTTP_CONTENT_TYPE, Request, RequestParameters
-from sanic.response import json, text
+from sanic.response import html, json, text
-from sanic.testing import ASGI_HOST, HOST, PORT
+from sanic.testing import ASGI_HOST, HOST, PORT, SanicTestClient
 
 
 # ------------------------------------------------------------ #
@@ -44,7 +44,7 @@ async def test_sync_asgi(app):
 def test_ip(app):
     @app.route("/")
     def handler(request):
-        return text("{}".format(request.ip))
+        return text(f"{request.ip}")
 
     request, response = app.test_client.get("/")
 
@@ -55,7 +55,7 @@ def test_ip(app):
 async def test_ip_asgi(app):
     @app.route("/")
     def handler(request):
-        return text("{}".format(request.url))
+        return text(f"{request.url}")
 
     request, response = await app.asgi_client.get("/")
 
@@ -72,6 +72,41 @@ def test_text(app):
     assert response.text == "Hello"
 
 
+def test_html(app):
+    class Foo:
+        def __html__(self):
+            return "<h1>Foo</h1>"
+
+        def _repr_html_(self):
+            return "<h1>Foo object repr</h1>"
+
+    class Bar:
+        def _repr_html_(self):
+            return "<h1>Bar object repr</h1>"
+
+    @app.route("/")
+    async def handler(request):
+        return html("<h1>Hello</h1>")
+
+    @app.route("/foo")
+    async def handler(request):
+        return html(Foo())
+
+    @app.route("/bar")
+    async def handler(request):
+        return html(Bar())
+
+    request, response = app.test_client.get("/")
+    assert response.content_type == "text/html; charset=utf-8"
+    assert response.text == "<h1>Hello</h1>"
+
+    request, response = app.test_client.get("/foo")
+    assert response.text == "<h1>Foo</h1>"
+
+    request, response = app.test_client.get("/bar")
+    assert response.text == "<h1>Bar object repr</h1>"
+
+
 @pytest.mark.asyncio
 async def test_text_asgi(app):
     @app.route("/")
@@ -290,7 +325,7 @@ def test_token(app):
     token = "a1d895e0-553a-421a-8e22-5ff8ecb48cbf"
     headers = {
         "content-type": "application/json",
-        "Authorization": "{}".format(token),
+        "Authorization": f"{token}",
     }
 
     request, response = app.test_client.get("/", headers=headers)
@@ -300,7 +335,7 @@ def test_token(app):
     token = "a1d895e0-553a-421a-8e22-5ff8ecb48cbf"
     headers = {
         "content-type": "application/json",
-        "Authorization": "Token {}".format(token),
+        "Authorization": f"Token {token}",
     }
 
     request, response = app.test_client.get("/", headers=headers)
@@ -310,7 +345,7 @@ def test_token(app):
     token = "a1d895e0-553a-421a-8e22-5ff8ecb48cbf"
     headers = {
         "content-type": "application/json",
-        "Authorization": "Bearer {}".format(token),
+        "Authorization": f"Bearer {token}",
     }
 
     request, response = app.test_client.get("/", headers=headers)
@@ -335,7 +370,7 @@ async def test_token_asgi(app):
     token = "a1d895e0-553a-421a-8e22-5ff8ecb48cbf"
     headers = {
         "content-type": "application/json",
-        "Authorization": "{}".format(token),
+        "Authorization": f"{token}",
     }
 
     request, response = await app.asgi_client.get("/", headers=headers)
@@ -345,7 +380,7 @@ async def test_token_asgi(app):
     token = "a1d895e0-553a-421a-8e22-5ff8ecb48cbf"
     headers = {
         "content-type": "application/json",
-        "Authorization": "Token {}".format(token),
+        "Authorization": f"Token {token}",
     }
 
     request, response = await app.asgi_client.get("/", headers=headers)
@@ -355,7 +390,7 @@ async def test_token_asgi(app):
     token = "a1d895e0-553a-421a-8e22-5ff8ecb48cbf"
     headers = {
         "content-type": "application/json",
-        "Authorization": "Bearer {}".format(token),
+        "Authorization": f"Bearer {token}",
     }
 
     request, response = await app.asgi_client.get("/", headers=headers)
@@ -993,8 +1028,8 @@ def test_url_attributes_no_ssl(app, path, query, expected_url):
 
     app.add_route(handler, path)
 
-    request, response = app.test_client.get(path + "?{}".format(query))
+    request, response = app.test_client.get(path + f"?{query}")
-    assert request.url == expected_url.format(HOST, PORT)
+    assert request.url == expected_url.format(HOST, request.server_port)
 
     parsed = urlparse(request.url)
 
@@ -1019,7 +1054,7 @@ async def test_url_attributes_no_ssl_asgi(app, path, query, expected_url):
 
     app.add_route(handler, path)
 
-    request, response = await app.asgi_client.get(path + "?{}".format(query))
+    request, response = await app.asgi_client.get(path + f"?{query}")
     assert request.url == expected_url.format(ASGI_HOST)
 
     parsed = urlparse(request.url)
@@ -1051,11 +1086,12 @@ def test_url_attributes_with_ssl_context(app, path, query, expected_url):
 
     app.add_route(handler, path)
 
+    port = app.test_client.port
     request, response = app.test_client.get(
-        "https://{}:{}".format(HOST, PORT) + path + "?{}".format(query),
+        f"https://{HOST}:{PORT}" + path + f"?{query}",
         server_kwargs={"ssl": context},
     )
-    assert request.url == expected_url.format(HOST, PORT)
+    assert request.url == expected_url.format(HOST, request.server_port)
 
     parsed = urlparse(request.url)
 
@@ -1087,10 +1123,10 @@ def test_url_attributes_with_ssl_dict(app, path, query, expected_url):
     app.add_route(handler, path)
 
     request, response = app.test_client.get(
-        "https://{}:{}".format(HOST, PORT) + path + "?{}".format(query),
+        f"https://{HOST}:{PORT}" + path + f"?{query}",
         server_kwargs={"ssl": ssl_dict},
     )
-    assert request.url == expected_url.format(HOST, PORT)
+    assert request.url == expected_url.format(HOST, request.server_port)
 
     parsed = urlparse(request.url)
 
@@ -1571,33 +1607,6 @@ async def test_request_args_no_query_string_await(app):
     assert request.args == {}
 
 
-def test_request_raw_args(app):
-
-    params = {"test": "OK"}
-
-    @app.get("/")
-    def handler(request):
-        return text("pass")
-
-    request, response = app.test_client.get("/", params=params)
-
-    assert request.raw_args == params
-
-
-@pytest.mark.asyncio
-async def test_request_raw_args_asgi(app):
-
-    params = {"test": "OK"}
-
-    @app.get("/")
-    def handler(request):
-        return text("pass")
-
-    request, response = await app.asgi_client.get("/", params=params)
-
-    assert request.raw_args == params
-
-
 def test_request_query_args(app):
     # test multiple params with the same key
     params = [("test", "value1"), ("test", "value2")]
@@ -1882,8 +1891,9 @@ def test_request_server_port(app):
     def handler(request):
         return text("OK")
 
-    request, response = app.test_client.get("/", headers={"Host": "my-server"})
+    test_client = SanicTestClient(app)
-    assert request.server_port == app.test_client.port
+    request, response = test_client.get("/", headers={"Host": "my-server"})
+    assert request.server_port == test_client.port
 
 
 def test_request_server_port_in_host_header(app):
@@ -1904,6 +1914,9 @@ def test_request_server_port_in_host_header(app):
     request, response = app.test_client.get(
         "/", headers={"Host": "mal_formed:5555"}
     )
+    if PORT is None:
+        assert request.server_port != 5555
+    else:
         assert request.server_port == app.test_client.port
 
 
@@ -1944,7 +1957,7 @@ def test_server_name_and_url_for(app):
     request, response = app.test_client.get("/foo")
     assert (
         request.url_for("handler")
-        == f"http://my-server:{app.test_client.port}/foo"
+        == f"http://my-server:{request.server_port}/foo"
     )
 
     app.config.SERVER_NAME = "https://my-server/path"
@@ -2005,7 +2018,7 @@ async def test_request_form_invalid_content_type_asgi(app):
 
 
 def test_endpoint_basic():
-    app = Sanic()
+    app = Sanic(name=__name__)
 
     @app.route("/")
     def my_unique_handler(request):
@@ -2018,7 +2031,7 @@ def test_endpoint_basic():
 
 @pytest.mark.asyncio
 async def test_endpoint_basic_asgi():
-    app = Sanic()
+    app = Sanic(name=__name__)
 
     @app.route("/")
     def my_unique_handler(request):
@@ -2097,5 +2110,5 @@ def test_url_for_without_server_name(app):
     request, response = app.test_client.get("/sample")
     assert (
         response.json["url"]
-        == f"http://127.0.0.1:{app.test_client.port}/url-for"
+        == f"http://127.0.0.1:{request.server_port}/url-for"
     )

tests/test_response.py

@@ -15,13 +15,14 @@ from aiofiles import os as async_os
 from sanic.response import (
     HTTPResponse,
     StreamingHTTPResponse,
+    empty,
     file,
     file_stream,
     json,
     raw,
     stream,
+    text,
 )
-from sanic.response import empty
 from sanic.server import HttpProtocol
 from sanic.testing import HOST, PORT
 
@@ -29,13 +30,14 @@ from sanic.testing import HOST, PORT
 JSON_DATA = {"ok": True}
 
 
+@pytest.mark.filterwarnings("ignore:Types other than str will be")
 def test_response_body_not_a_string(app):
     """Test when a response body sent from the application is not a string"""
     random_num = choice(range(1000))
 
     @app.route("/hello")
     async def hello_route(request):
-        return HTTPResponse(body=random_num)
+        return text(random_num)
 
     request, response = app.test_client.get("/hello")
     assert response.text == str(random_num)
@@ -406,7 +408,7 @@ def test_file_response(app, file_name, static_file_directory, status):
             mime_type=guess_type(file_path)[0] or "text/plain",
         )
 
-    request, response = app.test_client.get("/files/{}".format(file_name))
+    request, response = app.test_client.get(f"/files/{file_name}")
     assert response.status == status
     assert response.body == get_file_content(static_file_directory, file_name)
     assert "Content-Disposition" not in response.headers
@@ -429,12 +431,12 @@ def test_file_response_custom_filename(
         file_path = os.path.abspath(unquote(file_path))
         return file(file_path, filename=dest)
 
-    request, response = app.test_client.get("/files/{}".format(source))
+    request, response = app.test_client.get(f"/files/{source}")
     assert response.status == 200
     assert response.body == get_file_content(static_file_directory, source)
     assert response.headers[
         "Content-Disposition"
-    ] == 'attachment; filename="{}"'.format(dest)
+    ] == f'attachment; filename="{dest}"'
 
 
 @pytest.mark.parametrize("file_name", ["test.file", "decode me.txt"])
@@ -459,7 +461,7 @@ def test_file_head_response(app, file_name, static_file_directory):
                 mime_type=guess_type(file_path)[0] or "text/plain",
             )
 
-    request, response = app.test_client.head("/files/{}".format(file_name))
+    request, response = app.test_client.head(f"/files/{file_name}")
     assert response.status == 200
     assert "Accept-Ranges" in response.headers
     assert "Content-Length" in response.headers
@@ -482,7 +484,7 @@ def test_file_stream_response(app, file_name, static_file_directory):
             mime_type=guess_type(file_path)[0] or "text/plain",
         )
 
-    request, response = app.test_client.get("/files/{}".format(file_name))
+    request, response = app.test_client.get(f"/files/{file_name}")
     assert response.status == 200
     assert response.body == get_file_content(static_file_directory, file_name)
     assert "Content-Disposition" not in response.headers
@@ -505,12 +507,12 @@ def test_file_stream_response_custom_filename(
         file_path = os.path.abspath(unquote(file_path))
         return file_stream(file_path, chunk_size=32, filename=dest)
 
-    request, response = app.test_client.get("/files/{}".format(source))
+    request, response = app.test_client.get(f"/files/{source}")
     assert response.status == 200
     assert response.body == get_file_content(static_file_directory, source)
     assert response.headers[
         "Content-Disposition"
-    ] == 'attachment; filename="{}"'.format(dest)
+    ] == f'attachment; filename="{dest}"'
 
 
 @pytest.mark.parametrize("file_name", ["test.file", "decode me.txt"])
@@ -538,7 +540,7 @@ def test_file_stream_head_response(app, file_name, static_file_directory):
                 mime_type=guess_type(file_path)[0] or "text/plain",
             )
 
-    request, response = app.test_client.head("/files/{}".format(file_name))
+    request, response = app.test_client.head(f"/files/{file_name}")
     assert response.status == 200
     # A HEAD request should never be streamed/chunked.
     if "Transfer-Encoding" in response.headers:
@@ -576,12 +578,10 @@ def test_file_stream_response_range(
             _range=range,
         )
 
-    request, response = app.test_client.get("/files/{}".format(file_name))
+    request, response = app.test_client.get(f"/files/{file_name}")
     assert response.status == 206
     assert "Content-Range" in response.headers
-    assert response.headers["Content-Range"] == "bytes {}-{}/{}".format(
+    assert response.headers["Content-Range"] == f"bytes {range.start}-{range.end}/{range.total}"
-        range.start, range.end, range.total
-    )
 
 
 def test_raw_response(app):

tests/test_response_timeout.py

@@ -40,7 +40,7 @@ async def handler_2(request):
 def test_default_server_error_response_timeout():
     request, response = response_timeout_default_app.test_client.get("/1")
     assert response.status == 503
-    assert response.text == "Error: Response Timeout"
+    assert "Response Timeout" in response.text
 
 
 response_handler_cancelled_app.flag = False
@@ -65,5 +65,5 @@ async def handler_3(request):
 def test_response_handler_cancelled():
     request, response = response_handler_cancelled_app.test_client.get("/1")
     assert response.status == 503
-    assert response.text == "Error: Response Timeout"
+    assert "Response Timeout" in response.text
     assert response_handler_cancelled_app.flag is False

tests/test_routes.py

@@ -6,6 +6,7 @@ from sanic import Sanic
 from sanic.constants import HTTP_METHODS
 from sanic.response import json, text
 from sanic.router import ParameterNameConflicts, RouteDoesNotExist, RouteExists
+from sanic.testing import SanicTestClient
 
 
 # ------------------------------------------------------------ #
@@ -20,17 +21,17 @@ def test_versioned_routes_get(app, method):
     func = getattr(app, method)
     if callable(func):
 
-        @func("/{}".format(method), version=1)
+        @func(f"/{method}", version=1)
         def handler(request):
             return text("OK")
 
     else:
         print(func)
-        raise Exception("Method: {} is not callable".format(method))
+        raise Exception(f"Method: {method} is not callable")
 
     client_method = getattr(app.test_client, method)
 
-    request, response = client_method("/v1/{}".format(method))
+    request, response = client_method(f"/v1/{method}")
     assert response.status == 200
 
 
@@ -167,35 +168,36 @@ def test_route_optional_slash(app):
 def test_route_strict_slashes_set_to_false_and_host_is_a_list(app):
     # Part of regression test for issue #1120
 
-    site1 = "127.0.0.1:{}".format(app.test_client.port)
+    test_client = SanicTestClient(app, port=42101)
+    site1 = f"127.0.0.1:{test_client.port}"
 
     # before fix, this raises a RouteExists error
     @app.get("/get", host=[site1, "site2.com"], strict_slashes=False)
     def get_handler(request):
         return text("OK")
 
-    request, response = app.test_client.get("http://" + site1 + "/get")
+    request, response = test_client.get("http://" + site1 + "/get")
     assert response.text == "OK"
 
     @app.post("/post", host=[site1, "site2.com"], strict_slashes=False)
     def post_handler(request):
         return text("OK")
 
-    request, response = app.test_client.post("http://" + site1 + "/post")
+    request, response = test_client.post("http://" + site1 + "/post")
     assert response.text == "OK"
 
     @app.put("/put", host=[site1, "site2.com"], strict_slashes=False)
     def put_handler(request):
         return text("OK")
 
-    request, response = app.test_client.put("http://" + site1 + "/put")
+    request, response = test_client.put("http://" + site1 + "/put")
     assert response.text == "OK"
 
     @app.delete("/delete", host=[site1, "site2.com"], strict_slashes=False)
     def delete_handler(request):
         return text("OK")
 
-    request, response = app.test_client.delete("http://" + site1 + "/delete")
+    request, response = test_client.delete("http://" + site1 + "/delete")
     assert response.text == "OK"
 
 
@@ -412,7 +414,8 @@ def test_dynamic_route_uuid(app):
     assert response.text == "OK"
     assert type(results[0]) is uuid.UUID
 
-    request, response = app.test_client.get("/quirky/{}".format(uuid.uuid4()))
+    generated_uuid = uuid.uuid4()
+    request, response = app.test_client.get(f"/quirky/{generated_uuid}")
     assert response.status == 200
 
     request, response = app.test_client.get("/quirky/non-existing")
@@ -551,6 +554,35 @@ def test_route_duplicate(app):
             pass
 
 
+def test_double_stack_route(app):
+    @app.route("/test/1")
+    @app.route("/test/2")
+    async def handler1(request):
+        return text("OK")
+
+    request, response = app.test_client.get("/test/1")
+    assert response.status == 200
+    request, response = app.test_client.get("/test/2")
+    assert response.status == 200
+
+
+@pytest.mark.asyncio
+async def test_websocket_route_asgi(app):
+    ev = asyncio.Event()
+
+    @app.websocket("/test/1")
+    @app.websocket("/test/2")
+    async def handler(request, ws):
+        ev.set()
+
+    request, response = await app.asgi_client.websocket("/test/1")
+    first_set = ev.is_set()
+    ev.clear()
+    request, response = await app.asgi_client.websocket("/test/1")
+    second_set = ev.is_set()
+    assert(first_set and second_set)
+
+
 def test_method_not_allowed(app):
     @app.route("/test", methods=["GET"])
     async def handler(request):
@@ -738,55 +770,6 @@ def test_add_route_method_not_allowed(app):
     assert response.status == 405
 
 
-def test_remove_static_route(app):
-    async def handler1(request):
-        return text("OK1")
-
-    async def handler2(request):
-        return text("OK2")
-
-    app.add_route(handler1, "/test")
-    app.add_route(handler2, "/test2")
-
-    request, response = app.test_client.get("/test")
-    assert response.status == 200
-
-    request, response = app.test_client.get("/test2")
-    assert response.status == 200
-
-    app.remove_route("/test")
-    app.remove_route("/test2")
-
-    request, response = app.test_client.get("/test")
-    assert response.status == 404
-
-    request, response = app.test_client.get("/test2")
-    assert response.status == 404
-
-
-def test_remove_dynamic_route(app):
-    async def handler(request, name):
-        return text("OK")
-
-    app.add_route(handler, "/folder/<name>")
-
-    request, response = app.test_client.get("/folder/test123")
-    assert response.status == 200
-
-    app.remove_route("/folder/<name>")
-    request, response = app.test_client.get("/folder/test123")
-    assert response.status == 404
-
-
-def test_remove_inexistent_route(app):
-
-    uri = "/test"
-    with pytest.raises(RouteDoesNotExist) as excinfo:
-        app.remove_route(uri)
-
-    assert str(excinfo.value) == "Route was not registered: {}".format(uri)
-
-
 def test_removing_slash(app):
     @app.get("/rest/<resource>")
     def get(_):
@@ -799,59 +782,6 @@ def test_removing_slash(app):
     assert len(app.router.routes_all.keys()) == 2
 
 
-def test_remove_unhashable_route(app):
-    async def handler(request, unhashable):
-        return text("OK")
-
-    app.add_route(handler, "/folder/<unhashable:[A-Za-z0-9/]+>/end/")
-
-    request, response = app.test_client.get("/folder/test/asdf/end/")
-    assert response.status == 200
-
-    request, response = app.test_client.get("/folder/test///////end/")
-    assert response.status == 200
-
-    request, response = app.test_client.get("/folder/test/end/")
-    assert response.status == 200
-
-    app.remove_route("/folder/<unhashable:[A-Za-z0-9/]+>/end/")
-
-    request, response = app.test_client.get("/folder/test/asdf/end/")
-    assert response.status == 404
-
-    request, response = app.test_client.get("/folder/test///////end/")
-    assert response.status == 404
-
-    request, response = app.test_client.get("/folder/test/end/")
-    assert response.status == 404
-
-
-def test_remove_route_without_clean_cache(app):
-    async def handler(request):
-        return text("OK")
-
-    app.add_route(handler, "/test")
-
-    request, response = app.test_client.get("/test")
-    assert response.status == 200
-
-    app.remove_route("/test", clean_cache=True)
-    app.remove_route("/test/", clean_cache=True)
-
-    request, response = app.test_client.get("/test")
-    assert response.status == 404
-
-    app.add_route(handler, "/test")
-
-    request, response = app.test_client.get("/test")
-    assert response.status == 200
-
-    app.remove_route("/test", clean_cache=False)
-
-    request, response = app.test_client.get("/test")
-    assert response.status == 200
-
-
 def test_overload_routes(app):
     @app.route("/overload", methods=["GET"])
     async def handler1(request):

tests/test_server_events.py

@@ -1,6 +1,9 @@
 import asyncio
 import signal
 
+from contextlib import closing
+from socket import socket
+
 import pytest
 
 from sanic.testing import HOST, PORT
@@ -22,7 +25,7 @@ skipif_no_alarm = pytest.mark.skipif(
 
 def create_listener(listener_name, in_list):
     async def _listener(app, loop):
-        print("DEBUG MESSAGE FOR PYTEST for {}".format(listener_name))
+        print(f"DEBUG MESSAGE FOR PYTEST for {listener_name}")
         in_list.insert(0, app.name + listener_name)
 
     return _listener
@@ -118,7 +121,12 @@ def test_create_server_trigger_events(app):
     app.listener("after_server_stop")(after_stop)
 
     loop = asyncio.get_event_loop()
-    serv_coro = app.create_server(return_asyncio_server=True)
+
+    # Use random port for tests
+    with closing(socket()) as sock:
+        sock.bind(("127.0.0.1", 0))
+
+        serv_coro = app.create_server(return_asyncio_server=True, sock=sock)
         serv_task = asyncio.ensure_future(serv_coro, loop=loop)
         server = loop.run_until_complete(serv_task)
         server.after_start()

tests/test_signal_handlers.py

@@ -1,8 +1,13 @@
 import asyncio
+import os
+import signal
 
 from queue import Queue
 from unittest.mock import MagicMock
 
+import pytest
+
+from sanic.compat import ctrlc_workaround_for_windows
 from sanic.response import HTTPResponse
 from sanic.testing import HOST, PORT
 
@@ -16,13 +21,21 @@ calledq = Queue()
 
 
 def set_loop(app, loop):
-    loop.add_signal_handler = MagicMock()
+    global mock
+    mock = MagicMock()
+    if os.name == "nt":
+        signal.signal = mock
+    else:
+        loop.add_signal_handler = mock
 
 
 def after(app, loop):
-    calledq.put(loop.add_signal_handler.called)
+    calledq.put(mock.called)
 
 
+@pytest.mark.skipif(
+    os.name == "nt", reason="May hang CI on py38/windows"
+)
 def test_register_system_signals(app):
     """Test if sanic register system signals"""
 
@@ -38,6 +51,9 @@ def test_register_system_signals(app):
     assert calledq.get() is True
 
 
+@pytest.mark.skipif(
+    os.name == "nt", reason="May hang CI on py38/windows"
+)
 def test_dont_register_system_signals(app):
     """Test if sanic don't register system signals"""
 
@@ -51,3 +67,49 @@ def test_dont_register_system_signals(app):
 
     app.run(HOST, PORT, register_sys_signals=False)
     assert calledq.get() is False
+
+
+@pytest.mark.skipif(
+    os.name == "nt", reason="windows cannot SIGINT processes"
+)
+def test_windows_workaround():
+    """Test Windows workaround (on any other OS)"""
+    # At least some code coverage, even though this test doesn't work on
+    # Windows...
+    class MockApp:
+        def __init__(self):
+            self.is_stopping = False
+
+        def stop(self):
+            assert not self.is_stopping
+            self.is_stopping = True
+
+        def add_task(self, func):
+            loop = asyncio.get_event_loop()
+            self.stay_active_task = loop.create_task(func(self))
+
+    async def atest(stop_first):
+        app = MockApp()
+        ctrlc_workaround_for_windows(app)
+        await asyncio.sleep(0.05)
+        if stop_first:
+            app.stop()
+            await asyncio.sleep(0.2)
+        assert app.is_stopping == stop_first
+        # First Ctrl+C: should call app.stop() within 0.1 seconds
+        os.kill(os.getpid(), signal.SIGINT)
+        await asyncio.sleep(0.2)
+        assert app.is_stopping
+        assert app.stay_active_task.result() == None
+        # Second Ctrl+C should raise
+        with pytest.raises(KeyboardInterrupt):
+            os.kill(os.getpid(), signal.SIGINT)
+        return "OK"
+
+    # Run in our private loop
+    loop = asyncio.new_event_loop()
+    asyncio.set_event_loop(loop)
+    res = loop.run_until_complete(atest(False))
+    assert res == "OK"
+    res = loop.run_until_complete(atest(True))
+    assert res == "OK"

tests/test_static.py

@@ -98,7 +98,7 @@ def test_static_directory(app, file_name, base_uri, static_file_directory):
     app.static(base_uri, static_file_directory)
 
     request, response = app.test_client.get(
-        uri="{}/{}".format(base_uri, file_name)
+        uri=f"{base_uri}/{file_name}"
     )
     assert response.status == 200
     assert response.body == get_file_content(static_file_directory, file_name)
@@ -234,11 +234,11 @@ def test_static_content_range_invalid_unit(
     )
 
     unit = "bit"
-    headers = {"Range": "{}=1-0".format(unit)}
+    headers = {"Range": f"{unit}=1-0"}
     request, response = app.test_client.get("/testing.file", headers=headers)
 
     assert response.status == 416
-    assert response.text == "Error: {} is not a valid Range Type".format(unit)
+    assert f"{unit} is not a valid Range Type" in response.text
 
 
 @pytest.mark.parametrize("file_name", ["test.file", "decode me.txt"])
@@ -252,13 +252,11 @@ def test_static_content_range_invalid_start(
     )
 
     start = "start"
-    headers = {"Range": "bytes={}-0".format(start)}
+    headers = {"Range": f"bytes={start}-0"}
     request, response = app.test_client.get("/testing.file", headers=headers)
 
     assert response.status == 416
-    assert response.text == "Error: '{}' is invalid for Content Range".format(
+    assert f"'{start}' is invalid for Content Range" in response.text
-        start
-    )
 
 
 @pytest.mark.parametrize("file_name", ["test.file", "decode me.txt"])
@@ -272,13 +270,11 @@ def test_static_content_range_invalid_end(
     )
 
     end = "end"
-    headers = {"Range": "bytes=1-{}".format(end)}
+    headers = {"Range": f"bytes=1-{end}"}
     request, response = app.test_client.get("/testing.file", headers=headers)
 
     assert response.status == 416
-    assert response.text == "Error: '{}' is invalid for Content Range".format(
+    assert f"'{end}' is invalid for Content Range" in response.text
-        end
-    )
 
 
 @pytest.mark.parametrize("file_name", ["test.file", "decode me.txt"])
@@ -295,7 +291,7 @@ def test_static_content_range_invalid_parameters(
     request, response = app.test_client.get("/testing.file", headers=headers)
 
     assert response.status == 416
-    assert response.text == "Error: Invalid for Content Range parameters"
+    assert "Invalid for Content Range parameters" in response.text
 
 
 @pytest.mark.parametrize(
@@ -369,7 +365,7 @@ def test_file_not_found(app, static_file_directory):
     request, response = app.test_client.get("/static/not_found")
 
     assert response.status == 404
-    assert response.text == "Error: File not found"
+    assert "File not found" in response.text
 
 
 @pytest.mark.parametrize("static_name", ["_static_name", "static"])
@@ -377,20 +373,6 @@ def test_file_not_found(app, static_file_directory):
 def test_static_name(app, static_file_directory, static_name, file_name):
     app.static("/static", static_file_directory, name=static_name)
 
-    request, response = app.test_client.get("/static/{}".format(file_name))
+    request, response = app.test_client.get(f"/static/{file_name}")
 
     assert response.status == 200
-
-
-@pytest.mark.parametrize("file_name", ["test.file"])
-def test_static_remove_route(app, static_file_directory, file_name):
-    app.static(
-        "/testing.file", get_file_path(static_file_directory, file_name)
-    )
-
-    request, response = app.test_client.get("/testing.file")
-    assert response.status == 200
-
-    app.remove_route("/testing.file")
-    request, response = app.test_client.get("/testing.file")
-    assert response.status == 404

tests/test_test_client_port.py

@@ -1,5 +1,3 @@
-import socket
-
 from sanic.response import json, text
 from sanic.testing import PORT, SanicTestClient
 
@@ -29,7 +27,8 @@ def test_test_client_port_default(app):
         return json(request.transport.get_extra_info("sockname")[1])
 
     test_client = SanicTestClient(app)
-    assert test_client.port == PORT
+    assert test_client.port == PORT  # Can be None before request
 
     request, response = test_client.get("/get")
-    assert response.json == PORT
+    assert test_client.port > 0
+    assert response.json == test_client.port

tests/test_url_building.py

@@ -20,30 +20,24 @@ URL_FOR_ARGS3 = dict(
     arg1="v1",
     _anchor="anchor",
     _scheme="http",
-    _server="{}:{}".format(test_host, test_port),
+    _server=f"{test_host}:{test_port}",
     _external=True,
 )
-URL_FOR_VALUE3 = "http://{}:{}/myurl?arg1=v1#anchor".format(
+URL_FOR_VALUE3 = f"http://{test_host}:{test_port}/myurl?arg1=v1#anchor"
-    test_host, test_port
-)
 URL_FOR_ARGS4 = dict(
     arg1="v1",
     _anchor="anchor",
     _external=True,
-    _server="http://{}:{}".format(test_host, test_port),
+    _server=f"http://{test_host}:{test_port}",
-)
-URL_FOR_VALUE4 = "http://{}:{}/myurl?arg1=v1#anchor".format(
-    test_host, test_port
 )
+URL_FOR_VALUE4 = f"http://{test_host}:{test_port}/myurl?arg1=v1#anchor"
 
 
 def _generate_handlers_from_names(app, l):
     for name in l:
         # this is the easiest way to generate functions with dynamic names
         exec(
-            '@app.route(name)\ndef {}(request):\n\treturn text("{}")'.format(
+            f'@app.route(name)\ndef {name}(request):\n\treturn text("{name}")'
-                name, name
-            )
         )
 
 
@@ -60,7 +54,7 @@ def test_simple_url_for_getting(simple_app):
     for letter in string.ascii_letters:
         url = simple_app.url_for(letter)
 
-        assert url == "/{}".format(letter)
+        assert url == f"/{letter}"
         request, response = simple_app.test_client.get(url)
         assert response.status == 200
         assert response.text == letter
@@ -88,7 +82,7 @@ def test_simple_url_for_getting_with_more_params(app, args, url):
 
 def test_url_for_with_server_name(app):
 
-    server_name = "{}:{}".format(test_host, test_port)
+    server_name = f"{test_host}:{test_port}"
     app.config.update({"SERVER_NAME": server_name})
     path = "/myurl"
 
@@ -96,7 +90,7 @@ def test_url_for_with_server_name(app):
     def passes(request):
         return text("this should pass")
 
-    url = "http://{}{}".format(server_name, path)
+    url = f"http://{server_name}{path}"
     assert url == app.url_for("passes", _server=None, _external=True)
     request, response = app.test_client.get(url)
     assert response.status == 200
@@ -118,7 +112,7 @@ def test_fails_url_build_if_param_not_passed(app):
     url = "/"
 
     for letter in string.ascii_letters:
-        url += "<{}>/".format(letter)
+        url += f"<{letter}>/"
 
     @app.route(url)
     def fail(request):
@@ -182,7 +176,7 @@ def test_passes_with_negative_int_message(app):
     @app.route("path/<possibly_neg:int>/another-word")
     def good(request, possibly_neg):
         assert isinstance(possibly_neg, int)
-        return text("this should pass with `{}`".format(possibly_neg))
+        return text(f"this should pass with `{possibly_neg}`")
 
     u_plus_3 = app.url_for("good", possibly_neg=3)
     assert u_plus_3 == "/path/3/another-word", u_plus_3
@@ -237,13 +231,13 @@ def test_passes_with_negative_number_message(app, number):
     @app.route("path/<possibly_neg:number>/another-word")
     def good(request, possibly_neg):
         assert isinstance(possibly_neg, (int, float))
-        return text("this should pass with `{}`".format(possibly_neg))
+        return text(f"this should pass with `{possibly_neg}`")
 
     u = app.url_for("good", possibly_neg=number)
-    assert u == "/path/{}/another-word".format(number), u
+    assert u == f"/path/{number}/another-word", u
     request, response = app.test_client.get(u)
     # For ``number``, it has been cast to a float - so a ``3`` becomes a ``3.0``
-    assert response.text == "this should pass with `{}`".format(float(number))
+    assert response.text == f"this should pass with `{float(number)}`"
 
 
 def test_adds_other_supplied_values_as_query_string(app):
@@ -275,7 +269,7 @@ def blueprint_app(app):
 
     @first_print.route("/foo/<param>")
     def foo_with_param(request, param):
-        return text("foo from first : {}".format(param))
+        return text(f"foo from first : {param}")
 
     @second_print.route("/foo")  # noqa
     def foo(request):
@@ -283,7 +277,7 @@ def blueprint_app(app):
 
     @second_print.route("/foo/<param>")  # noqa
     def foo_with_param(request, param):
-        return text("foo from second : {}".format(param))
+        return text(f"foo from second : {param}")
 
     app.blueprint(first_print)
     app.blueprint(second_print)

tests/test_url_for.py

@@ -0,0 +1,12 @@
+def test_routes_with_host(app):
+    @app.route("/")
+    @app.route("/", name="hostindex", host="example.com")
+    @app.route("/path", name="hostpath", host="path.example.com")
+    def index(request):
+        pass
+
+    assert app.url_for("index") == "/"
+    assert app.url_for("hostindex") == "/"
+    assert app.url_for("hostpath") == "/path"
+    assert app.url_for("hostindex", _external=True) == "http://example.com/"
+    assert app.url_for("hostpath", _external=True) == "http://path.example.com/path"

tests/test_url_for_static.py

@@ -118,7 +118,7 @@ def test_static_directory(app, file_name, base_uri, static_file_directory):
     app.static(base_uri2, static_file_directory, name="uploads")
 
     uri = app.url_for("static", name="static", filename=file_name)
-    assert uri == "{}/{}".format(base_uri, file_name)
+    assert uri == f"{base_uri}/{file_name}"
 
     request, response = app.test_client.get(uri)
     assert response.status == 200
@@ -134,7 +134,7 @@ def test_static_directory(app, file_name, base_uri, static_file_directory):
     assert uri2 == uri3
     assert uri3 == uri4
 
-    assert uri5 == "{}/{}".format(base_uri2, file_name)
+    assert uri5 == f"{base_uri2}/{file_name}"
     assert uri5 == uri6
 
     bp = Blueprint("test_bp_static", url_prefix="/bp")
@@ -157,10 +157,10 @@ def test_static_directory(app, file_name, base_uri, static_file_directory):
         "static", name="test_bp_static.uploads", filename="/" + file_name
     )
 
-    assert uri == "/bp{}/{}".format(base_uri, file_name)
+    assert uri == f"/bp{base_uri}/{file_name}"
     assert uri == uri2
 
-    assert uri4 == "/bp{}/{}".format(base_uri2, file_name)
+    assert uri4 == f"/bp{base_uri2}/{file_name}"
     assert uri4 == uri5
 
     request, response = app.test_client.get(uri)

tests/test_vhosts.py

@@ -48,17 +48,3 @@ def test_vhosts_with_defaults(app):
 
     request, response = app.test_client.get("/")
     assert response.text == "default"
-
-
-def test_remove_vhost_route(app):
-    @app.route("/", host="example.com")
-    async def handler1(request):
-        return text("You're at example.com!")
-
-    headers = {"Host": "example.com"}
-    request, response = app.test_client.get("/", headers=headers)
-    assert response.status == 200
-
-    app.remove_route("/", host="example.com")
-    request, response = app.test_client.get("/", headers=headers)
-    assert response.status == 404

tests/test_views.py

@@ -49,7 +49,7 @@ def test_unexisting_methods(app):
     request, response = app.test_client.get("/")
     assert response.text == "I am get method"
     request, response = app.test_client.post("/")
-    assert response.text == "Error: Method POST not allowed for URL /"
+    assert "Method POST not allowed for URL /" in response.text
 
 
 def test_argument_methods(app):
@@ -151,8 +151,8 @@ def test_with_custom_class_methods(app):
         def get(self, request):
             self._iternal_method()
             return text(
-                "I am get method and global var "
+                f"I am get method and global var "
-                "is {}".format(self.global_var)
+                f"is {self.global_var}"
             )
 
     app.add_route(DummyView.as_view(), "/")

tests/test_worker.py

@@ -128,6 +128,8 @@ def test_handle_quit(worker):
     assert not worker.alive
     assert worker.exit_code == 0
 
+async def _a_noop(*a, **kw):
+    pass
 
 def test_run_max_requests_exceeded(worker):
     loop = asyncio.new_event_loop()
@@ -145,7 +147,7 @@ def test_run_max_requests_exceeded(worker):
         "server2": {"requests_count": 15},
     }
     worker.max_requests = 10
-    worker._run = mock.Mock(wraps=asyncio.coroutine(lambda *a, **kw: None))
+    worker._run = mock.Mock(wraps=_a_noop)
 
     # exceeding request count
     _runner = asyncio.ensure_future(worker._check_alive(), loop=loop)
@@ -160,7 +162,7 @@ def test_run_max_requests_exceeded(worker):
 
 def test_worker_close(worker):
     loop = asyncio.new_event_loop()
-    asyncio.sleep = mock.Mock(wraps=asyncio.coroutine(lambda *a, **kw: None))
+    asyncio.sleep = mock.Mock(wraps=_a_noop)
     worker.ppid = 1
     worker.pid = 2
     worker.cfg.graceful_timeout = 1.0
@@ -169,17 +171,13 @@ def test_worker_close(worker):
     worker.wsgi = mock.Mock()
     conn = mock.Mock()
     conn.websocket = mock.Mock()
-    conn.websocket.close_connection = mock.Mock(
+    conn.websocket.close_connection = mock.Mock(wraps=_a_noop)
-        wraps=asyncio.coroutine(lambda *a, **kw: None)
-    )
     worker.connections = set([conn])
     worker.log = mock.Mock()
     worker.loop = loop
     server = mock.Mock()
     server.close = mock.Mock(wraps=lambda *a, **kw: None)
-    server.wait_closed = mock.Mock(
+    server.wait_closed = mock.Mock(wraps=_a_noop)
-        wraps=asyncio.coroutine(lambda *a, **kw: None)
-    )
     worker.servers = {server: {"requests_count": 14}}
     worker.max_requests = 10
 

tox.ini

@@ -1,11 +1,11 @@
 [tox]
-envlist = py36, py37, pyNightly, {py36,py37,pyNightly}-no-ext, lint, check, security, docs
+envlist = py36, py37, py38, pyNightly, {py36,py37,py38,pyNightly}-no-ext, lint, check, security, docs
 
 [testenv]
 usedevelop = True
 setenv =
-    {py36,py37,pyNightly}-no-ext: SANIC_NO_UJSON=1
+    {py36,py37,py38,pyNightly}-no-ext: SANIC_NO_UJSON=1
-    {py36,py37,pyNightly}-no-ext: SANIC_NO_UVLOOP=1
+    {py36,py37,py38,pyNightly}-no-ext: SANIC_NO_UVLOOP=1
 deps =
     coverage
     pytest==5.2.1
@@ -13,7 +13,7 @@ deps =
     pytest-sanic
     pytest-sugar
     httpcore==0.3.0
-    httpx==0.9.3
+    httpx==0.11.1
     chardet<=2.3.0
     beautifulsoup4
     gunicorn