Update TLS code to use pathlib. Previously Paths were rejected but now both them and str are accepted.

sanic/cookies/request.py

@@ -149,11 +149,13 @@ class CookieRequestParameters(RequestParameters):
         except KeyError:
             return super().get(name, default)
 
-    def getlist(self, name: str) -> list[Any]:
+    def getlist(
+        self, name: str, default: Optional[Any] = None
+    ) -> Optional[Any]:
         try:
             return self._get_prefixed_cookie(name)
         except KeyError:
-            return super().getlist(name)
+            return super().getlist(name, default)
 
     def _get_prefixed_cookie(self, name: str) -> Any:
         getitem = super().__getitem__

sanic/http/tls/context.py

@@ -3,6 +3,7 @@ from __future__ import annotations
 import os
 import ssl
 
+from pathlib import Path, PurePath
 from typing import Any, Dict, Iterable, Optional, Union
 
 from sanic.log import logger
@@ -39,23 +40,23 @@ def create_context(
 
 
 def shorthand_to_ctx(
-    ctxdef: Union[None, ssl.SSLContext, dict, str]
+    ctxdef: Union[None, ssl.SSLContext, dict, PurePath, str]
 ) -> Optional[ssl.SSLContext]:
     """Convert an ssl argument shorthand to an SSLContext object."""
     if ctxdef is None or isinstance(ctxdef, ssl.SSLContext):
         return ctxdef
-    if isinstance(ctxdef, str):
-        return load_cert_dir(ctxdef)
+    if isinstance(ctxdef, (PurePath, str)):
+        return load_cert_dir(Path(ctxdef))
     if isinstance(ctxdef, dict):
         return CertSimple(**ctxdef)
     raise ValueError(
         f"Invalid ssl argument {type(ctxdef)}."
-        " Expecting a list of certdirs, a dict or an SSLContext."
+        " Expecting one/list of: certdir | dict | SSLContext"
     )
 
 
 def process_to_context(
-    ssldef: Union[None, ssl.SSLContext, dict, str, list, tuple]
+    ssldef: Union[None, ssl.SSLContext, dict, PurePath, str, list, tuple]
 ) -> Optional[ssl.SSLContext]:
     """Process app.run ssl argument from easy formats to full SSLContext."""
     return (
@@ -65,11 +66,11 @@ def process_to_context(
     )
 
 
-def load_cert_dir(p: str) -> ssl.SSLContext:
-    if os.path.isfile(p):
+def load_cert_dir(p: Path) -> ssl.SSLContext:
+    if p.is_file():
         raise ValueError(f"Certificate folder expected but {p} is a file.")
-    keyfile = os.path.join(p, "privkey.pem")
-    certfile = os.path.join(p, "fullchain.pem")
+    keyfile = p / "privkey.pem"
+    certfile = p / "fullchain.pem"
     if not os.access(keyfile, os.R_OK):
         raise ValueError(
             f"Certificate not found or permission denied {keyfile}"

sanic/request/parameters.py

@@ -19,14 +19,15 @@ class RequestParameters(dict):
         return super().get(name, [default])[0]
 
     def getlist(
-        self, name: str
-    ) -> list[Any]:
+        self, name: str, default: Optional[Any] = None
+    ) -> Optional[Any]:
         """Return the entire list
 
         Args:
             name (str): The name of the parameter
+            default (Optional[Any], optional): The default value. Defaults to None.
 
         Returns:
-            list[Any]: The entire list of values or [] if not found
+            Optional[Any]: The entire list
         """  # noqa: E501
-        return super().get(name) or []
+        return super().get(name, default)

tests/test_cookies.py

@@ -445,10 +445,10 @@ def test_cookie_accessors(app: Sanic):
                     "four": request.cookies.get("four", "fallback"),
                 },
                 "getlist": {
-                    "one": request.cookies.getlist("one"),
-                    "two": request.cookies.getlist("two"),
-                    "three": request.cookies.getlist("three"),
-                    "four": request.cookies.getlist("four"),
+                    "one": request.cookies.getlist("one", ["fallback"]),
+                    "two": request.cookies.getlist("two", ["fallback"]),
+                    "three": request.cookies.getlist("three", ["fallback"]),
+                    "four": request.cookies.getlist("four", ["fallback"]),
                 },
                 "getattr": {
                     "one": request.cookies.one,
@@ -484,7 +484,7 @@ def test_cookie_accessors(app: Sanic):
             "one": ["1"],
             "two": ["2"],
             "three": ["3"],
-            "four": [],
+            "four": ["fallback"],
         },
         "getattr": {
             "one": "1",